[openmp] Fix build break for less common architectures

[mstorsjo]

Summary

fb947c358661b3bd3d5e1fa776ec74cc0f308854 introduced the gas
macro COMMON, but it was only defined within ifdefs of the form:

#if (KMP_OS_LINUX || KMP_OS_DARWIN || KMP_OS_WINDOWS) && KMP_ARCH_AARCH64

It was used, however, within other conditions:

#if KMP_ARCH_ARM || KMP_ARCH_MIPS

and:

#if KMP_ARCH_PPC64 || KMP_ARCH_AARCH64 || KMP_ARCH_MIPS64 || KMP_ARCH_RISCV64 || KMP_ARCH_LOONGARCH64

Move the definition of the COMMON macro out from the current ifdef,
so that it always gets defined (as it's only dependent on the target
platform).

This fixes building on ARM (and presumabily all the other mentioned
architectures except aarch64).

[DavidSpickett]

openmp/runtime/src/z_Linux_asm.S

185

This would be !KMP_OS_DARWIN && !KMP_OS_WINDOWS. Or !(KMP_OS_DARWIN || KMP_OS_WINDOWS) if you prefer.

You could also ifdef around just the .common line if you wanted to save repeating .macro.

[mstorsjo]

Sharing .macro COMMON, fixed the #else comment

[DavidSpickett]

LGTM

openmp/runtime/src/z_Linux_asm.S

 
 # if KMP_OS_DARWIN
 #  define KMP_PREFIX_UNDERSCORE(x) _##x  // extra underscore for OS X* symbols
 #  define KMP_LABEL(x) L_##x             // form the name of label
 
 .macro ALIGN
   .align $0
 .endmacro
-.macro COMMON name, size, align_power
-  .comm \name, \size
-.endm
 
 .macro DEBUG_INFO
 /* Not sure what .size does in icc, not sure if we need to do something
    similar for OS X*.
 */
 .endmacro
 
 .macro PROC
   ALIGN  4
   .globl KMP_PREFIX_UNDERSCORE($0)
 KMP_PREFIX_UNDERSCORE($0):
 .endmacro
 # elif KMP_OS_WINDOWS
 #  define KMP_PREFIX_UNDERSCORE(x) x  // no extra underscore for Windows/ARM64 symbols
 // Format labels so that they don't override function names in gdb's backtraces
 #  define KMP_LABEL(x) .L_##x         // local label hidden from backtraces
 
 .macro ALIGN size
   .align 1<<(\size)
 .endm
-.macro COMMON name, size, align_power
-  .comm \name, \size, \align_power
-.endm
 
 .macro DEBUG_INFO proc
   ALIGN 2
 .endm
 
 .macro PROC proc
   ALIGN 2
   .globl KMP_PREFIX_UNDERSCORE(\proc)
 KMP_PREFIX_UNDERSCORE(\proc):
 .endm
 # else // KMP_OS_DARWIN || KMP_OS_WINDOWS
 #  define KMP_PREFIX_UNDERSCORE(x) x  // no extra underscore for Linux* OS symbols
 // Format labels so that they don't override function names in gdb's backtraces
 #  define KMP_LABEL(x) .L_##x         // local label hidden from backtraces
 
 .macro ALIGN size
   .align 1<<(\size)
 .endm
-.macro COMMON name, size, align_power
-  .comm \name, \size, (1<<(\align_power))
-.endm
 
 .macro DEBUG_INFO proc
   .cfi_endproc
 // Not sure why we need .type and .size for the functions
   ALIGN 2
   .type  \proc,@function
   .size  \proc,.-\proc
 .endm
 
 .macro PROC proc
   ALIGN 2
   .globl KMP_PREFIX_UNDERSCORE(\proc)
 KMP_PREFIX_UNDERSCORE(\proc):
   .cfi_startproc
 .endm
 # endif // KMP_OS_DARWIN
 
 #endif // (KMP_OS_LINUX || KMP_OS_DARWIN || KMP_OS_WINDOWS) && KMP_ARCH_AARCH64
 
+.macro COMMON name, size, align_power
+#if KMP_OS_DARWIN
+  .comm \name, \size
+#elif KMP_OS_WINDOWS
+  .comm \name, \size, \align_power
+#else // !KMP_OS_DARWIN && !KMP_OS_WINDOWS
+  .comm \name, \size, (1<<(\align_power))
+#endif
+.endm
+
 // -----------------------------------------------------------------------
 // data
 // -----------------------------------------------------------------------
 
 #ifdef KMP_GOMP_COMPAT
 
 // Support for unnamed common blocks.
 //