This is an archive of the discontinued LLVM Phabricator instance.

[gn build] Add build files for //bolt
ClosedPublic

Authored by thakis on Nov 19 2022, 8:51 AM.

Details

Summary

Adds build files for libraries, tools, and tests -- everything except
the runtime.

Doesn't hook up bolt in the main BUILD.gn file yet -- I want to verify
that it builds on Linux, macOS, Windows before doing that. (I've only
checked on macOS so far.)

ninja check-bolt passes on macOS with this.
(I locally bumped the deployment target to macOS 10.12 for that. bolt/ uses
std::mutex quite a bit, which requires 10.12.)

Diff Detail

Event Timeline

thakis created this revision.Nov 19 2022, 8:51 AM
Herald added a reviewer: rafauler. · View Herald Transcript
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
thakis requested review of this revision.Nov 19 2022, 8:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2022, 8:51 AM
Herald added a subscriber: yota9. · View Herald Transcript
thakis updated this revision to Diff 476686.Nov 19 2022, 8:53 AM

run llvm/utils/gn/gn.py format on bolt gn files

This revision is now accepted and ready to land.Nov 20 2022, 4:19 PM
aeubanks accepted this revision.Nov 21 2022, 10:49 AM

one suggestion

llvm/utils/gn/secondary/BUILD.gn
8

if you've already tested on mac, add this below under if (current_os == "macos")?

thakis added inline comments.Nov 21 2022, 12:24 PM
llvm/utils/gn/secondary/BUILD.gn
8

It doesn't build on mac without D138423. But yes, let's just land that first and then I'll do that.

This revision was automatically updated to reflect the committed changes.