This is an archive of the discontinued LLVM Phabricator instance.

[M68k][MC] Make immediate operands relocatable
ClosedPublic

Authored by myhsu on Nov 12 2022, 9:28 PM.

Details

Summary

Sometimes memory addresses are treated as immediate values. Thus immediate operands have to be relocatable.

Diff Detail

Event Timeline

myhsu created this revision.Nov 12 2022, 9:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2022, 9:28 PM
myhsu requested review of this revision.Nov 12 2022, 9:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2022, 9:28 PM
myhsu planned changes to this revision.Nov 14 2022, 9:31 AM

With this patch we need a custom decoder for 32-bit immediate value or disassembler won't be able to recognize the correct word ordering. I will add custom decoder support for variable length instruction in separate patches.

myhsu updated this revision to Diff 490371.Jan 18 2023, 8:50 PM

With D142079 and D142080 we can finally decode immediates of all sizes in the correct way.

0x59616e accepted this revision.Jan 19 2023, 8:30 PM

This amazing work LGTM. Thanks !

This revision is now accepted and ready to land.Jan 19 2023, 8:30 PM
This revision was landed with ongoing or failed builds.Jan 24 2023, 10:03 PM
This revision was automatically updated to reflect the committed changes.