Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[openmp] [test] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows
ClosedPublic
Actions

Authored by mstorsjo on Nov 10 2022, 1:46 AM.

Details

Reviewers

AndreyChurbanov
JonChesterfield
natgla
alvinhochun
jdoerfert
Meinersbur
DavidSpickett
jlpeyton

Commits

rG63f0fdc2628d: [openmp] [test] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows

Summary

Windows heuristics may decide to want to run some tested processes
as elevated (since it may think some of them are installers - executables
with "dispatch" in the name may hit a heuristic looking for "patch").

Set this environment variable to disable this heuristic and just run
the executable with whatever privileges the caller has.

This fixes a couple tests on such versions of Windows where this
heuristic is active.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mstorsjo created this revision.Nov 10 2022, 1:46 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2022, 1:46 AM

Herald added subscribers: guansong, yaxunl. · View Herald Transcript

mstorsjo requested review of this revision.Nov 10 2022, 1:46 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2022, 1:46 AM

Herald added a subscriber: sstefan1. · View Herald Transcript

Harbormaster completed remote builds in B197043: Diff 474477.Nov 10 2022, 1:49 AM

mstorsjo added a reviewer: Meinersbur.Nov 14 2022, 12:10 PM

since it may think some of them are installers - executables with "dispatch" in the name may hit a heuristic looking for "patch"

Wow, didn't know, but other sources confirm it.

openmp/runtime/test/lit.cfg
111–112	Could you add a comment on what this does? I did not know about this, but found https://devblogs.microsoft.com/oldnewthing/20161117-00/?p=94735