- User Since
- May 25 2022, 2:21 AM (70 w, 5 d)
Fri, Sep 8
Yeah, I don't have time to work on this now, and I don't have a good idea how to solve this either.
Sep 1 2023
The code looks fine to me, and I trust that you have tested it.
Jul 9 2023
Sounds like a good diagnostic to me. For the warning message perhaps it can be changed a bit to avoid using a full stop?
May 19 2023
May 16 2023
May 13 2023
Update commit message and comment to reflect latest findings from D149549.
May 12 2023
Thanks for adding me in the loop. The change itself looks fine, though I haven't tried it on MinGW-w64 target yet. Some comments on the tests:
May 11 2023
Weirdly, that test XFAILs here on my i686-windows-msvc environment with check-asan (static runtime) because of different reasons:
May 10 2023
May 9 2023
Since there have been no other comments, I'll go ahead and mark this accepted.
May 8 2023
May 7 2023
Rebase and apply suggestions.
Apply suggestions: remove TODO, put negative tests in the same file as positive tests.
May 6 2023
Looks like a straightforward test fix.
May 5 2023
Rebase and add test cases with offset operator, and some TODOs/FIXMEs for comment
LGTM except for the issue with the test. I guess wait a few days to see if anyone else have other comments, or someone else can accept too.
May 4 2023
May 3 2023
It does work if you add .intel_syntax noprefix to the assembly or pass -mnaked-reg to as.
Yes, what jhenderson said. Also you can see in the pre-merge checks it fails to apply the patch, because what it does is that it first applies the parent patch before applying this patch.
May 2 2023
Apply changes from parent patch
Address some comments
I don't think we should skip empty exports, especially not by checking only the RVA, because it looks like it is theoretically possible to have RVA = 0 but a non-empty name for an export. Even entries with null RVA and null name seems worth keeping as they do take up space in the export table.
May 1 2023
I'm aware of the check-clang failure in CodeGen/ms-inline-asm-functions.c. It seems to be caused by the MS inline assembly being translated in a way that breaks with this patch, which means I may have to look into fixing that code too. That also revealed an issue with my patch regarding how call [offset function] is handled -- apparently GAS treats it the same as call function. I'll try to get this fixed.
Format the commit message better
Apr 30 2023
Ping, can someone accept this revision?
Split the bit making unknown instructions non-fatal into D149549, and change the way errors are reported to avoid direct dependency from interception to sanitizer_common. Now asan registers a callback in interceptor to call __sanitizer::Report.
Apr 28 2023
Apr 27 2023
Superseded by D149064.