Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

alvinhochun (Alvin Wong)
User

Projects

User does not belong to any projects.

User Details

User Since
May 25 2022, 2:21 AM (70 w, 5 d)

Recent Activity

Fri, Sep 8

alvinhochun abandoned D128600: [libc++][mingw] Remove setlocale from snprintf_l.

Yeah, I don't have time to work on this now, and I don't have a good idea how to solve this either.

Fri, Sep 8, 1:09 AM · Restricted Project, Restricted Project

Sep 1 2023

alvinhochun accepted D159223: [llvm-windres] Implement the windres flag --use-temp-file.

The code looks fine to me, and I trust that you have tested it.

Sep 1 2023, 6:39 AM · Restricted Project, Restricted Project

Jul 9 2023

alvinhochun added a comment to D154777: [LLD] [COFF] Warn about pseudo relocations that are too narrow.

Sounds like a good diagnostic to me. For the warning message perhaps it can be changed a bit to avoid using a full stop?

Jul 9 2023, 12:33 AM · Restricted Project, Restricted Project

May 19 2023

alvinhochun added inline comments to D149769: [sanitizer][asan][win][msvc] Correct interception of strdup on windows, additionally correclty intercept memmove/memcpy on i386 windows..
May 19 2023, 4:36 AM · Restricted Project, Restricted Project

May 16 2023

alvinhochun committed rG65abcf6c0ce1: [asan][test][win] Move MSVC-specific tests into a subdir (authored by alvinhochun).
[asan][test][win] Move MSVC-specific tests into a subdir
May 16 2023, 4:55 AM · Restricted Project, Restricted Project
alvinhochun committed rG51015af77377: [asan][test][win] Remove `REQUIRES: asan-rtl-heap-interception` (authored by alvinhochun).
[asan][test][win] Remove `REQUIRES: asan-rtl-heap-interception`
May 16 2023, 4:55 AM · Restricted Project, Restricted Project
alvinhochun committed rG5ad8bbee238f: [asan][test][win] Port more tests to not use clang-cl on MinGW (2) (authored by alvinhochun).
[asan][test][win] Port more tests to not use clang-cl on MinGW (2)
May 16 2023, 4:55 AM · Restricted Project, Restricted Project
alvinhochun committed rGfe4a5a08b96a: [asan][test][win] Port more tests to not use clang-cl on MinGW (4) (authored by alvinhochun).
[asan][test][win] Port more tests to not use clang-cl on MinGW (4)
May 16 2023, 4:55 AM · Restricted Project, Restricted Project
alvinhochun committed rG6282315f8ae5: [asan][test][win] Port more tests to not use clang-cl on MinGW (3) (authored by alvinhochun).
[asan][test][win] Port more tests to not use clang-cl on MinGW (3)
May 16 2023, 4:55 AM · Restricted Project, Restricted Project
alvinhochun closed D150271: [asan][test][win] Move MSVC-specific tests into a subdir.
May 16 2023, 4:55 AM · Restricted Project, Restricted Project
alvinhochun committed rG3237f568403b: [asan][win][test] Disable interception_failure_test.cpp for static asan (authored by alvinhochun).
[asan][win][test] Disable interception_failure_test.cpp for static asan
May 16 2023, 4:55 AM · Restricted Project, Restricted Project
alvinhochun closed D150270: [asan][test][win] Remove `REQUIRES: asan-rtl-heap-interception`.
May 16 2023, 4:54 AM · Restricted Project, Restricted Project
alvinhochun closed D150269: [asan][test][win] Port more tests to not use clang-cl on MinGW (4).
May 16 2023, 4:54 AM · Restricted Project, Restricted Project
alvinhochun closed D150268: [asan][test][win] Port more tests to not use clang-cl on MinGW (3).
May 16 2023, 4:54 AM · Restricted Project, Restricted Project
alvinhochun closed D150267: [asan][test][win] Port more tests to not use clang-cl on MinGW (2).
May 16 2023, 4:54 AM · Restricted Project, Restricted Project
alvinhochun closed D150349: [asan][win][test] Disable interception_failure_test.cpp for static asan.
May 16 2023, 4:54 AM · Restricted Project, Restricted Project

May 13 2023

alvinhochun updated the diff for D150349: [asan][win][test] Disable interception_failure_test.cpp for static asan.

Update commit message and comment to reflect latest findings from D149549.

May 13 2023, 2:08 AM · Restricted Project, Restricted Project
alvinhochun added a comment to D149549: [compiler-rt][interception][win] Don't crash on unknown instructions.

@alvinhochun managed to pinpoint and guess the differing issue.

With WinSDK/UCRT 10.0.19041.0, linking fails, since references to __stdio_common_vfprintf pulls in output.obj from libucrt.lib, and this object file pulls in wcstol from strtox.obj, which then later triggers the duplicate definition.

With libucrt.lib from WinSDK 10.0.22621.0, this no longer happens. But the test still failed, fulfilling the XFAIL, with the following error:

AddressSanitizer: CHECK failed: asan_rtl.cpp:387 "((!asan_init_is_running && "ASan init calls itself!")) != (0)" (0x0, 0x0) (tid=16328)
    <empty stack>

After this patch, this no longer triggers errors, and the test runs successfully. So the original XFAIL condition is dependent on WinSDK version, but there was a second error which made the XFAIL still seem to behave correctly, until after this change.

I can't comment on the rest of whether it's expected that this error condition that previously aborted execution, now no longer triggers a failure.

May 13 2023, 1:58 AM · Restricted Project, Restricted Project

May 12 2023

alvinhochun added a reviewer for D149769: [sanitizer][asan][win][msvc] Correct interception of strdup on windows, additionally correclty intercept memmove/memcpy on i386 windows.: mstorsjo.

Thanks for adding me in the loop. The change itself looks fine, though I haven't tried it on MinGW-w64 target yet. Some comments on the tests:

May 12 2023, 2:24 AM · Restricted Project, Restricted Project
alvinhochun added a comment to D150349: [asan][win][test] Disable interception_failure_test.cpp for static asan.

typo: profided

but on Windows the static asan runtime does intercept static copies of libc functions

can this change in future?

May 12 2023, 1:53 AM · Restricted Project, Restricted Project
alvinhochun added inline comments to D150269: [asan][test][win] Port more tests to not use clang-cl on MinGW (4).
May 12 2023, 1:22 AM · Restricted Project, Restricted Project

May 11 2023

alvinhochun requested review of D150349: [asan][win][test] Disable interception_failure_test.cpp for static asan.
May 11 2023, 2:31 AM · Restricted Project, Restricted Project
alvinhochun added a comment to D149549: [compiler-rt][interception][win] Don't crash on unknown instructions.

Weirdly, that test XFAILs here on my i686-windows-msvc environment with check-asan (static runtime) because of different reasons:

May 11 2023, 2:19 AM · Restricted Project, Restricted Project

May 10 2023

alvinhochun requested review of D150271: [asan][test][win] Move MSVC-specific tests into a subdir.
May 10 2023, 6:35 AM · Restricted Project, Restricted Project
alvinhochun requested review of D150270: [asan][test][win] Remove `REQUIRES: asan-rtl-heap-interception`.
May 10 2023, 6:34 AM · Restricted Project, Restricted Project
alvinhochun requested review of D150269: [asan][test][win] Port more tests to not use clang-cl on MinGW (4).
May 10 2023, 6:34 AM · Restricted Project, Restricted Project
alvinhochun requested review of D150268: [asan][test][win] Port more tests to not use clang-cl on MinGW (3).
May 10 2023, 6:34 AM · Restricted Project, Restricted Project
alvinhochun requested review of D150267: [asan][test][win] Port more tests to not use clang-cl on MinGW (2).
May 10 2023, 6:33 AM · Restricted Project, Restricted Project
alvinhochun added a comment to D149998: [test] [llvm-config] Assume unix style lib names on mingw targets.

I guess target might be anything, for cases that are configured to cross compile by default, so we shouldn't rely on that in this test. I wonder if there's some similar feature we could check for the host instead of the target? Or perhaps we should just mark the windows part of the test UNSUPPORTED: target={{.*-windows-gnu}} and not complicate things more than necessary - that should be enough to achieve what we want here...

May 10 2023, 1:37 AM · Restricted Project, Restricted Project

May 9 2023

alvinhochun accepted D149611: [LLD][COFF] Allow overwriting directives exports with cmd-line exports.

Since there have been no other comments, I'll go ahead and mark this accepted.

May 9 2023, 8:45 AM · Restricted Project, Restricted Project

May 8 2023

alvinhochun committed rG0ecd2e50146d: [X86][MC] Reject `call`/`jmp [offset fn_ref]` in Intel syntax (authored by alvinhochun).
[X86][MC] Reject `call`/`jmp [offset fn_ref]` in Intel syntax
May 8 2023, 9:08 AM · Restricted Project, Restricted Project
alvinhochun committed rG6b996282cee3: [X86][CodeGen] Do not add `offset` for memory reference using symbol (authored by alvinhochun).
[X86][CodeGen] Do not add `offset` for memory reference using symbol
May 8 2023, 9:08 AM · Restricted Project, Restricted Project
alvinhochun committed rG8cd90fd1a823: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only (authored by alvinhochun).
[X86][MC] Fix parsing Intel syntax indirect branch with symbol only
May 8 2023, 9:08 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun closed D150048: [X86][MC] Reject `call`/`jmp [offset fn_ref]` in Intel syntax.
May 8 2023, 9:08 AM · Restricted Project, Restricted Project
alvinhochun closed D150047: [X86][CodeGen] Do not add `offset` for memory reference using symbol.
May 8 2023, 9:08 AM · Restricted Project, Restricted Project
alvinhochun closed D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.
May 8 2023, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

May 7 2023

alvinhochun updated the diff for D150048: [X86][MC] Reject `call`/`jmp [offset fn_ref]` in Intel syntax.

Rebase and apply suggestions.

May 7 2023, 3:06 AM · Restricted Project, Restricted Project
alvinhochun updated the diff for D150047: [X86][CodeGen] Do not add `offset` for memory reference using symbol.

Apply suggestions.

May 7 2023, 3:05 AM · Restricted Project, Restricted Project
alvinhochun updated the diff for D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.

Apply suggestions: remove TODO, put negative tests in the same file as positive tests.

May 7 2023, 3:04 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun added inline comments to D150047: [X86][CodeGen] Do not add `offset` for memory reference using symbol.
May 7 2023, 2:59 AM · Restricted Project, Restricted Project

May 6 2023

alvinhochun updated the summary of D150048: [X86][MC] Reject `call`/`jmp [offset fn_ref]` in Intel syntax.
May 6 2023, 11:45 AM · Restricted Project, Restricted Project
alvinhochun requested review of D150048: [X86][MC] Reject `call`/`jmp [offset fn_ref]` in Intel syntax.
May 6 2023, 11:41 AM · Restricted Project, Restricted Project
alvinhochun requested review of D150047: [X86][CodeGen] Do not add `offset` for memory reference using symbol.
May 6 2023, 11:39 AM · Restricted Project, Restricted Project
alvinhochun accepted D149998: [test] [llvm-config] Assume unix style lib names on mingw targets.

Looks like a straightforward test fix.

May 6 2023, 12:01 AM · Restricted Project, Restricted Project

May 5 2023

alvinhochun added a comment to D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.

OK. I think after D149695 (landed), D149920, and this patch D149579, these cases should be correct.

May 5 2023, 8:18 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun updated the diff for D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.

Rebase and add test cases with offset operator, and some TODOs/FIXMEs for comment

May 5 2023, 8:15 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun added a comment to D149611: [LLD][COFF] Allow overwriting directives exports with cmd-line exports.

LGTM except for the issue with the test. I guess wait a few days to see if anyone else have other comments, or someone else can accept too.

May 5 2023, 2:58 AM · Restricted Project, Restricted Project

May 4 2023

alvinhochun added inline comments to D149611: [LLD][COFF] Allow overwriting directives exports with cmd-line exports.
May 4 2023, 8:03 AM · Restricted Project, Restricted Project
alvinhochun accepted D149610: [llvm-objdump][COFF] Skip empty entries when dumping the export table.

Thanks, LGTM.

May 4 2023, 7:54 AM · Restricted Project, Restricted Project
alvinhochun committed rG1a7a00bdc99f: [compiler-rt][interception][win] Add error messages for some errors (authored by alvinhochun).
[compiler-rt][interception][win] Add error messages for some errors
May 4 2023, 7:42 AM · Restricted Project, Restricted Project
alvinhochun committed rG0716888d828f: [compiler-rt][interception][asan][win] Improve error reporting (authored by alvinhochun).
[compiler-rt][interception][asan][win] Improve error reporting
May 4 2023, 7:42 AM · Restricted Project, Restricted Project
alvinhochun committed rG7b5571f3fc79: [compiler-rt][interception][win] Don't crash on unknown instructions (authored by alvinhochun).
[compiler-rt][interception][win] Don't crash on unknown instructions
May 4 2023, 7:42 AM · Restricted Project, Restricted Project
alvinhochun committed rG814a75dca754: [compiler-rt][asan][win] Intercept exceptions for i686 MinGW (authored by alvinhochun).
[compiler-rt][asan][win] Intercept exceptions for i686 MinGW
May 4 2023, 7:42 AM · Restricted Project, Restricted Project
alvinhochun committed rGca40985ee96e: [compiler-rt][interception][win] Add more assembly patterns (authored by alvinhochun).
[compiler-rt][interception][win] Add more assembly patterns
May 4 2023, 7:42 AM · Restricted Project, Restricted Project
alvinhochun closed D149346: [compiler-rt][interception][win] Add error messages for some errors.
May 4 2023, 7:42 AM · Restricted Project, Restricted Project
alvinhochun closed D149002: [compiler-rt][interception][asan][win] Improve error reporting.
May 4 2023, 7:41 AM · Restricted Project, Restricted Project
alvinhochun closed D149549: [compiler-rt][interception][win] Don't crash on unknown instructions.
May 4 2023, 7:41 AM · Restricted Project, Restricted Project
alvinhochun closed D148991: [compiler-rt][asan][win] Intercept exceptions for i686 MinGW.
May 4 2023, 7:41 AM · Restricted Project, Restricted Project
alvinhochun closed D148990: [compiler-rt][interception][win] Add more assembly patterns.
May 4 2023, 7:41 AM · Restricted Project, Restricted Project
alvinhochun added inline comments to D149002: [compiler-rt][interception][asan][win] Improve error reporting.
May 4 2023, 7:35 AM · Restricted Project, Restricted Project

May 3 2023

alvinhochun added a comment to D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.

It looks we accept a case (t2, w/o or with the patch) that GNU as rejects.

% as -msyntax=intel =(printf 'call qword ptr [rip + fn_ref]') -o gas.o
/tmp/zshjfuv2e: Assembler messages:
/tmp/zshjfuv2e: Warning: end of file not at end of a line; newline inserted
/tmp/zshjfuv2e:1: Error: invalid operands (*UND* and *UND* sections) for `+'

It does work if you add .intel_syntax noprefix to the assembly or pass -mnaked-reg to as.

May 3 2023, 5:41 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun added inline comments to D149002: [compiler-rt][interception][asan][win] Improve error reporting.
May 3 2023, 3:36 AM · Restricted Project, Restricted Project
alvinhochun added a comment to D149611: [LLD][COFF] Allow overwriting directives exports with cmd-line exports.

Yes, what jhenderson said. Also you can see in the pre-merge checks it fails to apply the patch, because what it does is that it first applies the parent patch before applying this patch.

May 3 2023, 3:13 AM · Restricted Project, Restricted Project
alvinhochun added a comment to D149610: [llvm-objdump][COFF] Skip empty entries when dumping the export table.

@hans @alvinhochun The rationale is to simply remove noise from the output when there are sparse ordinals in the table. I'm not quite sure how useful is to keeps those empty entries, since they will be skipped over by the kernel anyway. [...]

I don't think we need to follow exactly the behaviour of dumpbin. Can you check what Binutils objdump does just for comparison?

objdump skips over empty values, as this patch does (using a test added by D149611):

May 3 2023, 3:09 AM · Restricted Project, Restricted Project

May 2 2023

alvinhochun committed rG0d5b51e0ac88: [sanitizer][asan][win] Only unmap unneeded shadow memory on x86_64 (authored by alvinhochun).
[sanitizer][asan][win] Only unmap unneeded shadow memory on x86_64
May 2 2023, 9:23 AM · Restricted Project, Restricted Project
alvinhochun closed D149025: [sanitizer][asan][win] Only unmap unneeded shadow memory on x86_64.
May 2 2023, 9:23 AM · Restricted Project, Restricted Project
alvinhochun requested review of D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.
May 2 2023, 6:53 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun added a comment to D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.

Turns out this change affects MS inline assembly and possibly other inline assemblies as well. Looking at ms-inline-asm-functions.c (on Compiler Explorer - https://godbolt.org/z/3xfW75Go4):

May 2 2023, 4:57 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun updated the diff for D149346: [compiler-rt][interception][win] Add error messages for some errors.

Apply changes from parent patch

May 2 2023, 3:22 AM · Restricted Project, Restricted Project
alvinhochun updated the diff for D149002: [compiler-rt][interception][asan][win] Improve error reporting.

Address some comments

May 2 2023, 3:21 AM · Restricted Project, Restricted Project
alvinhochun added a comment to D149610: [llvm-objdump][COFF] Skip empty entries when dumping the export table.

I don't think we should skip empty exports, especially not by checking only the RVA, because it looks like it is theoretically possible to have RVA = 0 but a non-empty name for an export. Even entries with null RVA and null name seems worth keeping as they do take up space in the export table.

May 2 2023, 2:42 AM · Restricted Project, Restricted Project
alvinhochun added inline comments to D149611: [LLD][COFF] Allow overwriting directives exports with cmd-line exports.
May 2 2023, 2:20 AM · Restricted Project, Restricted Project
alvinhochun requested changes to D149611: [LLD][COFF] Allow overwriting directives exports with cmd-line exports.
May 2 2023, 2:17 AM · Restricted Project, Restricted Project
alvinhochun added inline comments to D149002: [compiler-rt][interception][asan][win] Improve error reporting.
May 2 2023, 12:44 AM · Restricted Project, Restricted Project

May 1 2023

alvinhochun added a comment to D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.

I'm aware of the check-clang failure in CodeGen/ms-inline-asm-functions.c. It seems to be caused by the MS inline assembly being translated in a way that breaks with this patch, which means I may have to look into fixing that code too. That also revealed an issue with my patch regarding how call [offset function] is handled -- apparently GAS treats it the same as call function. I'll try to get this fixed.

May 1 2023, 9:02 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun retitled D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only from [X86][MC] Fix parsing Intel syntax indirect branch with identifier only to [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.
May 1 2023, 5:26 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun updated the diff for D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.

Format the commit message better

May 1 2023, 4:35 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun requested review of D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.
May 1 2023, 4:31 AM · Restricted Project, Restricted Project, Restricted Project
alvinhochun added inline comments to D149002: [compiler-rt][interception][asan][win] Improve error reporting.
May 1 2023, 1:59 AM · Restricted Project, Restricted Project

Apr 30 2023

alvinhochun added a comment to D149025: [sanitizer][asan][win] Only unmap unneeded shadow memory on x86_64.

Ping, can someone accept this revision?

Apr 30 2023, 8:56 AM · Restricted Project, Restricted Project
alvinhochun added inline comments to D149002: [compiler-rt][interception][asan][win] Improve error reporting.
Apr 30 2023, 7:02 AM · Restricted Project, Restricted Project
alvinhochun updated the diff for D149346: [compiler-rt][interception][win] Add error messages for some errors.

Run clang-format

Apr 30 2023, 7:00 AM · Restricted Project, Restricted Project
alvinhochun updated the diff for D149002: [compiler-rt][interception][asan][win] Improve error reporting.

Split the bit making unknown instructions non-fatal into D149549, and change the way errors are reported to avoid direct dependency from interception to sanitizer_common. Now asan registers a callback in interceptor to call __sanitizer::Report.

Apr 30 2023, 6:59 AM · Restricted Project, Restricted Project
alvinhochun requested review of D149549: [compiler-rt][interception][win] Don't crash on unknown instructions.
Apr 30 2023, 6:55 AM · Restricted Project, Restricted Project

Apr 28 2023

alvinhochun added inline comments to D149002: [compiler-rt][interception][asan][win] Improve error reporting.
Apr 28 2023, 2:07 AM · Restricted Project, Restricted Project

Apr 27 2023

alvinhochun accepted D149356: Revert "[openmp] [test] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows".

LGTM

Apr 27 2023, 9:43 AM · Restricted Project, Restricted Project
alvinhochun requested review of D149346: [compiler-rt][interception][win] Add error messages for some errors.
Apr 27 2023, 7:13 AM · Restricted Project, Restricted Project
alvinhochun committed rGf1431bbfb17c: [lit] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows (authored by alvinhochun).
[lit] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows
Apr 27 2023, 1:29 AM · Restricted Project, Restricted Project
alvinhochun closed D149064: [lit] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows.
Apr 27 2023, 1:28 AM · Restricted Project, Restricted Project
alvinhochun abandoned D148988: [asan][test][win] Set __COMPAT_LAYER=RunAsInvoker when running tests.

Superseded by D149064.

Apr 27 2023, 1:26 AM · Restricted Project, Restricted Project

Apr 25 2023

alvinhochun committed rG1194e6f3fa59: [compiler-rt][test] Add `--large-address-aware` link flag for MinGW (authored by alvinhochun).
[compiler-rt][test] Add `--large-address-aware` link flag for MinGW
Apr 25 2023, 4:27 AM · Restricted Project, Restricted Project
alvinhochun committed rG571b94f3d776: [compiler-rt][asan] Add report on intercept fail to more places (authored by alvinhochun).
[compiler-rt][asan] Add report on intercept fail to more places
Apr 25 2023, 4:27 AM · Restricted Project, Restricted Project
alvinhochun closed D148996: [compiler-rt][test] Add `--large-address-aware` link flag for MinGW.
Apr 25 2023, 4:26 AM · Restricted Project, Restricted Project
alvinhochun closed D148989: [compiler-rt][asan] Add report on intercept fail to more places.
Apr 25 2023, 4:26 AM · Restricted Project, Restricted Project

Apr 24 2023

alvinhochun added reviewers for D149064: [lit] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows: abrachet, hubert.reinterpretcast.
Apr 24 2023, 7:23 AM · Restricted Project, Restricted Project
alvinhochun requested review of D149064: [lit] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows.
Apr 24 2023, 7:23 AM · Restricted Project, Restricted Project
alvinhochun committed rG8fa0cfeb61a1: [LLD][COFF] Add /inferasanlibs to lld-link as ignored flag (authored by alvinhochun).
[LLD][COFF] Add /inferasanlibs to lld-link as ignored flag
Apr 24 2023, 7:07 AM · Restricted Project
alvinhochun committed rG9b15e9840f50: [LLD][COFF] Print object file name for unsupported directives (authored by alvinhochun).
[LLD][COFF] Print object file name for unsupported directives
Apr 24 2023, 7:07 AM · Restricted Project
alvinhochun closed D149023: [LLD][COFF] Add /inferasanlibs to lld-link as ignored flag.
Apr 24 2023, 7:07 AM · Restricted Project, Restricted Project
alvinhochun closed D149022: [LLD][COFF] Print object file name for unsupported directives.
Apr 24 2023, 7:07 AM · Restricted Project, Restricted Project