This is an archive of the discontinued LLVM Phabricator instance.

[lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'
ClosedPublic

Authored by probinson on Nov 4 2022, 8:57 AM.

Details

Summary

Part of the project to eliminate special handling for triples in lit expressions.

Diff Detail

Event Timeline

probinson created this revision.Nov 4 2022, 8:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 8:57 AM
probinson requested review of this revision.Nov 4 2022, 8:57 AM
probinson added a subscriber: Restricted Project.
probinson added a project: Restricted Project.Nov 4 2022, 9:00 AM

Adding a comment to see if this is being sent to cfe-commits yet.

probinson edited subscribers, added: cfe-commits; removed: Restricted Project.Nov 4 2022, 9:04 AM

Try again to add the commits list.

hubert.reinterpretcast added inline comments.
clang/test/ClangScanDeps/modules-no-undeclared-includes.c
3

Perhaps we should normalize on -aix while we are doing this?

probinson added inline comments.Nov 4 2022, 11:14 AM
clang/test/ClangScanDeps/modules-no-undeclared-includes.c
3

I'm okay with that, rather than mechanically keeping the equivalent of the substring. Should have no net effect.

ldionne accepted this revision.Nov 22 2022, 8:07 AM

LGTM w/ normalization.

I suggest trying to land these changes sooner rather than later since this is bound to merge conflict and become stale.

This revision is now accepted and ready to land.Nov 22 2022, 8:07 AM
probinson updated this revision to Diff 478382.Nov 28 2022, 2:45 PM
probinson retitled this revision from [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}' to [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'.

Be consistent about using -aix

Lacking an LGTM from someone with AIX knowledge, I see there's a bot "clang-ppc64-aix" where I can verify that the test results haven't changed. For this review the set of tests are mostly UNSUPPORTED, except for three XFAIL. I'll let this sit a little while in case someone has an objection, then go ahead with that plan.

This revision was landed with ongoing or failed builds.Dec 2 2022, 9:44 AM
This revision was automatically updated to reflect the committed changes.

The clang-ppc64-aix bot ran with these changes here and all results are as expected.