Part of the project to eliminate special handling for triples in lit expressions.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/test/ClangScanDeps/modules-no-undeclared-includes.c | ||
---|---|---|
3 | Perhaps we should normalize on -aix while we are doing this? |
clang/test/ClangScanDeps/modules-no-undeclared-includes.c | ||
---|---|---|
3 | I'm okay with that, rather than mechanically keeping the equivalent of the substring. Should have no net effect. |
LGTM w/ normalization.
I suggest trying to land these changes sooner rather than later since this is bound to merge conflict and become stale.
Lacking an LGTM from someone with AIX knowledge, I see there's a bot "clang-ppc64-aix" where I can verify that the test results haven't changed. For this review the set of tests are mostly UNSUPPORTED, except for three XFAIL. I'll let this sit a little while in case someone has an objection, then go ahead with that plan.
Perhaps we should normalize on -aix while we are doing this?