This is an archive of the discontinued LLVM Phabricator instance.

[lit][AIX] Convert llvm tests to use 'target={{.*}}-aix{{.*}}'
ClosedPublic

Authored by probinson on Nov 4 2022, 8:55 AM.

Details

Summary

Part of the project to eliminate special handling for triples in lit expressions.

Diff Detail

Event Timeline

probinson created this revision.Nov 4 2022, 8:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 8:55 AM
probinson requested review of this revision.Nov 4 2022, 8:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2022, 8:55 AM
hubert.reinterpretcast added inline comments.
llvm/test/CodeGen/Generic/externally_available.ll
3

Perhaps we should normalize on -aix while we are doing this?

probinson added inline comments.Nov 4 2022, 11:15 AM
llvm/test/CodeGen/Generic/externally_available.ll
3

I'd be fine with that, should have no net effect.

ldionne accepted this revision.Nov 22 2022, 8:05 AM

LGTM but I am not affiliated with AIX so please wait for someone who is to approve.

llvm/test/CodeGen/Generic/externally_available.ll
3

Yeah, +1 for normalizing.

This revision is now accepted and ready to land.Nov 22 2022, 8:05 AM
probinson updated this revision to Diff 478389.Nov 28 2022, 3:04 PM
probinson retitled this revision from [lit][AIX] Convert llvm tests to use 'target={{.*}}aix{{.*}}' to [lit][AIX] Convert llvm tests to use 'target={{.*}}-aix{{.*}}'.

Consistently use -aix

LGTM but I am not affiliated with AIX so please wait for someone who is to approve.

I think @hubert.reinterpretcast is?

Lacking an LGTM from someone with AIX knowledge, I see there's a bot "clang-ppc64-aix" where I can verify that the test results haven't changed. For this review the set of tests are all XFAIL. I'll let this sit a little while in case someone has an objection, then go ahead with that plan.

This revision was landed with ongoing or failed builds.Dec 2 2022, 9:42 AM
This revision was automatically updated to reflect the committed changes.

The clang-ppc64-aix bot ran with these changes here and all results are as expected.