This is an archive of the discontinued LLVM Phabricator instance.

[FLANG] Fix MSVC + clang-cl build
AbandonedPublic

Authored by omjavaid on Oct 31 2022, 2:02 PM.

Details

Summary

Flang build on windows with MSVC environment and clang-cl compiler
requires clang_rt.builtin.${target} library. This patch allows us to
locate and include this link library. This is mostly needed for flang
runtime and associated unittests. Clang implicitly uses this library
while calling lld-link via clang driver however a standalone call to
lld-link doesnt link against clang_rt library on its own.

Diff Detail

Event Timeline

omjavaid created this revision.Oct 31 2022, 2:02 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 31 2022, 2:02 PM
omjavaid requested review of this revision.Oct 31 2022, 2:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 2 2022, 1:35 AM
This revision was automatically updated to reflect the committed changes.

How come this has landed without review?

omjavaid reopened this revision.Nov 2 2022, 2:07 AM

Landed accidentally. Reverted the change.

Would you know why we cannot see the results of the pre-commit CI?

Would you know why we cannot see the results of the pre-commit CI?

Not sure why pre-commit CI is not triggered for this? Should I send a new change and discard this one. BTW, I used arc diff to create and submit this change.

Would you know why we cannot see the results of the pre-commit CI?

Not sure why pre-commit CI is not triggered for this? Should I send a new change and discard this one. BTW, I used arc diff to create and submit this change.

I also don't know why the CI was not triggered. If it is alrite, please send a new change.

omjavaid abandoned this revision.Nov 15 2022, 3:32 AM