- User Since
- Oct 27 2018, 11:29 PM (108 w, 5 d)
Oct 22 2020
Oct 21 2020
Is 128 for the path size enough?
Aug 24 2020
Aug 10 2020
This probably needs to include CMAKE_CURRENT_BINARY_DIR as a include directory.
Aug 7 2020
Aug 6 2020
Aug 5 2020
What's the reason for keeping these? IMO, the lines should be removed and let FLANG_ENABLE_WERROR cmake option add it if a developer needs it.
Jul 30 2020
Jul 14 2020
Jul 8 2020
Jul 7 2020
@ro, there are some red pre-merge checks. Not sure what those are about. Any ideas?
Jun 12 2020
I'd like to see the -lpthread issue getting fixed before merging this.
Jun 11 2020
Jun 9 2020
Jun 8 2020
I already have merge access, but haven't merged any flang commits till now. It's in now.
Yes, please. Shall I merge this? I don't know what the protocol is in merging.
Jun 6 2020
Closing in favour of https://reviews.llvm.org/D81328
Works for me.
Jun 5 2020
@silvas, mlir_tablegen(IR/ShapeCanonicalization.inc -gen-rewriters) is the only call in the MLIR project with a folder (IR) in it. Others look like mlir_tablegen(SPIRVEnums.h.inc -gen-enum-decls)
I was doing a CMake in-tree build of a out-of-llvm-tree flang. I can reproduce with a CMake out-of-tree build of a out-of-llvm-tree flang and fixed it here.
Use include_directories instead of target_include_directories
This commit breaks building MLIR for me. You need to create the directory IR in the build directory in mlir/lib/Dialect/Shape/CMakeLists.txt. Otherwise mlir-tblgen fails with a file not found error.
Jun 4 2020
Shouldn't the solution be to suppress the warning by adding -Wno-array-bounds if GCC < 8? Or do something like
It has global effects, that is -DDEBUGF18 will be added to all LLVM projects in debug builds, not just flang
Yes, I'd like this to be merged. My email address is email@example.com.
May 18 2020
@mehdi_amini, after this is merged, I will make a new differential to change the default and people can argue there.
I'd really like to get this merged and this doesn't change the status quo.
@mehdi_amini, I'm sorry, what issue is this?
I've added a FLANG_ENABLE_WERROR which is turned on by default on non MSVC builds.
Fix MSVC flag
Turn on -Werror by default on non MSVC platforms
On the call we proposed a compromise of keeping -Werror on by default for Flang but having a local Flang CMake flag to disable it that folks can use that. @isuruf would that unblock you and fix the issue that caused you to submit the patch originally?
May 6 2020
May 5 2020
Prefer compiler builtin over C++ standard library
I've only used this from clang. How do I set it using clang's gnu driver?
Not until https://reviews.llvm.org/D76997 goes in
LLVM headers need fixes to make sure they work with MSVC setting __cplusplus to anything above 201402. For eg: https://reviews.llvm.org/D76997
May 4 2020
@tskeith, no. That can only be done in an out-of-tree build. LLVM doesn't have a mechanism to do it for a specific subproject and adding it here would mean copying that code from LLVM here.
(Using the current code in master is not desirable as the flags in master do not work for some compilers like MSVC.)
This is ready from my end. Just needs a decision on what to do about werror. My preference is to not enable it by default, but others may disagree.
Apr 20 2020
That's fair. Let me know what you think should happen here.
I reverted back. After this is accepted I will make a new differential to change the default where it can be discussed.
This change allows MSVC builds to proceed further and I don't want this to be held back by a decision on the default for werror.
Revert to werror on for standalone builds
Let me know what to do here (I can revert to the commit where Werror is turned on by default to non-MSVC platforms)
If Windows, are we able to make this change conditional on Windows?
Don't enable -Werror by default even on standalone builds
Apr 16 2020
Remove last change
Add option for enable exceptions and rtti
Enable pedantic on standalone build and disable werror on msvc
Remove -Wno-unused-parameter as LLVM adds it anyways
Add a new field originalMxcsr and restore it along with originalFenv
Apr 15 2020
Thanks @sscalpone for the review. Looks like originalFenv_ is still used for restoring the original state. Shall I change the type of originalFenv_ to be unsigned int on x86_64? (Or maybe a union?)
From what I understand originalFenv_ is used for changing and restoring the __mxcsr value (or its equivalents on aarch64).
Remove MSVC mentions
Use _mm_getcsr/_mm_setcsr in all x86_64
I agree that we can use it for all platforms. @sscalpone, what do you think?
Yes, but what about tests and other libraries ?
Using https://github.com/flang-compiler/f18/pull/1095/files should add -fno-rtti and -fno-exceptions automatically on unix and add the equivalent flags on windows as well.
Apr 14 2020
Apr 10 2020
Apr 9 2020
The intention of the code is to set the variable Python3_ROOT_DIR to the value of the variable PYTHON_HOME, but it was using just the string "PYTHON_HOME" instead.
Mar 29 2020
LGTM. I checked out this branch using arc and it builds fine for me and the issue is fixed. Thanks for fixing this issue.