Page MenuHomePhabricator

isuruf (Isuru Fernando)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2018, 11:29 PM (108 w, 5 d)

Recent Activity

Oct 22 2020

isuruf accepted D89369: [flang][windows] Support platform-specific path separator..
Oct 22 2020, 12:14 PM · Restricted Project, Restricted Project

Oct 21 2020

isuruf added a comment to D89369: [flang][windows] Support platform-specific path separator..

Is 128 for the path size enough?

Oct 21 2020, 10:05 AM · Restricted Project, Restricted Project

Aug 24 2020

isuruf accepted D86425: [flang][msvc] Avoid range-based for over initializer_list. NFC..
Aug 24 2020, 2:36 PM · Restricted Project, Restricted Project

Aug 10 2020

isuruf added a comment to D84334: [flang] Version information in flang/f18.

This commit has broken the out of tree builds.

This probably needs to include CMAKE_CURRENT_BINARY_DIR as a include directory.

Aug 10 2020, 1:21 PM · Restricted Project, Restricted Project
isuruf accepted D85656: [flang][msvc] Tell windows.h to not define min/max macros..
Aug 10 2020, 9:45 AM · Restricted Project, Restricted Project

Aug 7 2020

isuruf added a reviewer for D85562: [clang] Allow cross-compiling in standalone builds: Restricted Project.
Aug 7 2020, 3:46 PM · Restricted Project
isuruf requested review of D85562: [clang] Allow cross-compiling in standalone builds.
Aug 7 2020, 3:46 PM · Restricted Project

Aug 6 2020

isuruf accepted D85355: [flang][msvc] Do not use gcc/clang command line options for msvc..
Aug 6 2020, 8:50 AM · Restricted Project

Aug 5 2020

isuruf added a comment to D85355: [flang][msvc] Do not use gcc/clang command line options for msvc..

What's the reason for keeping these? IMO, the lines should be removed and let FLANG_ENABLE_WERROR cmake option add it if a developer needs it.

Aug 5 2020, 10:12 PM · Restricted Project

Jul 30 2020

isuruf added inline comments to D84334: [flang] Version information in flang/f18.
Jul 30 2020, 10:13 AM · Restricted Project, Restricted Project

Jul 14 2020

isuruf committed rG9017b9ce1a14: [flang] Turn off FLANG_ENABLE_WERROR by default (authored by isuruf).
[flang] Turn off FLANG_ENABLE_WERROR by default
Jul 14 2020, 10:18 AM
isuruf closed D81695: [flang] Turn off FLANG_ENABLE_WERROR by default.
Jul 14 2020, 10:18 AM · Restricted Project, Restricted Project

Jul 8 2020

isuruf committed rG2ebf4b6e4c35: [flang] Fix setting mxcsr on MSVC (authored by isuruf).
[flang] Fix setting mxcsr on MSVC
Jul 8 2020, 5:25 AM
isuruf closed D77815: [flang] Fix setting mxcsr on MSVC.
Jul 8 2020, 5:25 AM · Restricted Project, Restricted Project

Jul 7 2020

isuruf added a comment to D77815: [flang] Fix setting mxcsr on MSVC.

@ro, there are some red pre-merge checks. Not sure what those are about. Any ideas?

Jul 7 2020, 2:15 PM · Restricted Project, Restricted Project

Jun 12 2020

isuruf added inline comments to D80377: [flang] Google test infrastructure support for unittests.
Jun 12 2020, 11:10 PM · Restricted Project, Restricted Project
isuruf added inline comments to D80377: [flang] Google test infrastructure support for unittests.
Jun 12 2020, 3:58 PM · Restricted Project, Restricted Project
isuruf added a comment to D80377: [flang] Google test infrastructure support for unittests.

I'd like to see the -lpthread issue getting fixed before merging this.

Jun 12 2020, 9:48 AM · Restricted Project, Restricted Project

Jun 11 2020

isuruf added a project to D81695: [flang] Turn off FLANG_ENABLE_WERROR by default: Restricted Project.
Jun 11 2020, 3:29 PM · Restricted Project, Restricted Project
isuruf created D81695: [flang] Turn off FLANG_ENABLE_WERROR by default.
Jun 11 2020, 3:26 PM · Restricted Project, Restricted Project
isuruf updated subscribers of D81695: [flang] Turn off FLANG_ENABLE_WERROR by default.
Jun 11 2020, 3:26 PM · Restricted Project, Restricted Project

Jun 9 2020

isuruf created D81526: [mlir] Build a native mlir-linalg-ods-gen when cross-compiling.
Jun 9 2020, 8:25 PM · Restricted Project

Jun 8 2020

isuruf committed rGbb73d1b278eb: [flang] Fix issue of flang/runtime/config.h not being found in out of tree… (authored by isuruf).
[flang] Fix issue of flang/runtime/config.h not being found in out of tree…
Jun 8 2020, 12:45 PM
isuruf closed D81266: [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds.
Jun 8 2020, 12:44 PM · Restricted Project, Restricted Project
isuruf added a comment to D81266: [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds.

I already have merge access, but haven't merged any flang commits till now. It's in now.

Jun 8 2020, 12:41 PM · Restricted Project, Restricted Project
isuruf added a comment to D81266: [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds.

Yes, please. Shall I merge this? I don't know what the protocol is in merging.

Jun 8 2020, 11:35 AM · Restricted Project, Restricted Project

Jun 6 2020

isuruf abandoned D81283: [mlir] Fix a build error and a warning in mlir.

Closing in favour of https://reviews.llvm.org/D81328

Jun 6 2020, 12:16 PM · Restricted Project
isuruf accepted D81328: [mlir] Restructure Shape dialect's CMakeLists..

Works for me.

Jun 6 2020, 8:31 AM · Restricted Project

Jun 5 2020

isuruf added a comment to D81283: [mlir] Fix a build error and a warning in mlir.

@silvas, mlir_tablegen(IR/ShapeCanonicalization.inc -gen-rewriters) is the only call in the MLIR project with a folder (IR) in it. Others look like mlir_tablegen(SPIRVEnums.h.inc -gen-enum-decls)

Jun 5 2020, 2:02 PM · Restricted Project
isuruf added inline comments to D81283: [mlir] Fix a build error and a warning in mlir.
Jun 5 2020, 11:10 AM · Restricted Project
isuruf created D81283: [mlir] Fix a build error and a warning in mlir.
Jun 5 2020, 11:10 AM · Restricted Project
isuruf added a comment to D80304: [mlir] Canonicalization of shape.cstr_broadcastable.

https://reviews.llvm.org/D81283

Jun 5 2020, 11:10 AM · Restricted Project, Restricted Project
isuruf added a comment to D81266: [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds.

I was doing a CMake in-tree build of a out-of-llvm-tree flang. I can reproduce with a CMake out-of-tree build of a out-of-llvm-tree flang and fixed it here.

Jun 5 2020, 11:10 AM · Restricted Project, Restricted Project
isuruf updated the diff for D81266: [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds.

Use include_directories instead of target_include_directories

Jun 5 2020, 10:36 AM · Restricted Project, Restricted Project
isuruf added a comment to D80304: [mlir] Canonicalization of shape.cstr_broadcastable.

This commit breaks building MLIR for me. You need to create the directory IR in the build directory in mlir/lib/Dialect/Shape/CMakeLists.txt. Otherwise mlir-tblgen fails with a file not found error.

Jun 5 2020, 10:35 AM · Restricted Project, Restricted Project
isuruf retitled D81266: [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds from [flang] Fix issue of flang/runtime/config.h note being found in out of tree builds to [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds.
Jun 5 2020, 9:25 AM · Restricted Project, Restricted Project
isuruf retitled D81266: [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds from Fix issue of flang/runtime/config.h note bing found in out of tree builds to Fix issue of flang/runtime/config.h note being found in out of tree builds.
Jun 5 2020, 8:52 AM · Restricted Project, Restricted Project
isuruf added a project to D81266: [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds: Restricted Project.
Jun 5 2020, 8:52 AM · Restricted Project, Restricted Project
isuruf created D81266: [flang] Fix issue of flang/runtime/config.h not being found in out of tree builds.
Jun 5 2020, 8:52 AM · Restricted Project, Restricted Project

Jun 4 2020

isuruf added a comment to D81208: Apply fix from D81179 only from GCC < 8.

Shouldn't the solution be to suppress the warning by adding -Wno-array-bounds if GCC < 8? Or do something like

Jun 4 2020, 11:25 PM · Restricted Project, Restricted Project
isuruf added a comment to D80794: [flang] Fix release build flags..

It has global effects, that is -DDEBUGF18 will be added to all LLVM projects in debug builds, not just flang

Jun 4 2020, 3:29 PM · Restricted Project, Restricted Project
isuruf added a comment to D78306: [flang] Use LLVM's flags.

Yes, I'd like this to be merged. My email address is isuruf@gmail.com.

Jun 4 2020, 8:44 AM · Restricted Project, Restricted Project

May 18 2020

isuruf added inline comments to D76997: Fix StringRef::strLen in windows with clang++ C++17.
May 18 2020, 11:57 PM · Restricted Project
isuruf added inline comments to D78306: [flang] Use LLVM's flags.
May 18 2020, 11:17 PM · Restricted Project, Restricted Project
isuruf added a comment to D78306: [flang] Use LLVM's flags.

@mehdi_amini, after this is merged, I will make a new differential to change the default and people can argue there.
I'd really like to get this merged and this doesn't change the status quo.

May 18 2020, 1:33 PM · Restricted Project, Restricted Project
isuruf added a comment to D78306: [flang] Use LLVM's flags.

@mehdi_amini, I'm sorry, what issue is this?

May 18 2020, 12:26 PM · Restricted Project, Restricted Project
isuruf updated the diff for D78306: [flang] Use LLVM's flags.

Simplify logic

May 18 2020, 10:47 AM · Restricted Project, Restricted Project
isuruf added a comment to D78306: [flang] Use LLVM's flags.

I've added a FLANG_ENABLE_WERROR which is turned on by default on non MSVC builds.

May 18 2020, 10:47 AM · Restricted Project, Restricted Project
isuruf updated the diff for D78306: [flang] Use LLVM's flags.

Fix MSVC flag

May 18 2020, 10:15 AM · Restricted Project, Restricted Project
isuruf updated the diff for D78306: [flang] Use LLVM's flags.

Turn on -Werror by default on non MSVC platforms

May 18 2020, 10:13 AM · Restricted Project, Restricted Project
isuruf added a comment to D78306: [flang] Use LLVM's flags.

On the call we proposed a compromise of keeping -Werror on by default for Flang but having a local Flang CMake flag to disable it that folks can use that. @isuruf would that unblock you and fix the issue that caused you to submit the patch originally?

May 18 2020, 10:13 AM · Restricted Project, Restricted Project

May 6 2020

isuruf added inline comments to D76997: Fix StringRef::strLen in windows with clang++ C++17.
May 6 2020, 11:52 AM · Restricted Project
isuruf added inline comments to D76997: Fix StringRef::strLen in windows with clang++ C++17.
May 6 2020, 8:02 AM · Restricted Project

May 5 2020

isuruf added inline comments to D76997: Fix StringRef::strLen in windows with clang++ C++17.
May 5 2020, 5:49 PM · Restricted Project
isuruf added inline comments to D76997: Fix StringRef::strLen in windows with clang++ C++17.
May 5 2020, 5:49 PM · Restricted Project
isuruf updated the diff for D76997: Fix StringRef::strLen in windows with clang++ C++17.

Prefer compiler builtin over C++ standard library

May 5 2020, 4:45 PM · Restricted Project
isuruf added a comment to D76997: Fix StringRef::strLen in windows with clang++ C++17.

I've only used this from clang. How do I set it using clang's gnu driver?

May 5 2020, 8:35 AM · Restricted Project
isuruf added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..

Not until https://reviews.llvm.org/D76997 goes in

May 5 2020, 7:30 AM · Restricted Project, Restricted Project
isuruf added a comment to D78186: [flang] Don't check __cplusplus value with MSVC..

LLVM headers need fixes to make sure they work with MSVC setting __cplusplus to anything above 201402. For eg: https://reviews.llvm.org/D76997

May 5 2020, 6:57 AM · Restricted Project, Restricted Project

May 4 2020

isuruf added a comment to D78306: [flang] Use LLVM's flags.

@tskeith, no. That can only be done in an out-of-tree build. LLVM doesn't have a mechanism to do it for a specific subproject and adding it here would mean copying that code from LLVM here.
(Using the current code in master is not desirable as the flags in master do not work for some compilers like MSVC.)

May 4 2020, 12:21 PM · Restricted Project, Restricted Project
isuruf added a comment to D78306: [flang] Use LLVM's flags.

This is ready from my end. Just needs a decision on what to do about werror. My preference is to not enable it by default, but others may disagree.

May 4 2020, 11:15 AM · Restricted Project, Restricted Project

Apr 20 2020

isuruf added a comment to D78306: [flang] Use LLVM's flags.

That's fair. Let me know what you think should happen here.

Apr 20 2020, 2:38 PM · Restricted Project, Restricted Project
isuruf added a comment to D78306: [flang] Use LLVM's flags.

I reverted back. After this is accepted I will make a new differential to change the default where it can be discussed.
This change allows MSVC builds to proceed further and I don't want this to be held back by a decision on the default for werror.

Apr 20 2020, 11:53 AM · Restricted Project, Restricted Project
isuruf updated the diff for D78306: [flang] Use LLVM's flags.

Revert to werror on for standalone builds

Apr 20 2020, 11:53 AM · Restricted Project, Restricted Project
isuruf added a comment to D78306: [flang] Use LLVM's flags.

Let me know what to do here (I can revert to the commit where Werror is turned on by default to non-MSVC platforms)

Apr 20 2020, 11:53 AM · Restricted Project, Restricted Project
isuruf added a comment to D78306: [flang] Use LLVM's flags.

If Windows, are we able to make this change conditional on Windows?

Apr 20 2020, 9:11 AM · Restricted Project, Restricted Project
isuruf updated the diff for D78306: [flang] Use LLVM's flags.

Don't enable -Werror by default even on standalone builds

Apr 20 2020, 8:37 AM · Restricted Project, Restricted Project

Apr 16 2020

isuruf added inline comments to D78306: [flang] Use LLVM's flags.
Apr 16 2020, 9:38 PM · Restricted Project, Restricted Project
isuruf updated the diff for D78306: [flang] Use LLVM's flags.

Remove last change

Apr 16 2020, 5:18 PM · Restricted Project, Restricted Project
isuruf updated the diff for D78306: [flang] Use LLVM's flags.

Add option for enable exceptions and rtti

Apr 16 2020, 4:10 PM · Restricted Project, Restricted Project
isuruf added inline comments to D78306: [flang] Use LLVM's flags.
Apr 16 2020, 11:45 AM · Restricted Project, Restricted Project
isuruf updated the diff for D78306: [flang] Use LLVM's flags.

Enable pedantic on standalone build and disable werror on msvc

Apr 16 2020, 11:44 AM · Restricted Project, Restricted Project
isuruf added inline comments to D78306: [flang] Use LLVM's flags.
Apr 16 2020, 11:41 AM · Restricted Project, Restricted Project
isuruf added inline comments to D78306: [flang] Use LLVM's flags.
Apr 16 2020, 11:08 AM · Restricted Project, Restricted Project
isuruf updated the diff for D78306: [flang] Use LLVM's flags.

Remove -Wno-unused-parameter as LLVM adds it anyways

Apr 16 2020, 10:01 AM · Restricted Project, Restricted Project
isuruf created D78306: [flang] Use LLVM's flags.
Apr 16 2020, 9:27 AM · Restricted Project, Restricted Project
isuruf updated the diff for D77815: [flang] Fix setting mxcsr on MSVC.

Add a new field originalMxcsr and restore it along with originalFenv

Apr 16 2020, 6:43 AM · Restricted Project, Restricted Project
isuruf updated the diff for D77815: [flang] Fix setting mxcsr on MSVC.

Refactor

Apr 16 2020, 6:43 AM · Restricted Project, Restricted Project

Apr 15 2020

isuruf added a comment to D77815: [flang] Fix setting mxcsr on MSVC.

Thanks @sscalpone for the review. Looks like originalFenv_ is still used for restoring the original state. Shall I change the type of originalFenv_ to be unsigned int on x86_64? (Or maybe a union?)
From what I understand originalFenv_ is used for changing and restoring the __mxcsr value (or its equivalents on aarch64).

Apr 15 2020, 5:42 PM · Restricted Project, Restricted Project
isuruf updated the diff for D77815: [flang] Fix setting mxcsr on MSVC.

Remove MSVC mentions

Apr 15 2020, 11:30 AM · Restricted Project, Restricted Project
isuruf updated the diff for D77815: [flang] Fix setting mxcsr on MSVC.

Use _mm_getcsr/_mm_setcsr in all x86_64

Apr 15 2020, 11:30 AM · Restricted Project, Restricted Project
isuruf added a comment to D77815: [flang] Fix setting mxcsr on MSVC.

I agree that we can use it for all platforms. @sscalpone, what do you think?

Apr 15 2020, 8:44 AM · Restricted Project, Restricted Project
isuruf added a comment to D78185: [flang] Use the equivalent compilation flags with MSVC..

Yes, but what about tests and other libraries ?

Apr 15 2020, 7:05 AM · Restricted Project, Restricted Project
isuruf added a comment to D78185: [flang] Use the equivalent compilation flags with MSVC..

Using https://github.com/flang-compiler/f18/pull/1095/files should add -fno-rtti and -fno-exceptions automatically on unix and add the equivalent flags on windows as well.

Apr 15 2020, 4:53 AM · Restricted Project, Restricted Project

Apr 14 2020

isuruf committed rG664fda72eaa3: Fix setting Python3_ROOT_DIR on Windows (authored by isuruf).
Fix setting Python3_ROOT_DIR on Windows
Apr 14 2020, 11:17 AM
isuruf closed D77842: Fix setting Python3_ROOT_DIR on Windows.
Apr 14 2020, 11:17 AM · Restricted Project

Apr 10 2020

isuruf updated the summary of D77842: Fix setting Python3_ROOT_DIR on Windows.
Apr 10 2020, 4:42 PM · Restricted Project

Apr 9 2020

isuruf added a comment to D77842: Fix setting Python3_ROOT_DIR on Windows.

The intention of the code is to set the variable Python3_ROOT_DIR to the value of the variable PYTHON_HOME, but it was using just the string "PYTHON_HOME" instead.

Apr 9 2020, 7:36 PM · Restricted Project
isuruf added a reviewer for D77842: Fix setting Python3_ROOT_DIR on Windows: Restricted Project.
Apr 9 2020, 5:58 PM · Restricted Project
isuruf created D77842: Fix setting Python3_ROOT_DIR on Windows.
Apr 9 2020, 5:58 PM · Restricted Project
isuruf committed rGea5efd1ea87e: [flang] Support platforms without strerror_r (authored by isuruf).
[flang] Support platforms without strerror_r
Apr 9 2020, 1:06 PM
isuruf committed rGddb68d248cfd: [flang] Support windows where mkstemp and ftruncate doesn't exist (authored by isuruf).
[flang] Support windows where mkstemp and ftruncate doesn't exist
Apr 9 2020, 1:06 PM
GitHub <noreply@github.com> committed rG231fae90874b: [flang] Need <algorithm> for std::min and std::max (flang-compiler/f18#1063) (authored by isuruf).
[flang] Need <algorithm> for std::min and std::max (flang-compiler/f18#1063)
Apr 9 2020, 1:02 PM
isuruf committed rG0a8a6cd9215a: [flang] Fix an ambiguous overload error (authored by isuruf).
[flang] Fix an ambiguous overload error
Apr 9 2020, 1:01 PM
isuruf committed rG59baf8b82270: [flang] Rename EXTERN_C_END to FORTRAN_EXTERN_C_END (authored by isuruf).
[flang] Rename EXTERN_C_END to FORTRAN_EXTERN_C_END
Apr 9 2020, 1:01 PM
GitHub <noreply@github.com> committed rGca861fd4946f: [flang] Add missing array include (flang-compiler/f18#1004) (authored by isuruf).
[flang] Add missing array include (flang-compiler/f18#1004)
Apr 9 2020, 12:54 PM
GitHub <noreply@github.com> committed rG256b53688e3a: [flang] Disable 80-bit extended precision if on MSVC (flang-compiler/f18#1003) (authored by isuruf).
[flang] Disable 80-bit extended precision if on MSVC (flang-compiler/f18#1003)
Apr 9 2020, 12:53 PM
isuruf added reviewers for D77815: [flang] Fix setting mxcsr on MSVC: sscalpone, DavidTruby.
Apr 9 2020, 11:27 AM · Restricted Project, Restricted Project
isuruf created D77815: [flang] Fix setting mxcsr on MSVC.
Apr 9 2020, 11:25 AM · Restricted Project, Restricted Project

Mar 29 2020

isuruf added a comment to D76615: [mlir][test] NFC - Rename cblas to mlir_test_cblas.

LGTM. I checked out this branch using arc and it builds fine for me and the issue is fixed. Thanks for fixing this issue.

Mar 29 2020, 11:13 AM · Restricted Project