This is an archive of the discontinued LLVM Phabricator instance.

Differential D136825

llvm-debuginfo-analyzer] (08/09) - ELF Reader - - Test case (No available targets)
ClosedPublic

Authored by CarlosAlbertoEnciso on Oct 27 2022, 2:11 AM.

Details

Reviewers
probinson
jryans
omjavaid
Orlando
psamolysov
Summary

The unitest and test cases are platform dependent (x86_64)
causing failures in:

https://lab.llvm.org/buildbot/#/builders/245/builds/146
https://lab.llvm.org/buildbot/#/builders/188/builds/21397
No available targets are compatible with triple "x86_64-unknown-unknown".

Added:

  • ';REQUIRES: x86-registered-target' to the LIT tests.
  • Code to check if the target 'Triple::x86_64' is supported to the unittest case.

Diff Detail

Event Timeline

CarlosAlbertoEnciso created this revision.Oct 27 2022, 2:11 AM
Herald added subscribers: manas, ASDenysPetrov, pengfei and 5 others. · View Herald TranscriptOct 27 2022, 2:11 AM
CarlosAlbertoEnciso requested review of this revision.Oct 27 2022, 2:11 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 27 2022, 2:11 AM
Harbormaster completed remote builds in B194593: Diff 471079.Oct 27 2022, 2:11 AM
CarlosAlbertoEnciso mentioned this in D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.Oct 27 2022, 2:13 AM
jryans accepted this revision.Oct 27 2022, 2:42 AM

Looks good, thanks for the quick fix! 🙂

This revision is now accepted and ready to land.Oct 27 2022, 2:42 AM
CarlosAlbertoEnciso added a comment.Oct 27 2022, 4:32 AM
In D136825#3887897, @jryans wrote:

Looks good, thanks for the quick fix! 🙂

Thanks very much for your review. The patch fixed all the No available targets are compatible with triple "x86_64-unknown-unknown". build failures.
But created a dependency on MC that is detected only with the multistage builds.
Uploaded a path to review https://reviews.llvm.org/D136837

CarlosAlbertoEnciso closed this revision.Oct 28 2022, 6:06 AM

Commit: https://reviews.llvm.org/rGd858447584a0dc41ecdee7c92bb5e8b7f52e3ff0

Revision Contents

Diff 471079

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-compare-logical-elements.test

; REQUIRES: x86-registered-target
; Test case 1 - General options ; Test case 1 - General options
; test.cpp ; test.cpp

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-print-basic-details.test

; REQUIRES: x86-registered-target
; Test case 1 - General options. ; Test case 1 - General options.
; test.cpp ; test.cpp

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-select-logical-elements.test

; REQUIRES: x86-registered-target
; Test case 1 - General options ; Test case 1 - General options
; test.cpp ; test.cpp

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/02-dwarf-logical-lines.test

; REQUIRES: x86-registered-target
; Test case 2 - Assembler instructions. ; Test case 2 - Assembler instructions.
; hello-world.cpp ; hello-world.cpp

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/03-dwarf-incorrect-lexical-scope-typedef.test

; REQUIRES: x86-registered-target
; Test case 3 - Incorrect lexical scope for typedef. ; Test case 3 - Incorrect lexical scope for typedef.
; pr-44884.cpp ; pr-44884.cpp

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/04-dwarf-missing-nested-enumerators.test

; REQUIRES: x86-registered-target
; Test case 4 - Missing nested enumerations. ; Test case 4 - Missing nested enumerations.
; pr-46466.cpp ; pr-46466.cpp

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/05-dwarf-incorrect-lexical-scope-variable.test

; REQUIRES: x86-registered-target
; Test case 5 - Incorrect lexical scope variable. ; Test case 5 - Incorrect lexical scope variable.
; pr-43860.cpp ; pr-43860.cpp

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test

; REQUIRES: x86-registered-target
; Test case 6 - Full logical view ; Test case 6 - Full logical view
; test.cpp ; test.cpp

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/pr-57040-ignored-DW_FORM_implicit_const.test

; REQUIRES: x86-registered-target
; Ignored attributes with DW_FORM_implicit_const. ; Ignored attributes with DW_FORM_implicit_const.
; https://github.com/llvm/llvm-project/issues/57040 ; https://github.com/llvm/llvm-project/issues/57040

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/pr-57040-incorrect-function-compare.test

; REQUIRES: x86-registered-target
; Incorrect function matching during comparison. ; Incorrect function matching during comparison.
; https://github.com/llvm/llvm-project/issues/57040 ; https://github.com/llvm/llvm-project/issues/57040

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/pr-incorrect-logical-instructions.test

; REQUIRES: x86-registered-target
; * Added incorrect logical instructions for: --print=lines,instructions ; * Added incorrect logical instructions for: --print=lines,instructions
; 'bar' and 'foo' showing extra instruction from compiler generated functions: ; 'bar' and 'foo' showing extra instruction from compiler generated functions:
; '_cxx_global_var_init' and '_GLOBAL_sub_l_suite_lexical_01.cpp' ; '_cxx_global_var_init' and '_GLOBAL_sub_l_suite_lexical_01.cpp'

llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp

Context not available.
#include "llvm/DebugInfo/LogicalView/Core/LVSymbol.h" #include "llvm/DebugInfo/LogicalView/Core/LVSymbol.h"
#include "llvm/DebugInfo/LogicalView/Core/LVType.h" #include "llvm/DebugInfo/LogicalView/Core/LVType.h"
#include "llvm/DebugInfo/LogicalView/LVReaderHandler.h" #include "llvm/DebugInfo/LogicalView/LVReaderHandler.h"
#include "llvm/MC/TargetRegistry.h"
#include "llvm/Support/COM.h" #include "llvm/Support/COM.h"
#include "llvm/Support/InitLLVM.h" #include "llvm/Support/InitLLVM.h"
#include "llvm/Support/ScopedPrinter.h" #include "llvm/Support/ScopedPrinter.h"
Context not available.
SmallString<128> InputsDir = unittest::getInputFileDirectory(TestMainArgv0); SmallString<128> InputsDir = unittest::getInputFileDirectory(TestMainArgv0);
// This test requires a x86-registered-target
Triple TT;
TT.setArch(Triple::x86_64);
TT.setVendor(Triple::UnknownVendor);
TT.setOS(Triple::UnknownOS);
std::string TargetLookupError;
if (!TargetRegistry::lookupTarget(std::string(TT.str()), TargetLookupError))
return;
// Logical elements general properties and selection. // Logical elements general properties and selection.
elementProperties(InputsDir); elementProperties(InputsDir);
elementSelection(InputsDir); elementSelection(InputsDir);
Context not available.