This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Refactor debug printing routines for GCNRPTracker
ClosedPublic

Authored by vpykhtin on Oct 25 2022, 11:10 AM.

Details

Summary

Use Printable to enhance syntax, remove duplication, unify.

Diff Detail

Unit TestsFailed

Event Timeline

vpykhtin created this revision.Oct 25 2022, 11:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2022, 11:10 AM
vpykhtin requested review of this revision.Oct 25 2022, 11:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2022, 11:10 AM
rampitec added inline comments.Oct 25 2022, 12:02 PM
llvm/lib/Target/AMDGPU/GCNRegPressure.h
89

Can we retain/reimplement dump() for use from the debugger?

vpykhtin updated this revision to Diff 470593.Oct 25 2022, 12:20 PM

restored dump() method

vpykhtin marked an inline comment as done.Oct 25 2022, 12:21 PM
This revision is now accepted and ready to land.Oct 25 2022, 12:25 PM
arsenm accepted this revision.Oct 25 2022, 1:23 PM
arsenm accepted this revision.Oct 27 2022, 8:14 AM
This revision was landed with ongoing or failed builds.Oct 27 2022, 7:23 PM
This revision was automatically updated to reflect the committed changes.