This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Add EXPENSIVE_CHECK into GCNRPTracker::reset
ClosedPublic

Authored by vpykhtin on Oct 27 2022, 9:49 AM.

Details

Summary

This would check if passed in live-ins registers match those calculated using LIS.

This check currently breaks 420 lit tests when enabled.

Diff Detail

Event Timeline

vpykhtin created this revision.Oct 27 2022, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2022, 9:49 AM
vpykhtin requested review of this revision.Oct 27 2022, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2022, 9:49 AM
arsenm added inline comments.Oct 27 2022, 9:59 AM
llvm/lib/Target/AMDGPU/GCNRegPressure.cpp
274

llvm_unreachable

vpykhtin updated this revision to Diff 471228.Oct 27 2022, 10:50 AM

replaced assert with llvm_unreachable

vpykhtin marked an inline comment as done.Oct 27 2022, 10:50 AM
arsenm accepted this revision.Oct 27 2022, 10:58 AM
This revision is now accepted and ready to land.Oct 27 2022, 10:58 AM
This revision was automatically updated to reflect the committed changes.