[lit][REQUIRES] Fix some tests with incorrect REQUIRES clauses

[probinson]

Summary

These weren't running anywhere because of bad specifications.
One test has bit-rotted and had to be XFAILed, the rest are okay.

[jhenderson]

llvm/test/Analysis/BasicAA/cs-cs-arm.ll

3–4

Have you raised a bug for this?

llvm/test/CodeGen/Hexagon/abi-padding-2.ll

2

I'm not familiar with these tests, so this might be a silly question, but why isn't this required? Is it in the lit config?

[probinson]

llvm/test/Analysis/BasicAA/cs-cs-arm.ll

3–4

Not yet. I was hoping someone who understood the test would provide guidance. If that's not happening, I will raise a bug when this goes in.

llvm/test/CodeGen/Hexagon/abi-padding-2.ll

2

Yes, test/CodeGen/Hexagon already marks the entire directory as unsupported unless hexagon is enabled. If it didn't, then this would have changed to hexagon-registered-target.

[jhenderson]

Okay, looks good from my point of view, but probably worth giving a bit of time for someone to have a chance to comment on the bit-rotted test.

[probinson]

llvm/test/Analysis/BasicAA/cs-cs-arm.ll

3–4

Filed issue 58738

[ikudrin]

llvm/test/MC/AsmParser/layout-interdependency.s

2

Actually, this should be object-emission instead, because not all default targets can generate object files (see D121996 for other examples).

[probinson]

llvm/test/MC/AsmParser/layout-interdependency.s

2

Thanks! fixed in rG38c07d9

llvm/test/Analysis/BasicAA/cs-cs-arm.ll

 ; RUN: opt < %s -aa-pipeline=basic-aa -passes=aa-eval -print-all-alias-modref-info -disable-output 2>&1 | FileCheck %s
-; REQUIRES: arm
+; REQUIRES: arm-registered-target
+; This hasn't been run in a long time and it no longer matches reality.
+; XFAIL: *
 
 target datalayout = "e-p:32:32:32-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:32-f32:32:32-f64:32:32-v64:32:64-v128:32:128-a0:0:32-n32"
 target triple = "arm-apple-ios"
 
 declare <8 x i16> @llvm.arm.neon.vld1.v8i16.p0i8(i8*, i32) nounwind readonly
 declare void @llvm.arm.neon.vst1.p0i8.v8i16(i8*, <8 x i16>, i32) nounwind
 
 define <8 x i16> @test1(i8* %p, <8 x i16> %y) {

llvm/test/Analysis/BasicAA/intrinsics-arm.ll

 ; RUN: opt -aa-pipeline=basic-aa -passes=gvn -S < %s | FileCheck %s
-; REQUIRES: arm
+; REQUIRES: arm-registered-target
 
 target datalayout = "e-p:32:32:32-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:32-f32:32:32-f64:32:32-v64:32:64-v128:32:128-a0:0:32-n32"
 
 ; BasicAA should prove that these calls don't interfere, since we've
 ; specifically special cased exactly these two intrinsics in
 ; MemoryLocation::getForArgument.
 
 ; CHECK:      define <8 x i16> @test1(i8* %p, <8 x i16> %y) {

llvm/test/CodeGen/Generic/DbgValueAggregate.ll

 ; RUN: llc -O0 -global-isel < %s | FileCheck %s
-; REQUIRES: aarch64
+; REQUIRES: aarch64-registered-target
 target triple = "aarch64-unknown-linux-gnu"
 
 define void @MAIN_() #0 {
 L.entry:
   %0 = load <{ float, float }>, <{ float, float }>* undef, align 1
   ; CHECK: DEBUG_VALUE: localvar
   ; CHECK: DEBUG_VALUE: localvar
   call void @llvm.dbg.value(metadata <{ float, float }> %0, metadata !10, metadata !DIExpression()), !dbg !13

llvm/test/CodeGen/Hexagon/abi-padding-2.ll

 ; RUN: llc -march=hexagon -mcpu=hexagonv65 < %s | FileCheck %s
-; REQUIRES: hexagon
 
 ; C file was:
 ; struct S { char b; long long a; };
 ; void foo(int x, struct S arg1);
 ; void bar() {
 ;   struct S s;
 ;   s.b = 'a';
 ;   foo(42, s);

llvm/test/CodeGen/Hexagon/abi-padding.ll

 ; RUN: llc -march=hexagon -mcpu=hexagonv65 < %s | FileCheck %s
-; REQUIRES: hexagon
 
 ; C file was:
 ; struct S { int a[3];};
 ; void foo(int x, struct S arg1, struct S arg2);
 ; void bar() {
 ;  struct S s;
 ;  s.a[0] = 9;
 ;  foo(42, s, s);

llvm/test/CodeGen/PowerPC/read-set-flm.ll

 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc < %s -mtriple powerpc64le-unknown-linux | FileCheck %s
 ; RUN: llc < %s -mtriple powerpc64le-unknown-linux -debug-only=machine-scheduler \
 ; RUN:   2>&1 | FileCheck %s --check-prefix=LOG
-; REQUIRES: DEBUG
+; REQUIRES: asserts
 
 define double @in_nostrict(double %a, double %b, double %c, double %d) {
 ; CHECK-LABEL: in_nostrict:
 ; CHECK:       # %bb.0: # %entry
 ; CHECK-NEXT:    mffs 0
 ; CHECK-NEXT:    xsdivdp 1, 1, 2
 ; CHECK-NEXT:    xsadddp 1, 1, 3
 ; CHECK-NEXT:    xsadddp 0, 1, 0

llvm/test/MC/AsmParser/layout-interdependency.s

 # RUN: not llvm-mc --filetype=obj %s -o /dev/null 2>&1 | FileCheck %s
-# REQUIRES: defaut_triple
+# REQUIRES: default_triple
 
 fct_end:
 
 # CHECK: layout-interdependency.s:[[#@LINE+1]]:7: error: expected assembly-time absolute expression
 .fill (data_start - fct_end), 1, 42
 # CHECK: layout-interdependency.s:[[#@LINE+1]]:7: error: expected assembly-time absolute expression
 .fill (fct_end - data_start), 1, 42
 
 data_start:

llvm/test/tools/llvm-objcopy/ELF/update-section.test

-# REQUIRES: x86
+# REQUIRES: x86-registered-target
 
 # RUN: yaml2obj %s -o %t
 
 # RUN: echo -n 11112222 > %t.same
 # RUN: echo -n 00000000 > %t.zeros
 # RUN: echo -n 11 > %t.short
 # RUN: echo -n 11113333 > %t.updated
 # RUN: echo -n 111122223 > %t.larger

llvm/test/tools/llvm-readobj/COFF/call-graph-profile-err.s

-# REQUIRES: x86
+# REQUIRES: x86-registered-target
 # RUN: llvm-mc -filetype=obj -triple x86_64-pc-win32 %s -o %t
 # RUN: not llvm-readobj %t --cg-profile 2>&1 | FileCheck --check-prefix=ERR %s
 
 ## In order to use --cg-profile option, the section ".llvm.call-graph-profile" 
 ## should have two 4-byte fields representing the indexes of two symbols and
 ## one 8-byte fields representing the weight from first symbol to second 
 ## symbol.
 ## The section in this test case has 9 bytes of data, so it's malformed.

llvm/test/tools/llvm-readobj/COFF/call-graph-profile.s

-# REQUIRES: x86
+# REQUIRES: x86-registered-target
 # RUN: llvm-mc -filetype=obj -triple x86_64-pc-win32 %s -o %t
 # RUN: llvm-readobj %t --cg-profile | FileCheck %s
 
 # CHECK:      CGProfile [
 # CHECK-NEXT:   CGProfileEntry {
 # CHECK-NEXT:     From: a (10)
 # CHECK-NEXT:     To: b (11)
 # CHECK-NEXT:     Weight: 32