This is an archive of the discontinued LLVM Phabricator instance.

Differential D136499

[mlir][llvm] Fix replaceImmediateSubElements on LLVMPointerType
ClosedPublic

Authored by Mogball on Oct 21 2022, 2:10 PM.

Details

Reviewers
rriddle
jpienaar
ftynse
nicolasvasilache
dcaballe
Commits
rG877977bba966: [mlir][llvm] Fix replaceImmediateSubElements on LLVMPointerType
Summary

This method was assearting on opaque pointers because the element is
null.

Depends on D136498

Diff Detail

Event Timeline

Mogball created this revision.Oct 21 2022, 2:10 PM
Herald added a reviewer: ftynse. · View Herald TranscriptOct 21 2022, 2:10 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: zero9178, bzcheeseman, awarzynski and 19 others. · View Herald Transcript
Mogball requested review of this revision.Oct 21 2022, 2:10 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptOct 21 2022, 2:10 PM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle accepted this revision.Oct 21 2022, 2:12 PM
This revision is now accepted and ready to land.Oct 21 2022, 2:12 PM
Harbormaster completed remote builds in B193639: Diff 469761.Oct 21 2022, 2:48 PM
Mogball added a child revision: D136505: [mlir][llvm] More LLVMFixed/ScalableVectorType to TypeDef.Oct 21 2022, 2:56 PM
This revision was landed with ongoing or failed builds.Oct 21 2022, 3:13 PM
Closed by commit rG877977bba966: [mlir][llvm] Fix replaceImmediateSubElements on LLVMPointerType (authored by Mogball). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mogball added a commit: rG877977bba966: [mlir][llvm] Fix replaceImmediateSubElements on LLVMPointerType.

Revision Contents

PathSize
mlir/
lib/
Dialect/
LLVMIR/
IR/
2 lines

Diff 469791

mlir/lib/Dialect/LLVMIR/IR/LLVMTypes.cpp

Show First 20 Lines • Show All 444 Lines • ▼ Show 20 Lines
void LLVMPointerType::walkImmediateSubElements( void LLVMPointerType::walkImmediateSubElements(
function_ref<void(Attribute)> walkAttrsFn, function_ref<void(Attribute)> walkAttrsFn,
function_ref<void(Type)> walkTypesFn) const { function_ref<void(Type)> walkTypesFn) const {
walkTypesFn(getElementType()); walkTypesFn(getElementType());
} }
Type LLVMPointerType::replaceImmediateSubElements( Type LLVMPointerType::replaceImmediateSubElements(
ArrayRef<Attribute> replAttrs, ArrayRef<Type> replTypes) const { ArrayRef<Attribute> replAttrs, ArrayRef<Type> replTypes) const {
return get(replTypes.front(), getAddressSpace()); return get(getContext(), replTypes.front(), getAddressSpace());
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Struct type. // Struct type.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
bool LLVMStructType::isValidElementType(Type type) { bool LLVMStructType::isValidElementType(Type type) {
return !type.isa<LLVMVoidType, LLVMLabelType, LLVMMetadataType, return !type.isa<LLVMVoidType, LLVMLabelType, LLVMMetadataType,
▲ Show 20 Lines • Show All 631 Lines • Show Last 20 Lines