[lldb] Print newline between found types

[aeubanks]

Summary

Or else multiple entries end up overlapping on the same line.

[aeubanks]

(depends on https://reviews.llvm.org/D135826 for the test to be meaningful)

[DavidSpickett]

This LGTM thanks for the fix just one comment on the test before I can approve.

lldb/test/API/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py

17

Could you match the whole string here? A bit easier to see at a glance that way. Unless the output is not stable?

[aeubanks]

lldb/test/API/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py

17

it's

(lldb) im loo -t Foo
2 matches found in /home/aeubanks/repos/llvm-project/build/cmake/lldb-test-build.noindex/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.test_namespace_only_dwarf/a.out:
id = {0x0000004f}, name = "Foo", qualified = "a::Foo", byte-size = 1, decl = main.cpp:2, compiler_type = "struct Foo {
}"
id = {0x00000058}, name = "Foo", qualified = "b::Foo", byte-size = 1, decl = main.cpp:6, compiler_type = "struct Foo {
}"

I'd rather not depend so much on the exact output since that doesn't necessarily look stable

[DavidSpickett]

LGTM.

lldb/source/Commands/CommandObjectTarget.cpp

for (TypeSP type_sp : type_list.Types()) {
         strm.Printf("     typedef '%s': ",
                     typedef_type_sp->GetName().GetCString());
         typedefed_type_sp->GetFullCompilerType();
         typedefed_type_sp->GetDescription(&strm, eDescriptionLevelFull, true,
                                           target);
         typedef_type_sp = typedefed_type_sp;
         typedefed_type_sp = typedef_type_sp->GetTypedefType();
       }
-    }
       strm.EOL();
     }
+  }
   return type_list.GetSize();
 }
 
 static size_t LookupTypeHere(Target *target, CommandInterpreter &interpreter,
                              Stream &strm, Module &module,
                              const char *name_cstr, bool name_is_regex) {
   TypeList type_list;
   const uint32_t max_num_matches = UINT32_MAX;

lldb/test/API/lang/cpp/type_lookup_duplicate/Makefile

+CXX_SOURCES := main.cpp
+include Makefile.rules

lldb/test/API/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py

+"""
+Test that we properly print multiple types.
+"""
+
+import lldb
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import decorators
+
+class TestTypeLookupDuplicate(TestBase):
+
+    def test_namespace_only(self):
+        self.build()
+        lldbutil.run_to_source_breakpoint(self, "// Set breakpoint here", lldb.SBFileSpec("main.cpp"))
+
+        self.expect("image lookup -A -t Foo", DATA_TYPES_DISPLAYED_CORRECTLY, substrs=["2 matches found", "\nid =", "\nid ="])

lldb/test/API/lang/cpp/type_lookup_duplicate/main.cpp

+namespace a {
+struct Foo {};
+} // namespace a
+
+namespace b {
+struct Foo {};
+} // namespace b
+
+int main() {
+  a::Foo a;
+  b::Foo b;
+  return 0; // Set breakpoint here
+}