This is an archive of the discontinued LLVM Phabricator instance.

[mlir][index] Add `convert-index-to-llvm` pass
ClosedPublic

Authored by Mogball on Oct 11 2022, 10:11 AM.

Details

Summary

This patch adds a lowering pass to convert index dialect ops to LLVM.

Depends on D135694

Diff Detail

Event Timeline

Mogball created this revision.Oct 11 2022, 10:11 AM
Mogball requested review of this revision.Oct 11 2022, 10:11 AM
Mogball retitled this revision from [mlir][index] Add `create-index-to-llvm` pass to [mlir][index] Add `convert-index-to-llvm` pass.Oct 11 2022, 10:16 AM
rriddle accepted this revision.Oct 20 2022, 6:02 PM
rriddle added inline comments.
mlir/include/mlir/Conversion/Passes.td
443–446

Everything else uses a ConvertBlahToBlahPass naming scheme, we should keep the same here.

mlir/lib/Conversion/IndexToLLVM/IndexToLLVM.cpp
330

Can you drop all of these mlir::?

This revision is now accepted and ready to land.Oct 20 2022, 6:02 PM
Mogball updated this revision to Diff 469667.Oct 21 2022, 9:45 AM

review comments

This revision was landed with ongoing or failed builds.Oct 21 2022, 9:46 AM
This revision was automatically updated to reflect the committed changes.