This is an archive of the discontinued LLVM Phabricator instance.

[Bindings] Remove Go bindings
ClosedPublic

Authored by nikic on Oct 7 2022, 3:14 AM.

Details

Summary

Remove the unmaintained Go bindings per https://discourse.llvm.org/t/rfc-remove-the-go-bindings/65725.

The tinygo project provides maintained Go bindings at https://github.com/tinygo-org/go-llvm.

Diff Detail

Event Timeline

nikic created this revision.Oct 7 2022, 3:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 3:14 AM
nikic requested review of this revision.Oct 7 2022, 3:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2022, 3:14 AM
fhahn accepted this revision.Oct 7 2022, 1:29 PM
fhahn added a subscriber: fhahn.

As mentioned on Discourse, removing this LGTM!

This revision is now accepted and ready to land.Oct 7 2022, 1:29 PM
aykevl added a subscriber: aykevl.Oct 7 2022, 3:24 PM

Didn't look at the patch in depth but I agree with removing the Go bindings.

MaskRay accepted this revision.Oct 7 2022, 3:28 PM
MaskRay added a subscriber: MaskRay.

Looks good to me. The Go tests often caused failures when a new attribute was introduced and contributors usually don't know how to deal with them. They were also flaky in the past so was disabled as the resolution to https://github.com/llvm/llvm-project/issues/53017 .
I agree that out-of-tree bindings may be more useful and the maintainers can decide support more than one versions.

mgorny accepted this revision.Oct 9 2022, 12:26 AM
This revision was automatically updated to reflect the committed changes.
thakis added a subscriber: thakis.Oct 14 2022, 7:05 AM

Should LLVM_INCLUDE_GO_TESTS go too?

nikic added a comment.Oct 14 2022, 7:35 AM

Should LLVM_INCLUDE_GO_TESTS go too?

Done in https://github.com/llvm/llvm-project/commit/6ce87272487711c9f0ff408a037f5ca2e1ff5c5d, thanks for pointing that out!

llvm/test/lit.site.cfg.py.in