[LLDB] Remove the bool + RegisterInfo& version of GetRegisterInfo

[DavidSpickett]

Summary

All callers have been converted to the optional version.

Depends on D134540

lldb/include/lldb/Core/EmulateInstruction.h

public:
 
   virtual InstructionCondition GetInstructionCondition() {
     return UnconditionalCondition;
   }
 
   virtual bool TestEmulation(Stream *out_stream, ArchSpec &arch,
                              OptionValueDictionary *test_data) = 0;
 
-  bool GetRegisterInfo(lldb::RegisterKind reg_kind, uint32_t reg_num,
-                       RegisterInfo &reg_info);
-
   virtual llvm::Optional<RegisterInfo>
   GetRegisterInfo(lldb::RegisterKind reg_kind, uint32_t reg_num) = 0;
 
   // Optional overrides
   virtual bool SetInstruction(const Opcode &insn_opcode,
                               const Address &inst_addr, Target *target);
 
   virtual bool CreateFunctionEntryUnwind(UnwindPlan &unwind_plan);

lldb/source/Core/EmulateInstruction.cpp

if (reg_ctx && GetBestRegisterKindAndNumber(&reg_info, reg_kind, reg_num))
     return reg_ctx->ConvertRegisterKindToRegisterNumber(reg_kind, reg_num);
   return LLDB_INVALID_REGNUM;
 }
 
 bool EmulateInstruction::CreateFunctionEntryUnwind(UnwindPlan &unwind_plan) {
   unwind_plan.Clear();
   return false;
 }
-
-bool EmulateInstruction::GetRegisterInfo(lldb::RegisterKind reg_kind,
-                                         uint32_t reg_num,
-                                         RegisterInfo &reg_info) {
-  llvm::Optional<RegisterInfo> info = GetRegisterInfo(reg_kind, reg_num);
-  if (info)
-    reg_info = *info;
-  return info.has_value();
-}
 

lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.h

public:
 
   bool EvaluateInstruction(uint32_t evaluate_options) override;
 
   InstructionCondition GetInstructionCondition() override;
 
   bool TestEmulation(Stream *out_stream, ArchSpec &arch,
                      OptionValueDictionary *test_data) override;
 
-  using EmulateInstruction::GetRegisterInfo;
   llvm::Optional<RegisterInfo> GetRegisterInfo(lldb::RegisterKind reg_kind,
                                                uint32_t reg_num) override;
 
   bool CreateFunctionEntryUnwind(UnwindPlan &unwind_plan) override;
 
   uint32_t ArchVersion();
 
   bool ConditionPassed(const uint32_t opcode);

lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h

public:
   bool EvaluateInstruction(uint32_t evaluate_options) override;
 
   bool TestEmulation(lldb_private::Stream *out_stream,
                      lldb_private::ArchSpec &arch,
                      lldb_private::OptionValueDictionary *test_data) override {
     return false;
   }
 
-  using EmulateInstruction::GetRegisterInfo;
-
   llvm::Optional<lldb_private::RegisterInfo>
   GetRegisterInfo(lldb::RegisterKind reg_kind, uint32_t reg_num) override;
 
   bool
   CreateFunctionEntryUnwind(lldb_private::UnwindPlan &unwind_plan) override;
 
   enum AddrMode { AddrMode_OFF, AddrMode_PRE, AddrMode_POST };
 

lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h

bool SetInstruction(const lldb_private::Opcode &insn_opcode,
                       lldb_private::Target *target) override;
 
   bool TestEmulation(lldb_private::Stream *out_stream,
                      lldb_private::ArchSpec &arch,
                      lldb_private::OptionValueDictionary *test_data) override {
     return false;
   }
 
-  using EmulateInstruction::GetRegisterInfo;
-
   llvm::Optional<lldb_private::RegisterInfo>
   GetRegisterInfo(lldb::RegisterKind reg_kind, uint32_t reg_num) override;
 
   bool
   CreateFunctionEntryUnwind(lldb_private::UnwindPlan &unwind_plan) override;
 
 protected:
   typedef struct {

lldb/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h

public:
   bool EvaluateInstruction(uint32_t evaluate_options) override;
 
   bool TestEmulation(lldb_private::Stream *out_stream,
                      lldb_private::ArchSpec &arch,
                      lldb_private::OptionValueDictionary *test_data) override {
     return false;
   }
 
-  using EmulateInstruction::GetRegisterInfo;
-
   llvm::Optional<lldb_private::RegisterInfo>
   GetRegisterInfo(lldb::RegisterKind reg_kind, uint32_t reg_num) override;
 
   bool
   CreateFunctionEntryUnwind(lldb_private::UnwindPlan &unwind_plan) override;
 
 protected:
   typedef struct {

lldb/source/Plugins/Instruction/PPC64/EmulateInstructionPPC64.h

public:
 
   bool EvaluateInstruction(uint32_t evaluate_options) override;
 
   bool TestEmulation(Stream *out_stream, ArchSpec &arch,
                      OptionValueDictionary *test_data) override {
     return false;
   }
 
-  using EmulateInstruction::GetRegisterInfo;
-
   llvm::Optional<RegisterInfo> GetRegisterInfo(lldb::RegisterKind reg_kind,
                                                uint32_t reg_num) override;
 
   bool CreateFunctionEntryUnwind(UnwindPlan &unwind_plan) override;
 
 private:
   struct Opcode {
     uint32_t mask;

lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.h

bool SupportsEmulatingInstructionsOfType(InstructionType inst_type) override {
     return SupportsThisInstructionType(inst_type);
   }
 
   bool SetTargetTriple(const ArchSpec &arch) override;
   bool ReadInstruction() override;
   bool EvaluateInstruction(uint32_t options) override;
   bool TestEmulation(Stream *out_stream, ArchSpec &arch,
                      OptionValueDictionary *test_data) override;
-  using EmulateInstruction::GetRegisterInfo;
-
   llvm::Optional<RegisterInfo> GetRegisterInfo(lldb::RegisterKind reg_kind,
                                                uint32_t reg_num) override;
 
   lldb::addr_t ReadPC(bool &success);
   bool WritePC(lldb::addr_t pc);
 
   const InstrPattern *Decode(uint32_t inst);
   bool DecodeAndExecute(uint32_t inst, bool ignore_cond);