[lldb] Improve display of absolute symbol lookup

[alvinhochun]

Summary

When running target module lookup command, show the name of absolute
symbols. Also fix indentation issue after printing an absolute symbol.

[DavidSpickett]

lldb/source/Commands/CommandObjectTarget.cpp

1552

Could you use the stream's indent here instead of " Foo:"? You can pass a number of spaces to pad void IndentMore(unsigned amount = 2);.

lldb/test/Shell/SymbolFile/absolute-symbol.test

4

This is my ignorance talking, but isn't it redundant to print the name given that it's shown in the match line?

Perhaps that lookup isn't exact and mangling or partial matches can lead to multiple matches in which case printing the line is very useful.

[alvinhochun]

lldb/source/Commands/CommandObjectTarget.cpp

1552

I was just following the pre-existing code below and also in DumpAddress. I do have some issues with the output of the lookup command when there are multiple results -- there is no separation between different results which makes the output a bit hard to parse (and is why I made a semi-related patch in D134111), perhaps we can try to improve it more in a separate change.

lldb/test/Shell/SymbolFile/absolute-symbol.test

4

The lookup command can use regex filters which does usually return multiple matches.

[DavidSpickett]

LGTM

lldb/source/Commands/CommandObjectTarget.cpp

1552

Fair enough, I'd like it to be all stream.Indent but the result is the same so that's fine.

It mostly helps if you come back later and add another level within this, but that doesn't seem likely here.

[clayborg]

Thanks for fixing the issue!

lldb/source/Commands/CommandObjectTarget.cpp

for (uint32_t i = 0; i < num_matches; ++i) {
       if (symbol) {
         if (symbol->ValueIsAddress()) {
           DumpAddress(
               interpreter.GetExecutionContext().GetBestExecutionContextScope(),
               symbol->GetAddressRef(), verbose, all_ranges, strm);
           strm.EOL();
         } else {
           strm.IndentMore();
+          strm.Indent("    Name: ");
+          strm.PutCString(symbol->GetDisplayName().GetStringRef());
+          strm.EOL();
           strm.Indent("    Value: ");
           strm.Printf("0x%16.16" PRIx64 "\n", symbol->GetRawValue());
           if (symbol->GetByteSizeIsValid()) {
             strm.Indent("    Size: ");
             strm.Printf("0x%16.16" PRIx64 "\n", symbol->GetByteSize());
           }
+          strm.IndentLess();
         }
       }
     }
     strm.IndentLess();
   }
   return num_matches;
 }
 

lldb/test/Shell/SymbolFile/absolute-symbol.test

 # RUN: yaml2obj %s -o %t.o
 # RUN: %lldb -b -o 'target modules lookup -s absolute_symbol' %t.o | FileCheck %s
 # CHECK: 1 symbols match 'absolute_symbol'
+# CHECK:   Name: absolute_symbol
 # CHECK:   Value: 0x0000000012345678
 # Created from:
 #   .globl absolute_symbol
 #   absolute_symbol = 0x12345678
 --- !mach-o
 FileHeader:
   magic:           0xFEEDFACF
   cputype:         0x100000C