Page MenuHomePhabricator

[mlir] NFC: move mergeOffsetsSizesAndStrides into Affine/Utils
ClosedPublic

Authored by antiagainst on Sep 22 2022, 3:05 PM.

Details

Summary

So that these utility functions can also be used ViewLikeInterface
ops not in the memref dialect.

Diff Detail

Event Timeline

antiagainst created this revision.Sep 22 2022, 3:05 PM
antiagainst requested review of this revision.Sep 22 2022, 3:05 PM
mravishankar accepted this revision.Sep 22 2022, 3:07 PM
mravishankar added inline comments.
mlir/lib/Dialect/Affine/Utils/ViewLikeInterfaceUtils.cpp
60

Nit: you could just inline this into the header file...

This revision is now accepted and ready to land.Sep 22 2022, 3:07 PM
antiagainst marked an inline comment as done.Sep 23 2022, 10:29 AM
antiagainst added inline comments.
mlir/lib/Dialect/Affine/Utils/ViewLikeInterfaceUtils.cpp
60

I typically inline for oneliners or similar. I'll leave this as-is given this is quite a few lines.