This is an archive of the discontinued LLVM Phabricator instance.

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines	Builder &setLayout(MemRefLayoutAttrInterface newLayout) {
return *this;		return *this;
}		}

Builder &setMemorySpace(Attribute newMemorySpace) {		Builder &setMemorySpace(Attribute newMemorySpace) {
memorySpace = newMemorySpace;		memorySpace = newMemorySpace;
return *this;		return *this;
}		}

// [deprecated] `setMemorySpace(Attribute)` should be used instead.
Builder &setMemorySpace(unsigned newMemorySpace);
rriddleUnsubmitted Not Done Reply Inline Actions You also have to delete the definition (in BuiltinTypes.cpp) rriddle: You also have to delete the definition (in BuiltinTypes.cpp)
tpoppAuthorUnsubmitted Done Reply Inline Actions :facepalm: Thanks for catching that! tpopp: :facepalm: Thanks for catching that!

operator MemRefType() {		operator MemRefType() {
return MemRefType::get(shape, elementType, layout, memorySpace);		return MemRefType::get(shape, elementType, layout, memorySpace);
}		}

private:		private:
ArrayRef<int64_t> shape;		ArrayRef<int64_t> shape;
Type elementType;		Type elementType;
MemRefLayoutAttrInterface layout;		MemRefLayoutAttrInterface layout;
▲ Show 20 Lines • Show All 304 Lines • Show Last 20 Lines

mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines	void runOnOperation() override {
// space 5 for private memory attributions, but NVVM represents private		// space 5 for private memory attributions, but NVVM represents private
// memory allocations as local `alloca`s in the default address space. This		// memory allocations as local `alloca`s in the default address space. This
// converter drops the private memory space to support the use case above.		// converter drops the private memory space to support the use case above.
LLVMTypeConverter converter(m.getContext(), options);		LLVMTypeConverter converter(m.getContext(), options);
converter.addConversion([&](MemRefType type) -> Optional<Type> {		converter.addConversion([&](MemRefType type) -> Optional<Type> {
if (type.getMemorySpaceAsInt() !=		if (type.getMemorySpaceAsInt() !=
gpu::GPUDialect::getPrivateAddressSpace())		gpu::GPUDialect::getPrivateAddressSpace())
return llvm::None;		return llvm::None;
return converter.convertType(MemRefType::Builder(type).setMemorySpace(0));		return converter.convertType(MemRefType::Builder(type).setMemorySpace(
		IntegerAttr::get(IntegerType::get(m.getContext(), 64), 0)));
});		});
// Lowering for MMAMatrixType.		// Lowering for MMAMatrixType.
converter.addConversion([&](gpu::MMAMatrixType type) -> Type {		converter.addConversion([&](gpu::MMAMatrixType type) -> Type {
return convertMMAToLLVMType(type);		return convertMMAToLLVMType(type);
});		});
RewritePatternSet patterns(m.getContext());		RewritePatternSet patterns(m.getContext());
RewritePatternSet llvmPatterns(m.getContext());		RewritePatternSet llvmPatterns(m.getContext());

▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines

mlir/lib/IR/BuiltinTypes.cpp

Show First 20 Lines • Show All 526 Lines • ▼ Show 20 Lines	if (!memorySpace)
return 0;		return 0;

assert(memorySpace.isa<IntegerAttr>() &&		assert(memorySpace.isa<IntegerAttr>() &&
"Using `getMemorySpaceInteger` with non-Integer attribute");		"Using `getMemorySpaceInteger` with non-Integer attribute");

return static_cast<unsigned>(memorySpace.cast<IntegerAttr>().getInt());		return static_cast<unsigned>(memorySpace.cast<IntegerAttr>().getInt());
}		}

MemRefType::Builder &
MemRefType::Builder::setMemorySpace(unsigned newMemorySpace) {
memorySpace =
wrapIntegerMemorySpace(newMemorySpace, elementType.getContext());
return *this;
}

unsigned MemRefType::getMemorySpaceAsInt() const {		unsigned MemRefType::getMemorySpaceAsInt() const {
return detail::getMemorySpaceAsInt(getMemorySpace());		return detail::getMemorySpaceAsInt(getMemorySpace());
}		}

MemRefType MemRefType::get(ArrayRef<int64_t> shape, Type elementType,		MemRefType MemRefType::get(ArrayRef<int64_t> shape, Type elementType,
MemRefLayoutAttrInterface layout,		MemRefLayoutAttrInterface layout,
Attribute memorySpace) {		Attribute memorySpace) {
// Use default layout for empty attribute.		// Use default layout for empty attribute.
▲ Show 20 Lines • Show All 538 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Delete MemRefType::setMemorySpace(unsigned)ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 456299

mlir/include/mlir/IR/BuiltinTypes.h

mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp

mlir/lib/IR/BuiltinTypes.cpp

[mlir] Delete MemRefType::setMemorySpace(unsigned)
ClosedPublic