[ModuloSchedule] Add interface call to accept/reject SMS schedules
ClosedPublic
Actions

Authored by dpenry on Aug 18 2022, 1:10 PM.

Details

Reviewers

dmgreen
thopre
bcahoon
jsji
jmolloy

Commits

rGced705c4407f: [ModuloSchedule] Add interface call to accept/reject SMS schedules

Summary

This interface allows a target to reject a proposed
SMS schedule. For Hexagon/PowerPC, all schedules
are accepted, leaving behavior unchanged. For ARM,
schedules which exceed register pressure limits are
rejected.

Also, two RegisterPressureTracker methods now need to be public so
that register pressure can be computed by more callers.

Reapplication of D128941/(reversion:D132037) with small fix.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	3,370 ms	x64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::fd_location_closed.cpp Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=thread -Wall -m64 -msse4.2 -gline-tables-only -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -std=c++11 -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -O1 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/fd_location_closed.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/fd_location_closed.cpp.tmp && /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/deflake.bash 10 /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/fd_location_closed.cpp.tmp \|& FileCheck /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/fd_location_closed.cpp

Event Timeline

dpenry created this revision.Aug 18 2022, 1:10 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2022, 1:10 PM

Herald added subscribers: steven.zhang, mgrang, hiraditya and 2 others. · View Herald Transcript

dpenry requested review of this revision.Aug 18 2022, 1:10 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2022, 1:10 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

dpenry edited the summary of this revision. (Show Details)Aug 18 2022, 1:12 PM

Harbormaster completed remote builds in B182075: Diff 453762.Aug 18 2022, 3:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2022, 12:11 PM

This revision was landed with ongoing or failed builds.

Closed by commit rGced705c4407f: [ModuloSchedule] Add interface call to accept/reject SMS schedules (authored by dpenry). · Explain Why

This revision was automatically updated to reflect the committed changes.

dpenry added a commit: rGced705c4407f: [ModuloSchedule] Add interface call to accept/reject SMS schedules.

kuaizilh added a subscriber: kuaizilh.Oct 28 2022, 1:01 AM

kuaizilh added inline comments.

llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
6959	why this should be setted by Stg - Stg2? is it related to the previous code?"CrossIterationNeeds.insert(std::make_pair(Reg.id(), IterNeed())).first->second \|= ((1 << (OStg - Stg)) - 1);"