This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add {{$}} to some CHECK lines in MC tests.
ClosedPublic

Authored by craig.topper on Aug 8 2022, 1:40 PM.

Details

Summary

This adds {{$}} to most of the CHECK lines for errors about what
extension an instruction requires. This ensures we check all the
extensions when there is a list.

Some vector tests have been omitted because they need to be fixed.
I believe they were all floating point tests.

Diff Detail

Event Timeline

craig.topper created this revision.Aug 8 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 1:40 PM
craig.topper requested review of this revision.Aug 8 2022, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 1:40 PM
MaskRay accepted this revision.Aug 8 2022, 2:15 PM

An alternative is to use --match-full-lines, but every error: line needs to prepend a regex. Perhaps {{$}} is cleaner.

This revision is now accepted and ready to land.Aug 8 2022, 2:15 PM
This revision was landed with ongoing or failed builds.Aug 8 2022, 2:38 PM
This revision was automatically updated to reflect the committed changes.