Split result support in this D126847, but lack split operand support.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
The change LGTM but I'd like to know why only VP INT_TO_FP nodes are handled in this code.
Just FYI I also opened D130967. I thought it better we keep these VP ISD nodes named in line with the non-VP ones.
llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp | ||
---|---|---|
2744 | That's interesting - how come ISD::SINT_TO_FP and ISD::STRICT_SINT_TO_FP aren't handled here? Are they handled elsewhere or is there a bug somewhere? |
llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp | ||
---|---|---|
2744 | ISD::SINT_TO_FP and ISD::STRICT_SINT_TO_FP are handled in line 2724. Maybe I need to add VP_SITOFP and VP_UITOFP in line 2724. |
LGTM
llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp | ||
---|---|---|
2744 | Ah, nice. I didn't notice that. Yeah I think keeping them together is best. Thanks |
That's interesting - how come ISD::SINT_TO_FP and ISD::STRICT_SINT_TO_FP aren't handled here? Are they handled elsewhere or is there a bug somewhere?