This is an archive of the discontinued LLVM Phabricator instance.

Differential D130444

[DAG] Use recursivelyDeleteUnusedNodes in ReplaceLoadWithPromotedLoad
ClosedPublic

Authored by deadalnix on Jul 24 2022, 6:01 PM.

Details

Reviewers
RKSimon
craig.topper
efriedma
spatel
Commits
rG7920805b27fd: [DAG] Use recursivelyDeleteUnusedNodes in ReplaceLoadWithPromotedLoad
Summary

It simplifies the code overall and removes the need for manual bookkeeping.

Diff Detail

Event Timeline

deadalnix created this revision.Jul 24 2022, 6:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2022, 6:01 PM
Herald added subscribers: StephenFan, ecnelises, hiraditya. · View Herald Transcript
deadalnix requested review of this revision.Jul 24 2022, 6:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2022, 6:01 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
deadalnix edited the summary of this revision. (Show Details)Jul 24 2022, 6:11 PM
Harbormaster completed remote builds in B177252: Diff 447161.Jul 24 2022, 6:41 PM
RKSimon accepted this revision.Jul 28 2022, 2:37 AM

LGTM

This revision is now accepted and ready to land.Jul 28 2022, 2:37 AM
This revision was landed with ongoing or failed builds.Jul 28 2022, 5:32 AM
Closed by commit rG7920805b27fd: [DAG] Use recursivelyDeleteUnusedNodes in ReplaceLoadWithPromotedLoad (authored by Amaury Séchet <deadalnix@gmail.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Amaury Séchet <deadalnix@gmail.com> added a commit: rG7920805b27fd: [DAG] Use recursivelyDeleteUnusedNodes in ReplaceLoadWithPromotedLoad.

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
5 lines

Diff 448312

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,257 Lines • ▼ Show 20 Lines
void DAGCombiner::ReplaceLoadWithPromotedLoad(SDNode *Load, SDNode *ExtLoad) { void DAGCombiner::ReplaceLoadWithPromotedLoad(SDNode *Load, SDNode *ExtLoad) {
SDLoc DL(Load); SDLoc DL(Load);
EVT VT = Load->getValueType(0); EVT VT = Load->getValueType(0);
SDValue Trunc = DAG.getNode(ISD::TRUNCATE, DL, VT, SDValue(ExtLoad, 0)); SDValue Trunc = DAG.getNode(ISD::TRUNCATE, DL, VT, SDValue(ExtLoad, 0));
LLVM_DEBUG(dbgs() << "\nReplacing.9 "; Load->dump(&DAG); dbgs() << "\nWith: "; LLVM_DEBUG(dbgs() << "\nReplacing.9 "; Load->dump(&DAG); dbgs() << "\nWith: ";
Trunc.dump(&DAG); dbgs() << '\n'); Trunc.dump(&DAG); dbgs() << '\n');
WorklistRemover DeadNodes(*this);
DAG.ReplaceAllUsesOfValueWith(SDValue(Load, 0), Trunc); DAG.ReplaceAllUsesOfValueWith(SDValue(Load, 0), Trunc);
DAG.ReplaceAllUsesOfValueWith(SDValue(Load, 1), SDValue(ExtLoad, 1)); DAG.ReplaceAllUsesOfValueWith(SDValue(Load, 1), SDValue(ExtLoad, 1));
deleteAndRecombine(Load);
AddToWorklist(Trunc.getNode()); AddToWorklist(Trunc.getNode());
recursivelyDeleteUnusedNodes(Load);
} }
SDValue DAGCombiner::PromoteOperand(SDValue Op, EVT PVT, bool &Replace) { SDValue DAGCombiner::PromoteOperand(SDValue Op, EVT PVT, bool &Replace) {
Replace = false; Replace = false;
SDLoc DL(Op); SDLoc DL(Op);
if (ISD::isUNINDEXEDLoad(Op.getNode())) { if (ISD::isUNINDEXEDLoad(Op.getNode())) {
LoadSDNode *LD = cast<LoadSDNode>(Op); LoadSDNode *LD = cast<LoadSDNode>(Op);
EVT MemVT = LD->getMemoryVT(); EVT MemVT = LD->getMemoryVT();
▲ Show 20 Lines • Show All 23,704 Lines • Show Last 20 Lines