This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Math] Add constant folder for ExpOp.
ClosedPublic

Authored by jacquesguan on Jul 21 2022, 5:47 PM.

Details

Summary

This patch adds constant folder for ExpOp which only supports single and double precision floating-point.

Diff Detail

Event Timeline

jacquesguan created this revision.Jul 21 2022, 5:47 PM
jacquesguan requested review of this revision.Jul 21 2022, 5:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 5:47 PM
Mogball accepted this revision.Jul 22 2022, 12:19 PM

Can you fix the failing test?

This revision is now accepted and ready to land.Jul 22 2022, 12:19 PM
bondhugula added inline comments.Jul 24 2022, 8:01 PM
mlir/test/Dialect/Math/canonicalize.mlir
234

These two can be CHECK-NEXT?

Nit: Instead of indenting "//", recommend indenting just "return".

Address comment.

Can you fix the failing test?

Done.

mlir/test/Dialect/Math/canonicalize.mlir
234

Done, thanks.

This revision was automatically updated to reflect the committed changes.