[clang-tidy] Avoid extra parentheses around MemberExpr

[SimplyDanny]

Summary

Fixes https://github.com/llvm/llvm-project/issues/55025.

[SimplyDanny]

@alexfh, @aaron.ballman, @njames93, @LegalizeAdulthood

Could anyone give some feedback, please?

[aaron.ballman]

LGTM!

clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp

else if (ACE)
     CE = ACE;
 
   SourceRange SrcRange = CE->getSourceRange();
 
   std::string ReplacementText{
       Lexer::getSourceText(CharSourceRange::getTokenRange(SrcRange),
                            *Result.SourceManager, getLangOpts())};
 
-  if (!isa<DeclRefExpr, ArraySubscriptExpr, CXXOperatorCallExpr, CallExpr>(CE))
+  if (!isa<DeclRefExpr, ArraySubscriptExpr, CXXOperatorCallExpr, CallExpr,
+           MemberExpr>(CE))
     ReplacementText = "(" + ReplacementText + ")";
 
   if (CE->getType()->isPointerType())
     ReplacementText += "->data()";
   else
     ReplacementText += ".data()";
 
   FixItHint Hint =

clang-tools-extra/docs/ReleaseNotes.rst

 - Fixed a crash in :doc:`performance-unnecessary-value-param
   <clang-tidy/checks/performance/unnecessary-value-param>` when the specialization
   template has an unnecessary value parameter. Removed the fix for a template.
 
 - Fixed a crash in :doc:`readability-const-return-type
   <clang-tidy/checks/readability/const-return-type>` when a pure virtual function
   overrided has a const return type. Removed the fix for a virtual function.
 
+- Skipped addition of extra parentheses around member accesses (``a.b``) in fix-it for
+  :doc:`readability-container-data-pointer <clang-tidy/checks/readability/container-data-pointer>`.
+
 - Fixed incorrect suggestions for :doc:`readability-container-size-empty
   <clang-tidy/checks/readability/container-size-empty>` when smart pointers are involved.
 
 - Fixed a false positive in :doc:`readability-non-const-parameter
   <clang-tidy/checks/readability/non-const-parameter>` when the parameter is
   referenced by an lvalue.
 
 - Expanded :doc:`readability-simplify-boolean-expr

clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp

int *p(std::vector<int> &v1, std::vector<int> &v2) {
   // CHECK-FIXES: {{^  }}return select(*&v1, v2).data();{{$}}
 }
 
 int *q(std::vector<int> ***v) {
   return &(***v)[0];
   // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
   // CHECK-FIXES: {{^  }}return (**v)->data();{{$}}
 }
+
+struct VectorHolder {
+  std::vector<int> v;
+};
+
+int *r() {
+  VectorHolder holder;
+  return &holder.v[0];
+  // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
+  // CHECK-FIXES: {{^  }}return holder.v.data();{{$}}
+}