Page MenuHomePhabricator
Differential D129070

[clang-tidy] Fixed an issue in readability-identifier-naming not using options specified.
ClosedPublic
Actions

Authored by njames93 on Jul 4 2022, 3:29 AM.

Details

Reviewers
aaron.ballman
alexfh
LegalizeAdulthood
carlosgalvezp
Commits
rG3ed40ac90ce8: [clang-tidy] Fixed an issue in readability-identifier-naming not using options…
Summary

Fixed an issue where specifying empty strings for prefix or suffix would be ignored preventing using those to override a different style.

Fixes https://github.com/llvm/llvm-project/issues/56358.

Diff Detail

Event Timeline

njames93 created this revision.Jul 4 2022, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 3:29 AM
Herald added subscribers: carlosgalvezp, xazax.hun. · View Herald Transcript
njames93 requested review of this revision.Jul 4 2022, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 3:29 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B173533: Diff 442058.Jul 4 2022, 3:56 AM
njames93 updated this revision to Diff 442101.Jul 4 2022, 8:06 AM

Small tweak.

Harbormaster completed remote builds in B173565: Diff 442101.Jul 4 2022, 8:28 AM
PiotrZSL updated this revision to Diff 504434.Sun, Mar 12, 7:06 AM
PiotrZSL added a subscriber: PiotrZSL.

Rebase on top of main + Change llvm::Optional into std::optional

PiotrZSL added a reviewer: carlosgalvezp.Sun, Mar 12, 7:09 AM
Harbormaster completed remote builds in B218874: Diff 504434.Sun, Mar 12, 7:25 AM
carlosgalvezp accepted this revision.Sat, Mar 18, 3:02 AM
This revision is now accepted and ready to land.Sat, Mar 18, 3:02 AM
Closed by commit rG3ed40ac90ce8: [clang-tidy] Fixed an issue in readability-identifier-naming not using options… (authored by njames93, committed by PiotrZSL). · Explain WhySat, Mar 18, 8:59 AM
This revision was automatically updated to reflect the committed changes.
PiotrZSL added a commit: rG3ed40ac90ce8: [clang-tidy] Fixed an issue in readability-identifier-naming not using options….

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clang-tidy/
readability/
4 lines
20 lines
docs/
5 lines
test/
clang-tidy/
checkers/
readability/
12 lines

Diff 506298

View Options

clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h

Loading...
View Options

clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

Loading...
View Options

clang-tools-extra/docs/ReleaseNotes.rst

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-empty-options.cpp

Loading...