This is an archive of the discontinued LLVM Phabricator instance.

Differential D128976

[flang] File omp_lib.f90 is not a standard intrinsic module
ClosedPublic

Authored by clementval on Jul 1 2022, 2:37 AM.

Details

Reviewers
jeanPerier
PeteSteinfeld
schweitz
klausler
sscalpone
vdonaldson
jdoerfert
Commits
rG8c44bef11033: [flang] File omp_lib.f90 is not a standard intrinsic module
Summary

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: V Donaldson <vdonaldson@nvidia.com>

Diff Detail

Event Timeline

clementval created this revision.Jul 1 2022, 2:37 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 1 2022, 2:37 AM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
clementval requested review of this revision.Jul 1 2022, 2:37 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJul 1 2022, 2:37 AM
Herald added subscribers: sstefan1, jdoerfert. · View Herald Transcript
clementval edited the summary of this revision. (Show Details)Jul 1 2022, 2:38 AM
jeanPerier accepted this revision.Jul 1 2022, 2:39 AM

LGTM

This revision is now accepted and ready to land.Jul 1 2022, 2:39 AM
Harbormaster completed remote builds in B173207: Diff 441649.Jul 1 2022, 3:03 AM
Closed by commit rG8c44bef11033: [flang] File omp_lib.f90 is not a standard intrinsic module (authored by clementval). · Explain WhyJul 1 2022, 3:05 AM
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG8c44bef11033: [flang] File omp_lib.f90 is not a standard intrinsic module.

Revision Contents

PathSize
flang/
lib/
Lower/
3 lines

Diff 441649

flang/lib/Lower/ConvertExpr.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 571 Lines • ▼ Show 20 Lines
static bool static bool
isIntrinsicModuleProcRef(const Fortran::evaluate::ProcedureRef &procRef) { isIntrinsicModuleProcRef(const Fortran::evaluate::ProcedureRef &procRef) {
const Fortran::semantics::Symbol *symbol = procRef.proc().GetSymbol(); const Fortran::semantics::Symbol *symbol = procRef.proc().GetSymbol();
if (!symbol) if (!symbol)
return false; return false;
const Fortran::semantics::Symbol *module = const Fortran::semantics::Symbol *module =
symbol->GetUltimate().owner().GetSymbol(); symbol->GetUltimate().owner().GetSymbol();
return module && module->attrs().test(Fortran::semantics::Attr::INTRINSIC); return module && module->attrs().test(Fortran::semantics::Attr::INTRINSIC) &&
module->name().ToString().find("omp_lib") == std::string::npos;
} }
namespace { namespace {
/// Lowering of Fortran::evaluate::Expr<T> expressions /// Lowering of Fortran::evaluate::Expr<T> expressions
class ScalarExprLowering { class ScalarExprLowering {
public: public:
using ExtValue = fir::ExtendedValue; using ExtValue = fir::ExtendedValue;
▲ Show 20 Lines • Show All 7,050 Lines • Show Last 20 Lines