Page MenuHomePhabricator
People vdonaldson

vdonaldson (vdonaldson)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2021, 1:18 PM (91 w, 3 d)

Recent Activity
View All

Wed, May 31

vdonaldson accepted D151700: [Flang][PFT] Skip continue insertion for OpenMP Loops.

@kiranchandramohan Thanks for investigating fix options.

Wed, May 31, 9:47 AM · Restricted Project, Restricted Project

Tue, May 30

vdonaldson accepted D151738: [flang] Detect output field width overflow for Inf/NaN.
Tue, May 30, 11:31 AM · Restricted Project, Restricted Project
vdonaldson accepted D151739: [flang] Fix interpretations of x87 80-bit Inf/NaN.

Looks good to me

Tue, May 30, 11:29 AM · Restricted Project, Restricted Project
vdonaldson added inline comments to D151700: [Flang][PFT] Skip continue insertion for OpenMP Loops.
Tue, May 30, 11:20 AM · Restricted Project, Restricted Project
vdonaldson added a reviewer for D151700: [Flang][PFT] Skip continue insertion for OpenMP Loops: clementval.
Tue, May 30, 11:18 AM · Restricted Project, Restricted Project
vdonaldson accepted D151712: [flang] [NFC] Remove an unneeded include..
Tue, May 30, 9:33 AM · Restricted Project, Restricted Project

Fri, May 26

vdonaldson closed D151471: [flang] Retain the sign of the argument for the result of fraction(0).

https://reviews.llvm.org/D151471

Fri, May 26, 9:27 AM · Restricted Project, Restricted Project
vdonaldson committed rG6c9c69bd7616: [flang] Retain the sign of the argument for the result of fraction(0) (authored by vdonaldson).
[flang] Retain the sign of the argument for the result of fraction(0)
Fri, May 26, 9:25 AM · Restricted Project, Restricted Project

Thu, May 25

vdonaldson added a reviewer for D151471: [flang] Retain the sign of the argument for the result of fraction(0): klausler.
Thu, May 25, 10:19 AM · Restricted Project, Restricted Project
vdonaldson requested review of D151471: [flang] Retain the sign of the argument for the result of fraction(0).
Thu, May 25, 10:19 AM · Restricted Project, Restricted Project

Wed, May 24

vdonaldson added a comment to D151118: [Flang] Fix nested block constructs for SELECT CASE.
In D151118#4368244, @cseo wrote:

@vdonaldson btw, I don't have commit access. So, whenever you think this change is good to go, feel free to push it.

Wed, May 24, 9:06 AM · Restricted Project, Restricted Project

Tue, May 23

vdonaldson accepted D151272: [flang] Fix SPACING() of very small values.
Tue, May 23, 5:23 PM · Restricted Project, Restricted Project
vdonaldson accepted D151118: [Flang] Fix nested block constructs for SELECT CASE.

Looks good to me, thanks for addressing this!

Tue, May 23, 11:14 AM · Restricted Project, Restricted Project

Mon, May 22

vdonaldson accepted D151134: [flang][runtime] Complete partial output records when positioning/closing after non-advancing output.
Mon, May 22, 4:34 PM · Restricted Project, Restricted Project
vdonaldson added a comment to D151118: [Flang] Fix nested block constructs for SELECT CASE.

Thanks @cseo for looking at this bug.

Mon, May 22, 3:22 PM · Restricted Project, Restricted Project

Wed, May 17

vdonaldson closed D150719: [flang] Non-type-bound defined IO lowering.

https://reviews.llvm.org/D150719

Wed, May 17, 10:15 AM · Restricted Project, Restricted Project
vdonaldson committed rG6f7a3b078191: [flang] Non-type-bound defined IO lowering (authored by vdonaldson).
[flang] Non-type-bound defined IO lowering
Wed, May 17, 9:23 AM · Restricted Project, Restricted Project

Tue, May 16

vdonaldson accepted D150710: [flang] Finer control over warnings.
Tue, May 16, 1:50 PM · Restricted Project, Restricted Project
vdonaldson added reviewers for D150719: [flang] Non-type-bound defined IO lowering: klausler, jeanPerier, clementval.
Tue, May 16, 1:47 PM · Restricted Project, Restricted Project
vdonaldson requested review of D150719: [flang] Non-type-bound defined IO lowering.
Tue, May 16, 1:42 PM · Restricted Project, Restricted Project

Thu, May 11

vdonaldson accepted D150406: [flang] Don't mistakenly tokenize a Hollerith literal from "DO 100 H=..." (bug #58732).
Thu, May 11, 4:19 PM · Restricted Project, Restricted Project

Fri, May 5

vdonaldson accepted D149988: [flang] Semantics for ISO_C_BINDING's C_LOC().
Fri, May 5, 5:08 PM · Restricted Project, Restricted Project

May 2 2023

vdonaldson accepted D149639: Revert part of D149033 b/c original code is correct.

Thanks for the fix!

May 2 2023, 10:41 AM · Restricted Project, Restricted Project

May 1 2023

vdonaldson added a comment to D149033: [NFC]Fix 2 logic dead code.

As noted, it looks like this change is causing compilation of an edge case to hang.

May 1 2023, 5:32 PM · Restricted Project, Restricted Project

Apr 18 2023

vdonaldson accepted D148643: [flang] Semantics for !DIR$ IGNORE_TKR.
Apr 18 2023, 11:04 AM · Restricted Project, Restricted Project

Apr 17 2023

vdonaldson closed D148264: [flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors.

https://reviews.llvm.org/D148264

Apr 17 2023, 10:04 AM · Restricted Project, Restricted Project
vdonaldson committed rGbddd7a643610: [flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors (authored by vdonaldson).
[flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors
Apr 17 2023, 9:12 AM · Restricted Project, Restricted Project

Apr 14 2023

vdonaldson closed D148365: [flang] Remove `ignoring all compiler directives` warning.

https://reviews.llvm.org/D148365

Apr 14 2023, 5:15 PM · Restricted Project, Restricted Project
vdonaldson committed rGaf7819785711: [flang] Remove `ignoring all compiler directives` warning (authored by vdonaldson).
[flang] Remove `ignoring all compiler directives` warning
Apr 14 2023, 4:09 PM · Restricted Project, Restricted Project
vdonaldson added a comment to D148365: [flang] Remove `ignoring all compiler directives` warning.
In D148365#4269456, @PeteSteinfeld wrote:

I wonder if we should put out a TODO message when directives get passed to lowering. Otherwise, all builds and tests correctly and looks good.

Apr 14 2023, 1:24 PM · Restricted Project, Restricted Project
vdonaldson added reviewers for D148365: [flang] Remove `ignoring all compiler directives` warning: PeteSteinfeld, jeanPerier, clementval.
Apr 14 2023, 12:21 PM · Restricted Project, Restricted Project
vdonaldson requested review of D148365: [flang] Remove `ignoring all compiler directives` warning.
Apr 14 2023, 12:19 PM · Restricted Project, Restricted Project
vdonaldson added a comment to D148264: [flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors.

I've moved function getTypeCode to file Optimizer/Dialect/FIRType.cpp.

Apr 14 2023, 12:02 PM · Restricted Project, Restricted Project
vdonaldson updated the diff for D148264: [flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors.
Apr 14 2023, 12:00 PM · Restricted Project, Restricted Project

Apr 13 2023

vdonaldson added a reverting change for rG17a4fcecf40e: [flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors: rG4add0e3db94a: Revert "[flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors".
Apr 13 2023, 6:35 PM · Restricted Project, Restricted Project
vdonaldson committed rG4add0e3db94a: Revert "[flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors" (authored by vdonaldson).
Revert "[flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors"
Apr 13 2023, 6:35 PM · Restricted Project, Restricted Project
vdonaldson committed rG17a4fcecf40e: [flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors (authored by vdonaldson).
[flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors
Apr 13 2023, 6:03 PM · Restricted Project, Restricted Project
vdonaldson accepted D148257: [flang] Rework handling of non-type-bound user-defined I/O.
Apr 13 2023, 1:27 PM · Restricted Project, Restricted Project
vdonaldson added reviewers for D148264: [flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors: PeteSteinfeld, clementval, jeanPerier, vzakhari.
Apr 13 2023, 12:55 PM · Restricted Project, Restricted Project
vdonaldson requested review of D148264: [flang] REAL(KIND=3) and COMPLEX(KIND=3) descriptors.
Apr 13 2023, 12:53 PM · Restricted Project, Restricted Project

Apr 12 2023

vdonaldson accepted D148157: [flang][runtime] Reset the left tab limit when flushing output.
Apr 12 2023, 4:17 PM · Restricted Project, Restricted Project

Apr 5 2023

vdonaldson closed D147650: [flang] Nonconformant assigned gotos.

https://reviews.llvm.org/D147650

Apr 5 2023, 2:56 PM · Restricted Project, Restricted Project
vdonaldson committed rGfd922e6ab0b5: [flang] Nonconformant assigned gotos (authored by vdonaldson).
[flang] Nonconformant assigned gotos
Apr 5 2023, 2:54 PM · Restricted Project, Restricted Project
vdonaldson added reviewers for D147650: [flang] Nonconformant assigned gotos: PeteSteinfeld, jeanPerier, clementval.
Apr 5 2023, 11:53 AM · Restricted Project, Restricted Project
vdonaldson requested review of D147650: [flang] Nonconformant assigned gotos.
Apr 5 2023, 11:51 AM · Restricted Project, Restricted Project

Apr 3 2023

vdonaldson accepted D147391: [flang] Don't allow CALL RANDOM_NUMBER(assumed-size-array).
Apr 3 2023, 8:55 AM · Restricted Project, Restricted Project

Apr 1 2023

vdonaldson accepted D147387: [flang][docs] Document module name extension.
Apr 1 2023, 2:22 PM · Restricted Project, Restricted Project
vdonaldson accepted D147386: [flang] Fix checks for USE-associated UDDTIO & their character argument kinds.
Apr 1 2023, 2:16 PM · Restricted Project, Restricted Project

Mar 31 2023

vdonaldson closed D147338: [flang] IO condition specfier control flow.

https://reviews.llvm.org/D147338

Mar 31 2023, 4:42 PM · Restricted Project, Restricted Project
vdonaldson committed rG5e521580e60a: [flang] IO condition specfier control flow (authored by vdonaldson).
[flang] IO condition specfier control flow
Mar 31 2023, 4:40 PM · Restricted Project, Restricted Project
vdonaldson added reviewers for D147338: [flang] IO condition specfier control flow: jeanPerier, PeteSteinfeld, clementval.
Mar 31 2023, 9:47 AM · Restricted Project, Restricted Project
vdonaldson requested review of D147338: [flang] IO condition specfier control flow.
Mar 31 2023, 9:46 AM · Restricted Project, Restricted Project

Mar 28 2023

vdonaldson accepted D147071: [flang] Fine-tune NAN formatted input editing.

Thanks for the fix!

Mar 28 2023, 12:36 PM · Restricted Project, Restricted Project

Mar 21 2023

vdonaldson accepted D146588: [flang] Fix CONTIGUOUS attribute checking.
Mar 21 2023, 7:59 PM · Restricted Project, Restricted Project
vdonaldson accepted D146585: [flang] Catch impure defined assignments in DO CONCURRENT.
Mar 21 2023, 7:58 PM · Restricted Project, Restricted Project
vdonaldson accepted D146584: [flang] Detect image control statements in non-construct IF statements.
Mar 21 2023, 7:57 PM · Restricted Project, Restricted Project
vdonaldson accepted D146579: [flang] Move SAVE attribute checks to declaration checking.
Mar 21 2023, 7:54 PM · Restricted Project, Restricted Project
vdonaldson accepted D146576: [flang] Reimplement C1406 check as a warning.
Mar 21 2023, 7:52 PM · Restricted Project, Restricted Project
vdonaldson accepted D146575: [flang] Emit error when a positional actual argument follows an argument with a keyword.
Mar 21 2023, 7:51 PM · Restricted Project, Restricted Project
vdonaldson accepted D146571: [flang] Handle dynamic and remotely scoped non-type-bound UDDTIO subroutines.
Mar 21 2023, 7:04 PM · Restricted Project, Restricted Project

Mar 20 2023

vdonaldson accepted D146445: [flang] Set proper source location for the main function..
Mar 20 2023, 11:16 AM · Restricted Project, Restricted Project

Mar 10 2023

vdonaldson accepted D145754: [flang][runtime] EOF is recoverable only with END= or IOSTAT=.
Mar 10 2023, 9:25 AM · Restricted Project, Restricted Project
vdonaldson accepted D145749: [flang] Fix checking of TBP bindings.
Mar 10 2023, 9:23 AM · Restricted Project, Restricted Project
vdonaldson accepted D145748: [flang] Detect obvious argument shape incompatibility when checking procedure compatibility.
Mar 10 2023, 9:19 AM · Restricted Project, Restricted Project
vdonaldson accepted D145745: [flang][runtime] Catch infinite unlimited format repetition better.
Mar 10 2023, 9:18 AM · Restricted Project, Restricted Project

Mar 9 2023

vdonaldson added a comment to D129969: [flang][OpenMP][OpenACC] Support stop statement in OpenMP/OpenACC region.
In D129969#4182999, @kiranchandramohan wrote:

Adding @vdonaldson also to check whether this is the right way to do this and also for the interaction with the block construct.

Mar 9 2023, 6:05 PM · Restricted Project, Restricted Project

Mar 8 2023

vdonaldson closed D145595: [flang] is_iostat_end and is_iostat_eor intrinsics.

https://reviews.llvm.org/D145595

Mar 8 2023, 1:31 PM · Restricted Project, Restricted Project
vdonaldson committed rG18c6b057a736: [flang] is_iostat_end and is_iostat_eor intrinsics (authored by vdonaldson).
[flang] is_iostat_end and is_iostat_eor intrinsics
Mar 8 2023, 1:27 PM · Restricted Project, Restricted Project
vdonaldson edited reviewers for D145595: [flang] is_iostat_end and is_iostat_eor intrinsics, added: PeteSteinfeld, clementval; removed: sscalpone.
Mar 8 2023, 9:51 AM · Restricted Project, Restricted Project
vdonaldson requested review of D145595: [flang] is_iostat_end and is_iostat_eor intrinsics.
Mar 8 2023, 9:50 AM · Restricted Project, Restricted Project

Mar 1 2023

vdonaldson accepted D145112: [flang] Move check for statement function in BLOCK construct.

Thanks for the fix!

Mar 1 2023, 1:39 PM · Restricted Project, Restricted Project
vdonaldson accepted D145109: [flang] Catch name conflict between generic TBP and inherited non-generic.
Mar 1 2023, 1:38 PM · Restricted Project, Restricted Project
vdonaldson accepted D145107: [flang] BIND(C,NAME=...) corrections.
Mar 1 2023, 1:35 PM · Restricted Project, Restricted Project
vdonaldson accepted D145106: [flang] Enforce prohibition against empty interoperable arrays.
Mar 1 2023, 1:22 PM · Restricted Project, Restricted Project
vdonaldson closed D144916: [flang] Block construct.

https://reviews.llvm.org/D144916

Mar 1 2023, 10:33 AM · Restricted Project, Restricted Project

Feb 28 2023

vdonaldson committed rG2c1433453d16: [flang] Block construct (authored by vdonaldson).
[flang] Block construct
Feb 28 2023, 9:55 AM · Restricted Project, Restricted Project

Feb 27 2023

vdonaldson added a comment to D144916: [flang] Block construct.

Done; thanks

Feb 27 2023, 3:32 PM · Restricted Project, Restricted Project
vdonaldson updated the diff for D144916: [flang] Block construct.

clang-format

Feb 27 2023, 3:28 PM · Restricted Project, Restricted Project
vdonaldson added reviewers for D144916: [flang] Block construct: jeanPerier, clementval, PeteSteinfeld.
Feb 27 2023, 2:27 PM · Restricted Project, Restricted Project
vdonaldson requested review of D144916: [flang] Block construct.
Feb 27 2023, 2:25 PM · Restricted Project, Restricted Project

Feb 16 2023

vdonaldson accepted D144185: [flang] Handle expression in SELECT TYPE selector.

We can delay dealing with rare early-exit cases until we have general code for handling them, which should be fairly soon. So this code is ok as is for now.

Feb 16 2023, 11:05 AM · Restricted Project, Restricted Project
vdonaldson added a comment to D144185: [flang] Handle expression in SELECT TYPE selector.

To add some detail - if an expression includes a function call that returns memory, the memory needs to be freed. And since the construct could have an early exit, the normal exit cleanup might not be invoked. That can be accommodated by immediately finalizing stmtCtx.

Feb 16 2023, 9:42 AM · Restricted Project, Restricted Project
vdonaldson added inline comments to D144185: [flang] Handle expression in SELECT TYPE selector.
Feb 16 2023, 8:59 AM · Restricted Project, Restricted Project

Feb 15 2023

vdonaldson accepted D144133: [flang] Retrieve the correct scope when lowering SELECT TYPE.

So you need to drop down a scope level - looks ok to me.

Feb 15 2023, 4:56 PM · Restricted Project, Restricted Project

Feb 13 2023

vdonaldson added a comment to D143899: [Flang] Fix for Any/All simplification to properly propogate the inital value.

And thanks for the fix!

Feb 13 2023, 1:45 PM · Restricted Project, Restricted Project
vdonaldson accepted D143899: [Flang] Fix for Any/All simplification to properly propogate the inital value.

Looks ok to me

Feb 13 2023, 1:41 PM · Restricted Project, Restricted Project

Feb 12 2023

vdonaldson accepted D143834: [flang] Catch repeated BIND(C) attribute specifications for a symbol.
Feb 12 2023, 9:08 PM · Restricted Project, Restricted Project
vdonaldson accepted D143832: [flang] Check for non-interoperable intrinsic types in BIND(C) derived types.
Feb 12 2023, 9:07 PM · Restricted Project, Restricted Project
vdonaldson accepted D143827: [flang] Pointers returned from functions are not definable as pointers.
Feb 12 2023, 9:04 PM · Restricted Project, Restricted Project
vdonaldson accepted D143823: [flang] Warn about dangerous TRANSFER().
Feb 12 2023, 9:02 PM · Restricted Project, Restricted Project
vdonaldson accepted D143822: [flang] Catch obscure structure constructor error.
Feb 12 2023, 8:59 PM · Restricted Project, Restricted Project
vdonaldson accepted D143820: [flang] Diagnose REPEAT with negative NCOPIES=.
Feb 12 2023, 8:57 PM · Restricted Project, Restricted Project
vdonaldson accepted D143819: [flang] Warn on mismatched DATA substring sizes rather than crashing.
Feb 12 2023, 8:55 PM · Restricted Project, Restricted Project
vdonaldson accepted D143818: [flang] Allow for user-defined intrinsic operators (regression).
Feb 12 2023, 8:53 PM · Restricted Project, Restricted Project
vdonaldson accepted D143817: [flang] Emit portability warning for extension.
Feb 12 2023, 8:52 PM · Restricted Project, Restricted Project

Feb 10 2023

vdonaldson accepted D143780: [flang] Catch misuse of a procedure designator as an output item.
Feb 10 2023, 4:23 PM · Restricted Project, Restricted Project
vdonaldson accepted D143776: [flang] Warn about construct names that are not distinct in the inclusive scope.
Feb 10 2023, 4:21 PM · Restricted Project, Restricted Project
vdonaldson accepted D143778: [flang] Fix crash on SELECT RANK.
Feb 10 2023, 4:18 PM · Restricted Project, Restricted Project
vdonaldson added a comment to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

The following code has a regression. Output from this code is now T; the output should be F.

Feb 10 2023, 11:21 AM · Restricted Project, Restricted Project

Feb 8 2023

vdonaldson added a comment to D143589: [flang] Fix optional assertion in PFTBuilder.

This is a good permanent fix for the problem.

Feb 8 2023, 10:49 AM · Restricted Project, Restricted Project