Page MenuHomePhabricator

vdonaldson (vdonaldson)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2021, 1:18 PM (20 w, 3 d)

Recent Activity

Today

vdonaldson accepted D117819: [flang] Handle FLUSH(unknown unit).
Thu, Jan 20, 11:21 AM · Restricted Project, Restricted Project
vdonaldson accepted D117816: [flang] Fix OPEN/WRITE(SIGN='SUPPRESS').
Thu, Jan 20, 11:09 AM · Restricted Project, Restricted Project

Yesterday

vdonaldson accepted D117698: [flang] Accept BOZ literals for some actual arguments.
Wed, Jan 19, 10:35 AM · Restricted Project, Restricted Project
vdonaldson accepted D117699: [flang] Improve error message (initialized variable in pure subprogram).
Wed, Jan 19, 10:25 AM · Restricted Project, Restricted Project

Tue, Jan 18

vdonaldson accepted D117596: [flang] runtime: catch OPEN(ACCESS='DIRECT',POSITION=).
Tue, Jan 18, 1:34 PM · Restricted Project, Restricted Project
vdonaldson accepted D117595: [flang] runtime error on inappropriate OPEN(UNIT=extant,RECL=n).
Tue, Jan 18, 1:27 PM · Restricted Project, Restricted Project
vdonaldson accepted D117576: [flang] Support substring references in NAMELIST input.
Tue, Jan 18, 10:35 AM · Restricted Project, Restricted Project

Fri, Jan 14

vdonaldson accepted D117342: [flang] Don't blank-fill remaining lines in internal output.
Fri, Jan 14, 11:21 AM · Restricted Project, Restricted Project
vdonaldson accepted D117346: [flang] Signal runtime error on WRITE after ENDFILE.
Fri, Jan 14, 11:17 AM · Restricted Project, Restricted Project
vdonaldson closed D117336: [flang] "CFI" types for Fortran REAL and COMPLEX kinds 2, 3, 10, 16.

https://reviews.llvm.org/D117336

Fri, Jan 14, 11:13 AM · Restricted Project
vdonaldson accepted D117344: [flang] Legacy extension: non-character formats.
Fri, Jan 14, 11:11 AM · Restricted Project, Restricted Project
vdonaldson committed rGe43b2e4f480b: [flang] "CFI" types for Fortran REAL and COMPLEX kinds 2, 3, 10, 16 (authored by vdonaldson).
[flang] "CFI" types for Fortran REAL and COMPLEX kinds 2, 3, 10, 16
Fri, Jan 14, 11:07 AM
vdonaldson added inline comments to D117342: [flang] Don't blank-fill remaining lines in internal output.
Fri, Jan 14, 11:02 AM · Restricted Project, Restricted Project
vdonaldson added a reviewer for D117336: [flang] "CFI" types for Fortran REAL and COMPLEX kinds 2, 3, 10, 16: klausler.
Fri, Jan 14, 10:15 AM · Restricted Project
vdonaldson requested review of D117336: [flang] "CFI" types for Fortran REAL and COMPLEX kinds 2, 3, 10, 16.
Fri, Jan 14, 10:14 AM · Restricted Project

Wed, Jan 12

vdonaldson accepted D117154: [flang] Any type can appear in a structure constructor for an unlimited polymorphic allocatable component.
Wed, Jan 12, 3:19 PM · Restricted Project, Restricted Project
vdonaldson accepted D117149: [flang] RESHAPE(PAD=) can be arbitrary array rank.
Wed, Jan 12, 3:13 PM · Restricted Project, Restricted Project
vdonaldson accepted D117148: [flang] Fix handling of space between # and name in preprocessor stringification.
Wed, Jan 12, 3:09 PM · Restricted Project, Restricted Project

Tue, Jan 4

vdonaldson closed D116622: [flang] Modify an IO format error message.

https://reviews.llvm.org/D116622

Tue, Jan 4, 2:29 PM · Restricted Project
vdonaldson committed rGdd7d5bc5bd46: [flang] Modify an IO format error message (authored by vdonaldson).
[flang] Modify an IO format error message
Tue, Jan 4, 2:28 PM
vdonaldson added a reviewer for D116622: [flang] Modify an IO format error message: klausler.
Tue, Jan 4, 1:17 PM · Restricted Project
vdonaldson requested review of D116622: [flang] Modify an IO format error message.
Tue, Jan 4, 1:16 PM · Restricted Project

Dec 15 2021

vdonaldson accepted D115763: [flang] Add a new memory allocation rewrite pass..
Dec 15 2021, 11:37 AM · Restricted Project, Restricted Project

Dec 9 2021

vdonaldson accepted D115470: [flang] Fix folding of ac-implied-do indices in structure c'tors.
Dec 9 2021, 2:23 PM · Restricted Project, Restricted Project

Dec 7 2021

vdonaldson accepted D115165: [flang] Remove runtime check from OpenFile::Close().
Dec 7 2021, 9:40 AM · Restricted Project, Restricted Project
vdonaldson accepted D115184: [flang] Avoid potential deadlock in CloseAll().
Dec 7 2021, 9:20 AM · Restricted Project

Dec 6 2021

vdonaldson accepted D115190: [flang] Fix INQUIRE(FILE=,NAME=).
Dec 6 2021, 3:08 PM · Restricted Project, Restricted Project

Dec 4 2021

vdonaldson accepted D115102: [flang] OPEN(RECL=) handling for sequential formatted I/O.
Dec 4 2021, 11:41 AM · Restricted Project, Restricted Project

Dec 1 2021

vdonaldson accepted D114897: [flang] Don't close stderr in runtime (fixes STOP output).
Dec 1 2021, 12:11 PM · Restricted Project, Restricted Project

Nov 29 2021

vdonaldson accepted D114755: [flang] Correct INQUIRE(POSITION= & PAD=).
Nov 29 2021, 4:46 PM · Restricted Project, Restricted Project
vdonaldson accepted D114754: [flang] Re-fold bounds expressions in DATA implied DO loops.
Nov 29 2021, 4:42 PM · Restricted Project, Restricted Project

Nov 22 2021

vdonaldson accepted D114296: [flang] Correct the argument keyword for AIMAG(Z=...).
Nov 22 2021, 4:12 PM · Restricted Project, Restricted Project

Nov 19 2021

vdonaldson accepted D114298: [flang] Predefine unit 0 connected to stderr.
Nov 19 2021, 4:17 PM · Restricted Project, Restricted Project

Nov 17 2021

vdonaldson accepted D114028: [flang] Fix INQUIRE(PAD=) and (POSITION=) for predefined units.
Nov 17 2021, 10:23 AM · Restricted Project, Restricted Project

Nov 16 2021

vdonaldson closed D114016: [flang] Fix a bug in INQUIRE(IOLENGTH=) output.

https://reviews.llvm.org/D114016

Nov 16 2021, 11:40 AM · Restricted Project
vdonaldson committed rGea8cdf322f39: [flang] Fix a bug in INQUIRE(IOLENGTH=) output (authored by vdonaldson).
[flang] Fix a bug in INQUIRE(IOLENGTH=) output
Nov 16 2021, 11:33 AM
vdonaldson added a reviewer for D114016: [flang] Fix a bug in INQUIRE(IOLENGTH=) output: klausler.
Nov 16 2021, 11:18 AM · Restricted Project
vdonaldson requested review of D114016: [flang] Fix a bug in INQUIRE(IOLENGTH=) output.
Nov 16 2021, 11:15 AM · Restricted Project

Nov 12 2021

vdonaldson accepted D113697: [flang] Runtime performance improvements to real formatted input.
Nov 12 2021, 9:24 AM · Restricted Project, Restricted Project

Nov 8 2021

vdonaldson accepted D113312: [flang] Make subscript list argument a nullable pointer.
Nov 8 2021, 10:49 AM · Restricted Project, Restricted Project

Nov 5 2021

vdonaldson accepted D113311: [flang] Complete the fix for NAMELIST look-ahead case.
Nov 5 2021, 12:48 PM · Restricted Project, Restricted Project
vdonaldson accepted D113258: [flang] Set the addendum when establishing pointer section in descriptor.
Nov 5 2021, 9:36 AM · Restricted Project, Restricted Project

Oct 28 2021

vdonaldson accepted D112742: [flang] Revert new unintended runtime behavior.
Oct 28 2021, 1:53 PM · Restricted Project, Restricted Project

Oct 22 2021

vdonaldson accepted D112346: [flang] Support legacy usage of 'A' edit descriptors for integer & real.
Oct 22 2021, 3:52 PM · Restricted Project, Restricted Project
vdonaldson accepted D112347: [flang] Fix NAMELIST input bug with multiple subscript triplets.
Oct 22 2021, 3:52 PM · Restricted Project, Restricted Project
vdonaldson accepted D112345: [flang] Fix DOT_PRODUCT for logical.
Oct 22 2021, 3:51 PM · Restricted Project, Restricted Project
vdonaldson accepted D112350: [flang] Extension: allow tabs in output format strings.
Oct 22 2021, 3:48 PM · Restricted Project, Restricted Project
vdonaldson accepted D112351: [flang] Fix crash on empty formatted external READs.
Oct 22 2021, 3:47 PM · Restricted Project, Restricted Project

Oct 21 2021

vdonaldson accepted D112245: [flang] Support NAMELIST input of short arrays.

If we ever consider the extension of allowing '.' as an alternative to '%' for component access, that might have consequences here.

Oct 21 2021, 12:28 PM · Restricted Project, Restricted Project
vdonaldson accepted D112243: [flang] Emit unformatted headers & footers even with RECL=.
Oct 21 2021, 11:40 AM · Restricted Project, Restricted Project

Oct 12 2021

vdonaldson accepted D111678: [flang] runtime: fix output B/O/Z editing of "negative" values.
Oct 12 2021, 3:30 PM · Restricted Project, Restricted Project

Oct 6 2021

vdonaldson accepted D111253: [flang] Define IEEE_SCALB, IEEE_NEXT_AFTER, IEEE_NEXT_DOWN, IEEE_NEXT_UP.
Oct 6 2021, 12:08 PM · Restricted Project, Restricted Project

Sep 3 2021

vdonaldson closed D109072: [flang] Remove blank from NaN string representation.
Sep 3 2021, 1:16 PM · Restricted Project, Restricted Project
vdonaldson committed rG29c3ef5a0e5f: Remove blank from NaN string representation (authored by vdonaldson).
Remove blank from NaN string representation
Sep 3 2021, 8:10 AM

Sep 1 2021

vdonaldson updated the diff for D109072: [flang] Remove blank from NaN string representation.

Flang front end function DumpHexadecimal generates a string representation of a REAL value. When the value is a NaN, the string contains a blank, as in "NaN 0x7fc00000". This function is used by lowering to generate a string that is then passed to llvm Support function ConvertFromStringSpecials, which does not expect a blank in the string. Remove the blank to allow correct recognition of a NaN by this llvm function.

Sep 1 2021, 5:46 PM · Restricted Project, Restricted Project
vdonaldson retitled D109072: [flang] Remove blank from NaN string representation from Remove blank from NaN string representation to [flang] Remove blank from NaN string representation.
Sep 1 2021, 10:30 AM · Restricted Project, Restricted Project
vdonaldson requested review of D109072: [flang] Remove blank from NaN string representation.
Sep 1 2021, 10:16 AM · Restricted Project, Restricted Project