This is an archive of the discontinued LLVM Phabricator instance.

[ValueTypes] Add types for nxv16bf16 and nxv32bf16.
ClosedPublic

Authored by craig.topper on Jun 15 2022, 9:53 AM.

Details

Summary

This is needed by our downstream and makes bf16 and f16 have the
same set of scalable vector types.

Diff Detail

Event Timeline

craig.topper created this revision.Jun 15 2022, 9:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 9:53 AM
craig.topper requested review of this revision.Jun 15 2022, 9:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 9:53 AM
rui.zhang accepted this revision.Jun 15 2022, 10:14 AM
This revision is now accepted and ready to land.Jun 15 2022, 10:14 AM
This revision was landed with ongoing or failed builds.Jun 15 2022, 11:06 PM
This revision was automatically updated to reflect the committed changes.
Amir added a subscriber: Amir.Jun 16 2022, 1:19 PM

This diff breaks MSVC build: https://lab.llvm.org/buildbot/#/builders/222/builds/1268. Can you please take a look?

craig.topper added a comment.EditedJun 16 2022, 2:25 PM

This diff breaks MSVC build: https://lab.llvm.org/buildbot/#/builders/222/builds/1268. Can you please take a look?

It feels like llvm-tblgen didn't get rebuilt and is out of sync with ValueTypes.td. Is that possible?

The last time these files were updated this same bot failed with a tablegen error from build 896 through at least build 1130.

Amir added a comment.Jun 16 2022, 3:52 PM

This diff breaks MSVC build: https://lab.llvm.org/buildbot/#/builders/222/builds/1268. Can you please take a look?

It feels like llvm-tblgen didn't get rebuilt and is out of sync with ValueTypes.td. Is that possible?

The last time these files were updated this same bot failed with a tablegen error from build 896 through at least build 1130.

Thanks for looking! You're right, llvm-tblgen is not rebuilt (it's a cross-compilation setup). Will address that