[Debug] [Coroutines] Get rid of DW_ATE_address

[ChuanqiXu]

Summary

Fixing https://github.com/llvm/llvm-project/issues/55916

This patch tries to get rid of DW_ATE_address and enhance the test coverage.

[dblaikie]

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

917–931

How come this one became unsigned char rather than pointer type?

llvm/test/Transforms/Coroutines/coro-debug-coro-frame.ll

16–17

CHECK-NOT only applies between one CHECK and the next, so this probably won't do much/not enough to carry its weight, I'd guess?

(--implicit-check-not as an argument to FileCheck anti-checks for the value everywhere, but even then - I'm happy to drop this testing if the source code no longer mentions DW_ATE_address anywhere anyway, and the things being emitted are being actively tested for instead)

37

Why does this type have a name? I think it should probably be nameless - so it should merge with other instances of the same pointer type created for the original source code, etc.

72–73

why are there changes to the IR here? I guess they're necessary to create the interesting debug info IR being tested?

[ChuanqiXu]

Address comments.

[ChuanqiXu]

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

917–931

The intention of the 'else' section is to create a DIType for an unresolved type. And the unresolved type lives in the coroutine frame. So it is a little bit odd for me to treat it as a pointer type. Since the size of the unresolved type might be larger than a pointer.

The choice to use DW_ATE_unsigned_char might not be correct. Here is my thoughts. I want to treat the unresolved type as bytes. I want to make it as something like "I don't know what you are so I will present the bytes directly". And DW_ATE_unsigned_char is the closest thing I found in DW_ATE* things. How do you think about it?

This is covered in the test as vector types. Since we failed to recognize vector types now, we would treat it as a unresolved type with 128 size.

llvm/test/Transforms/Coroutines/coro-debug-coro-frame.ll

37

The name here is try to provide more information as much as possible. Ideally, I think this one should be the int* type. It shows the the ability of type resolver in current coroutine compiler is not strong enough. Given this revision aims to get rid of DW_ATE_address, I would try to fix the problem in other revisions.

For the duplicated DITypes problem, this is tested in the following function 'bar' that the generated DIType would be reused.

72–73

This is intended to test the result of unresolved type.

[dblaikie]

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

917–931

So this is going to create an arbitrarily large "unsigned char" type (that might be tens of bytes, etc?) - is it at least a multiple of whole bytes? Maybe it should be a char array instead?

llvm/test/Transforms/Coroutines/coro-debug-coro-frame.ll

37

The name here is try to provide more information as much as possible. Ideally, I think this one should be the int* type.

Any reason it can't be int*? Currently it's void*.

Given this revision aims to get rid of DW_ATE_address, I would try to fix the problem in other revisions.

Sure

For the duplicated DITypes problem, this is tested in the following function 'bar' that the generated DIType would be reused.

I was thinking of the types created from the original C++ source that has pointers in it too - not other types created by the coroutine lowering code.

[ChuanqiXu]

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

917–931

So this is going to create an arbitrarily large "unsigned char" type (that might be tens of bytes, etc?)

Yes.

is it at least a multiple of whole bytes? Maybe it should be a char array instead?

From my understanding, I feel like the allowed choices is listed in https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/BinaryFormat/Dwarf.def#L917-L937. I feel like a char array might be good. But I am not sure how to make it.

llvm/test/Transforms/Coroutines/coro-debug-coro-frame.ll

37

Any reason it can't be int*? Currently it's void*.

It is due to the current mechanism to solve LLVM types to DITypes is not mature enough. My bad. Let's enhance them later.

I was thinking of the types created from the original C++ source that has pointers in it too - not other types created by the coroutine lowering code.

It would try to find @dbg.declare intrinsics for variables in the frame. If founded, it would reuse that one. But if it failed to find one, it would only try to create one.

[dblaikie]

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

917–931

You can check Clang's code for making array types - DIBuilder::createArrayType, passed in the char basic type.

llvm/test/Transforms/Coroutines/coro-debug-coro-frame.ll

37

Any reason it can't be int*? Currently it's void*.

It is due to the current mechanism to solve LLVM types to DITypes is not mature enough. My bad. Let's enhance them later.

Not sure I follow - but sure, can handle that in a follow-up patch.

I was thinking of the types created from the original C++ source that has pointers in it too - not other types created by the coroutine lowering code.

It would try to find @dbg.declare intrinsics for variables in the frame. If founded, it would reuse that one. But if it failed to find one, it would only try to create one.

Sure - but what I mean is if it tries to create one it could create one that's more similar to the ones the frontend would create - a named pointer type is a weird beast that we wouldn't usually create in the frontend (pointer types don't have names, unless it's via a typedef - the typedef has the name, the pointer type does not).

[ChuanqiXu]

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

917–931

Thanks! But during the process of implementing it, I find it is more complex than necessary. We need to judge if it is larger than a byte or if it is a multiple of bytes. So that we have at least 3 cases to handle. In my mind, we only need to provide two properties when we meet unknowing types: start address and the size. So that the users could debug in the pretty old fashion (assume the size of the unknown type is 128 in the example):

(gdb) x/128x the_variable_address_of_unknow_types

And the current implementation looks not bad in this direction. I totally understand that it looks not good in the code: how come we get a char in 128 bits ?! It looks odd indeed. But from my experience, the users wouldn't be strict with the Dwarf Type in the case since the type name starts with 'Unknown'. What I want to say here is that: it might not be good indeed but it is not so bad too. The root problem here might be that we're going to construct debug info in middle end. So we would meet some weird things I guess.

llvm/test/Transforms/Coroutines/coro-debug-coro-frame.ll

37

Sure - but what I mean is if it tries to create one it could create one that's more similar to the ones the frontend would create - a named pointer type is a weird beast that we wouldn't usually create in the frontend (pointer types don't have names, unless it's via a typedef - the typedef has the name, the pointer type does not).

Got it. Will do in following patches.

[dblaikie]

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

917–931

I'm not sure I understand the complexity - I'd asked earlier if it was always a byte multiple, which I think you said it was - in that case I'd always create an array of that many bytes. I don't think this should be complicated.

This would be more likely to be supported by DWARF Consumers (I'm not sure what they'd do with a huge integer type) & probably render more meaningfully for users (rather than as one big integer, array printers in debuggers do smart user-customizable things like printing only the first N array elements and then using ..., etc).

[ChuanqiXu]

Treat unresolved type as array of bytes instead of a big char.

[ChuanqiXu]

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

917–931

I'm not sure I understand the complexity - I'd asked earlier if it was always a byte multiple, which I think you said it was - in that case I'd always create an array of that many bytes. I don't think this should be complicated.

Sorry for the confusion. My bad. For the question if it is always a byte multiple, according to my experiments these days, it is always a byte multiple in C++ due to the alignment requirement. I also added an assert (Size % 8 == 0) and run it for some workloads. It looked fine. But for LLVM IR, we could make the assertion failure simply by making a vector type of <9 x i1>. So I add the if part in this revision.

This would be more likely to be supported by DWARF Consumers (I'm not sure what they'd do with a huge integer type) & probably render more meaningfully for users (rather than as one big integer, array printers in debuggers do smart user-customizable things like printing only the first N array elements and then using ..., etc).

You know debugger much than me. I'd follow it.

[dblaikie]

Think this is alright?

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

917–931

OK, sounds good!

[vitalybuka]

Breaks https://lab.llvm.org/buildbot/#/builders/5/builds/25932 ?

[vitalybuka]

In D127625#3634546, @vitalybuka wrote:

Breaks https://lab.llvm.org/buildbot/#/builders/5/builds/25932 ?

Sorry, it's probably D129100

llvm/lib/Transforms/Coroutines/CoroFrame.cpp

if (Ty->isIntegerTy()) {
     auto BitWidth = cast<IntegerType>(Ty)->getBitWidth();
     RetType = Builder.createBasicType(Name, BitWidth, dwarf::DW_ATE_signed,
                                       llvm::DINode::FlagArtificial);
   } else if (Ty->isFloatingPointTy()) {
     RetType = Builder.createBasicType(Name, Layout.getTypeSizeInBits(Ty),
                                       dwarf::DW_ATE_float,
                                       llvm::DINode::FlagArtificial);
   } else if (Ty->isPointerTy()) {
-    // Construct BasicType instead of PointerType to avoid infinite
-    // search problem.
-    // For example, we would be in trouble if we traverse recursively:
+    // Construct PointerType points to null (aka void *) instead of exploring
+    // pointee type to avoid infinite search problem. For example, we would be
+    // in trouble if we traverse recursively:
     //
     //  struct Node {
     //      Node* ptr;
     //  };
-    RetType = Builder.createBasicType(Name, Layout.getTypeSizeInBits(Ty),
-                                      dwarf::DW_ATE_address,
-                                      llvm::DINode::FlagArtificial);
+    RetType = Builder.createPointerType(nullptr, Layout.getTypeSizeInBits(Ty),
+                                        Layout.getABITypeAlignment(Ty),
+                                        /*DWARFAddressSpace=*/None, Name);
   } else if (Ty->isStructTy()) {
     auto *DIStruct = Builder.createStructType(
         Scope, Name, Scope->getFile(), LineNum, Layout.getTypeSizeInBits(Ty),
         Layout.getPrefTypeAlignment(Ty), llvm::DINode::FlagArtificial, nullptr,
         llvm::DINodeArray());
 
     auto *StructTy = cast<StructType>(Ty);
     SmallVector<Metadata *, 16> Elements;
     for (unsigned I = 0; I < StructTy->getNumElements(); I++) {
       DIType *DITy = solveDIType(Builder, StructTy->getElementType(I), Layout,
                                  Scope, LineNum, DITypeCache);
       assert(DITy);
       Elements.push_back(Builder.createMemberType(
           Scope, DITy->getName(), Scope->getFile(), LineNum,
           DITy->getSizeInBits(), DITy->getAlignInBits(),
           Layout.getStructLayout(StructTy)->getElementOffsetInBits(I),
           llvm::DINode::FlagArtificial, DITy));
     }
 
     Builder.replaceArrays(DIStruct, Builder.getOrCreateArray(Elements));
 
     RetType = DIStruct;
   } else {
-    LLVM_DEBUG(dbgs() << "Unresolved Type: " << *Ty << "\n";);
-    SmallString<32> Buffer;
-    raw_svector_ostream OS(Buffer);
-    OS << Name.str() << "_" << Layout.getTypeSizeInBits(Ty);
-    RetType = Builder.createBasicType(OS.str(), Layout.getTypeSizeInBits(Ty),
-                                      dwarf::DW_ATE_address,
-                                      llvm::DINode::FlagArtificial);
+    LLVM_DEBUG(dbgs() << "Unresolved Type: " << *Ty << "\n");
+    TypeSize Size = Layout.getTypeSizeInBits(Ty);
+    auto *CharSizeType = Builder.createBasicType(
+        Name, 8, dwarf::DW_ATE_unsigned_char, llvm::DINode::FlagArtificial);
+
+    if (Size <= 8)
+      RetType = CharSizeType;
+    else {
+      if (Size % 8 != 0)
+        Size = TypeSize::Fixed(Size + 8 - (Size % 8));
+
+      RetType = Builder.createArrayType(
+          Size, Layout.getPrefTypeAlign(Ty).value(), CharSizeType,
+          Builder.getOrCreateArray(Builder.getOrCreateSubrange(0, Size / 8)));
+    }
   }
 
   DITypeCache.insert({Ty, RetType});
   return RetType;
 }
 
 /// Build artificial debug info for C++ coroutine frames to allow users to
 /// inspect the contents of the frame directly
static void buildFrameDebugInfo(Function &F, coro::Shape &Shape,
   NameCache.insert({DestroyIndex, "__destroy_fn"});
   NameCache.insert({IndexIndex, "__coro_index"});
 
   Type *ResumeFnTy = FrameTy->getElementType(ResumeIndex),
        *DestroyFnTy = FrameTy->getElementType(DestroyIndex),
        *IndexTy = FrameTy->getElementType(IndexIndex);
 
   DenseMap<unsigned, DIType *> TyCache;
-  TyCache.insert({ResumeIndex,
-                  DBuilder.createBasicType("__resume_fn",
-                                           Layout.getTypeSizeInBits(ResumeFnTy),
-                                           dwarf::DW_ATE_address)});
   TyCache.insert(
-      {DestroyIndex, DBuilder.createBasicType(
-                         "__destroy_fn", Layout.getTypeSizeInBits(DestroyFnTy),
-                         dwarf::DW_ATE_address)});
+      {ResumeIndex, DBuilder.createPointerType(
+                        nullptr, Layout.getTypeSizeInBits(ResumeFnTy))});
+  TyCache.insert(
+      {DestroyIndex, DBuilder.createPointerType(
+                         nullptr, Layout.getTypeSizeInBits(DestroyFnTy))});
 
   /// FIXME: If we fill the field `SizeInBits` with the actual size of
   /// __coro_index in bits, then __coro_index wouldn't show in the debugger.
   TyCache.insert({IndexIndex, DBuilder.createBasicType(
                                   "__coro_index",
                                   (Layout.getTypeSizeInBits(IndexTy) < 8)
                                       ? 8
                                       : Layout.getTypeSizeInBits(IndexTy),

llvm/test/Transforms/Coroutines/coro-debug-coro-frame.ll

 ; RUN: opt < %s -passes='module(coro-early),cgscc(coro-split,coro-split)' -S | FileCheck %s
 
 ; Checks whether the dbg.declare for `__coro_frame` are created.
 
 ; CHECK-LABEL: define void @f(
 ; CHECK:       coro.init:
 ; CHECK:        %[[begin:.*]] = call noalias nonnull i8* @llvm.coro.begin(
 ; CHECK:        call void @llvm.dbg.declare(metadata i8* %[[begin]], metadata ![[CORO_FRAME:[0-9]+]], metadata !DIExpression())
 ; CHECK:        %[[FramePtr:.*]] = bitcast i8* %[[begin]] to
 ;
 ; CHECK:       define internal fastcc void @f.resume(
 ; CHECK:       entry.resume:
 ; CHECK:            %[[FramePtr_RESUME:.*]] = alloca %f.Frame*
 ; CHECK:            call void @llvm.dbg.declare(metadata %f.Frame** %[[FramePtr_RESUME]], metadata ![[CORO_FRAME_IN_RESUME:[0-9]+]], metadata !DIExpression(DW_OP_deref)
 ;
 ; CHECK-DAG: ![[FILE:[0-9]+]] = !DIFile(filename: "coro-debug.cpp"
 ; CHECK-DAG: ![[RAMP:[0-9]+]] = distinct !DISubprogram(name: "foo", linkageName: "_Z3foov",
 ; CHECK-DAG: ![[RAMP_SCOPE:[0-9]+]] = distinct !DILexicalBlock(scope: ![[RAMP]], file: ![[FILE]], line: 23
 ; CHECK-DAG: ![[CORO_FRAME]] = !DILocalVariable(name: "__coro_frame", scope: ![[RAMP_SCOPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE:[0-9]+]], type: ![[FRAME_TYPE:[0-9]+]], flags: DIFlagArtificial)
 ; CHECK-DAG: ![[FRAME_TYPE]] = !DICompositeType(tag: DW_TAG_structure_type, name: "f.coro_frame_ty", {{.*}}elements: ![[ELEMENTS:[0-9]+]]
-; CHECK-DAG: ![[ELEMENTS]] = !{![[RESUME_FN:[0-9]+]], ![[DESTROY_FN:[0-9]+]], ![[PROMISE:[0-9]+]], ![[INT64_0:[0-9]+]], ![[DOUBLE_1:[0-9]+]], ![[INT32_2:[0-9]+]], ![[INT32_3:[0-9]+]], ![[STRUCT_4:[0-9]+]], ![[CORO_INDEX:[0-9]+]]
-; CHECK-DAG: ![[RESUME_FN]] = !DIDerivedType(tag: DW_TAG_member, name: "__resume_fn"{{.*}}, flags: DIFlagArtificial
-; CHECK-DAG: ![[DESTROY_FN]] = !DIDerivedType(tag: DW_TAG_member, name: "__destroy_fn"{{.*}}, flags: DIFlagArtificial
+; CHECK-DAG: ![[ELEMENTS]] = !{![[RESUME_FN:[0-9]+]], ![[DESTROY_FN:[0-9]+]], ![[PROMISE:[0-9]+]], ![[VECTOR_TYPE:[0-9]+]], ![[INT64_0:[0-9]+]], ![[DOUBLE_1:[0-9]+]], ![[INT64_PTR:[0-9]+]], ![[INT32_2:[0-9]+]], ![[INT32_3:[0-9]+]], ![[UNALIGNED_UNKNOWN:[0-9]+]], ![[STRUCT:[0-9]+]], ![[CORO_INDEX:[0-9]+]], ![[SMALL_UNKNOWN:[0-9]+]]
+; CHECK-DAG: ![[RESUME_FN]] = !DIDerivedType(tag: DW_TAG_member, name: "__resume_fn"{{.*}}, baseType: ![[RESUME_FN_TYPE:[0-9]+]]{{.*}}, flags: DIFlagArtificial
+; CHECK-DAG: ![[RESUME_FN_TYPE]] = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: null, size: 64)
+; CHECK-DAG: ![[DESTROY_FN]] = !DIDerivedType(tag: DW_TAG_member, name: "__destroy_fn"{{.*}}, baseType: ![[RESUME_FN_TYPE]]{{.*}}, flags: DIFlagArtificial
 ; CHECK-DAG: ![[PROMISE]] = !DIDerivedType(tag: DW_TAG_member, name: "__promise",{{.*}}baseType: ![[PROMISE_BASE:[0-9]+]]
 ; CHECK-DAG: ![[PROMISE_BASE]] = !DIDerivedType(tag: DW_TAG_typedef, name: "promise_type"
-; CHECK-DAG: ![[INT64_0]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_64_0", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[I64_BASE:[0-9]+]],{{.*}}, flags: DIFlagArtificial
+; CHECK-DAG: ![[VECTOR_TYPE]] = !DIDerivedType(tag: DW_TAG_member, name: "_0",{{.*}}baseType: ![[VECTOR_TYPE_BASE:[0-9]+]], size: 128
+; CHECK-DAG: ![[VECTOR_TYPE_BASE]] = !DICompositeType(tag: DW_TAG_array_type, baseType: ![[UNKNOWN_TYPE_BASE:[0-9]+]], size: 128, align: 16, elements: ![[VECTOR_TYPE_BASE_ELEMENTS:[0-9]+]])
+; CHECK-DAG: ![[UNKNOWN_TYPE_BASE]] = !DIBasicType(name: "UnknownType", size: 8, encoding: DW_ATE_unsigned_char, flags: DIFlagArtificial)
+; CHECK-DAG: ![[VECTOR_TYPE_BASE_ELEMENTS]] = !{![[VECTOR_TYPE_BASE_SUBRANGE:[0-9]+]]}
+; CHECK-DAG: ![[VECTOR_TYPE_BASE_SUBRANGE]] = !DISubrange(count: 16, lowerBound: 0)
+; CHECK-DAG: ![[INT64_0]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_64_1", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[I64_BASE:[0-9]+]],{{.*}}, flags: DIFlagArtificial
 ; CHECK-DAG: ![[I64_BASE]] = !DIBasicType(name: "__int_64", size: 64, encoding: DW_ATE_signed, flags: DIFlagArtificial)
-; CHECK-DAG: ![[DOUBLE_1]] = !DIDerivedType(tag: DW_TAG_member, name: "__double__1", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[DOUBLE_BASE:[0-9]+]]{{.*}}, flags: DIFlagArtificial
+; CHECK-DAG: ![[DOUBLE_1]] = !DIDerivedType(tag: DW_TAG_member, name: "__double__2", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[DOUBLE_BASE:[0-9]+]]{{.*}}, flags: DIFlagArtificial
 ; CHECK-DAG: ![[DOUBLE_BASE]] = !DIBasicType(name: "__double_", size: 64, encoding: DW_ATE_float, flags: DIFlagArtificial)
-; CHECK-DAG: ![[INT32_2]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_32_2", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[I32_BASE:[0-9]+]]{{.*}}, flags: DIFlagArtificial
+; CHECK-DAG: ![[INT64_PTR]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_64_Ptr_3",{{.*}} baseType: ![[INT64_PTR_BASE:[0-9]+]]
+; CHECK-DAG: ![[INT64_PTR_BASE]] = !DIDerivedType(tag: DW_TAG_pointer_type, name: "__int_64_Ptr", baseType: null, size: 64
+; CHECK-DAG: ![[INT32_2]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_32_4", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[I32_BASE:[0-9]+]]{{.*}}, flags: DIFlagArtificial
 ; CHECK-DAG: ![[I32_BASE]] = !DIBasicType(name: "__int_32", size: 32, encoding: DW_ATE_signed, flags: DIFlagArtificial)
-; CHECK-DAG: ![[INT32_3]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_32_3", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[I32_BASE]]
-; CHECK-DAG: ![[STRUCT_4]] = !DIDerivedType(tag: DW_TAG_member, name: "struct_big_structure_4", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[STRUCT_BASE:[0-9]+]]
+; CHECK-DAG: ![[INT32_3]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_32_5", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[I32_BASE]]
+; CHECK-DAG: ![[UNALIGNED_UNKNOWN]] = !DIDerivedType(tag: DW_TAG_member, name: "_6",{{.*}}baseType: ![[UNALIGNED_UNKNOWN_BASE:[0-9]+]], size: 9
+; CHECK-DAG: ![[UNALIGNED_UNKNOWN_BASE]] = !DICompositeType(tag: DW_TAG_array_type, baseType: ![[UNKNOWN_TYPE_BASE]], size: 16,{{.*}} elements: ![[UNALIGNED_UNKNOWN_ELEMENTS:[0-9]+]])
+; CHECK-DAG: ![[UNALIGNED_UNKNOWN_ELEMENTS]] = !{![[UNALIGNED_UNKNOWN_SUBRANGE:[0-9]+]]}
+; CHECk-DAG: ![[UNALIGNED_UNKNOWN_SUBRANGE]] = !DISubrange(count: 2, lowerBound: 0)
+; CHECK-DAG: ![[STRUCT]] = !DIDerivedType(tag: DW_TAG_member, name: "struct_big_structure_7", scope: ![[FRAME_TYPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]], baseType: ![[STRUCT_BASE:[0-9]+]]
 ; CHECK-DAG: ![[STRUCT_BASE]] = !DICompositeType(tag: DW_TAG_structure_type, name: "struct_big_structure"{{.*}}elements: ![[STRUCT_ELEMENTS:[0-9]+]]
 ; CHECK-DAG: ![[STRUCT_ELEMENTS]] = !{![[MEM_TYPE:[0-9]+]]}
-; CHECK-DAG: ![[MEM_TYPE]] = !DIDerivedType(tag: DW_TAG_member, name: "UnknownType_4000"
+; CHECK-DAG: ![[MEM_TYPE]] = !DIDerivedType(tag: DW_TAG_member,{{.*}} baseType: ![[MEM_TYPE_BASE:[0-9]+]], size: 4000
+; CHECK-DAG: ![[MEM_TYPE_BASE]] = !DICompositeType(tag: DW_TAG_array_type, baseType: ![[UNKNOWN_TYPE_BASE]], size: 4000,
 ; CHECK-DAG: ![[CORO_INDEX]] = !DIDerivedType(tag: DW_TAG_member, name: "__coro_index"
+; CHECK-DAG: ![[SMALL_UNKNOWN]] = !DIDerivedType(tag: DW_TAG_member, name: "UnknownType_8",{{.*}} baseType: ![[UNKNOWN_TYPE_BASE]], size: 5
 ; CHECK-DAG: ![[PROMISE_VAR:[0-9]+]] = !DILocalVariable(name: "__promise", scope: ![[RAMP_SCOPE]], file: ![[FILE]], line: [[PROMISE_VAR_LINE]]
 ; CHECK-DAG: ![[BAR_FUNC:[0-9]+]] = distinct !DISubprogram(name: "bar", linkageName: "_Z3barv",
 ; CHECK-DAG: ![[BAR_SCOPE:[0-9]+]] = distinct !DILexicalBlock(scope: ![[BAR_FUNC]], file: !1
 ; CHECK-DAG: ![[FRAME_TYPE_IN_BAR:[0-9]+]] = !DICompositeType(tag: DW_TAG_structure_type, name: "bar.coro_frame_ty", file: ![[FILE]], line: [[BAR_LINE:[0-9]+]]{{.*}}elements: ![[ELEMENTS_IN_BAR:[0-9]+]]
-; CHECK-DAG: ![[ELEMENTS_IN_BAR]] = !{![[RESUME_FN_IN_BAR:[0-9]+]], ![[DESTROY_FN_IN_BAR:[0-9]+]], ![[PROMISE_IN_BAR:[0-9]+]], ![[INT64_0_IN_BAR:[0-9]+]], ![[DOUBLE_1_IN_BAR:[0-9]+]], ![[INT32_2_IN_BAR:[0-9]+]], ![[STRUCT_3_IN_BAR:[0-9]+]], ![[CORO_INDEX_IN_BAR:[0-9]+]]
+; CHECK-DAG: ![[ELEMENTS_IN_BAR]] = !{![[RESUME_FN_IN_BAR:[0-9]+]], ![[DESTROY_FN_IN_BAR:[0-9]+]], ![[PROMISE_IN_BAR:[0-9]+]], ![[VECTOR_TYPE_IN_BAR:[0-9]+]], ![[INT64_IN_BAR:[0-9]+]], ![[DOUBLE_IN_BAR:[0-9]+]], ![[INT64_PTR_IN_BAR:[0-9]+]], ![[INT32_IN_BAR:[0-9]+]], ![[STRUCT_IN_BAR:[0-9]+]], ![[CORO_INDEX_IN_BAR:[0-9]+]]
 ; CHECK-DAG: ![[PROMISE_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "__promise",{{.*}}baseType: ![[PROMISE_BASE]]
-; CHECK-DAG: ![[INT64_0_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_64_0", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[I64_BASE]]
-; CHECK-DAG: ![[DOUBLE_1_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "__double__1", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[DOUBLE_BASE]]
-; CHECK-DAG: ![[INT32_2_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_32_2", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[I32_BASE]]
-; CHECK-DAG: ![[STRUCT_3_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "struct_big_structure_3", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[STRUCT_BASE_IN_BAR:[0-9]+]]
+; CHECK-DAG: ![[VECTOR_TYPE_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "_0", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[VECTOR_TYPE_BASE]]
+; CHECK-DAG: ![[INT64_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_64_1", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[I64_BASE]]
+; CHECK-DAG: ![[DOUBLE_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "__double__2", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[DOUBLE_BASE]]
+; CHECK-DAG: ![[INT64_PTR_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_64_Ptr_3", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[INT64_PTR_BASE]]
+; CHECK-DAG: ![[INT32_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "__int_32_4", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[I32_BASE]]
+; CHECK-DAG: ![[STRUCT_IN_BAR]] = !DIDerivedType(tag: DW_TAG_member, name: "struct_big_structure_5", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]], baseType: ![[STRUCT_BASE_IN_BAR:[0-9]+]]
 ; CHECK-DAG: ![[STRUCT_BASE_IN_BAR]] = !DICompositeType(tag: DW_TAG_structure_type, name: "struct_big_structure", scope: ![[FRAME_TYPE_IN_BAR]], file: ![[FILE]], line: [[BAR_LINE]],{{.*}}
 ; CHECK-DAG: ![[CORO_FRAME_IN_RESUME]] = !DILocalVariable(name: "__coro_frame",{{.*}}type: ![[FRAME_TYPE]]
 
 
 %promise_type = type { i32, i32, double }
 %struct.big_structure = type { [500 x i8] }
 declare void @produce(%struct.big_structure*)
 declare void @consume(%struct.big_structure*)
+declare void @produce_vector(<4 x i32> *)
+declare void @consume_vector(<4 x i32> *)
+declare void @produce_vectori5(<5 x i1> *)
+declare void @consume_vectori5(<5 x i1> *)
+declare void @produce_vectori9(<9 x i1> *)
+declare void @consume_vectori9(<9 x i1> *)
 declare void @pi32(i32*)
 declare void @pi64(i64*)
 declare void @pdouble(double*)
+declare void @pi64p(i64**)
 
-define void @f(i32 %a, i32 %b, i64 %c, double %d) presplitcoroutine !dbg !8 {
+define void @f(i32 %a, i32 %b, i64 %c, double %d, i64* %e) presplitcoroutine !dbg !8 {
 entry:
     %__promise = alloca %promise_type, align 8
     %0 = bitcast %promise_type* %__promise to i8*
     %a.alloc = alloca i32, align 4
     %b.alloc = alloca i32, align 4
     %c.alloc = alloca i64, align 4
     %d.alloc = alloca double, align 4
+    %e.alloc = alloca i64*, align 4
     store i32 %a, i32* %a.alloc
     store i32 %b, i32* %b.alloc
     store i64 %c, i64* %c.alloc
     store double %d, double* %d.alloc
+    store i64* %e, i64** %e.alloc
     %struct.data = alloca %struct.big_structure, align 1
     call void @produce(%struct.big_structure* %struct.data)
+    ; We treat vector type as unresolved type now for test coverage.
+    %unresolved_data = alloca <4 x i32>
+    call void @produce_vector(<4 x i32> *%unresolved_data)
+    %unresolved_data2 = alloca <5 x i1>
+    call void @produce_vectori5(<5 x i1> *%unresolved_data2)
+    %unresolved_data3 = alloca <9 x i1>
+    call void @produce_vectori9(<9 x i1> *%unresolved_data3)
     %id = call token @llvm.coro.id(i32 16, i8* %0, i8* null, i8* null)
     %alloc = call i1 @llvm.coro.alloc(token %id)
     br i1 %alloc, label %coro.alloc, label %coro.init
 
 coro.alloc:                                       ; preds = %entry
     %size = call i64 @llvm.coro.size.i64()
     %memory = call i8* @new(i64 %size)
     br label %coro.init
await.ready:                                      ; preds = %await.suspend, %init.ready
     call void @await_resume()
     %i.i = getelementptr inbounds %promise_type, %promise_type* %__promise, i64 0, i32 0
     store i32 1, i32* %i.i, align 8
     %j.i = getelementptr inbounds %promise_type, %promise_type* %__promise, i64 0, i32 1
     store i32 2, i32* %j.i, align 4
     %k.i = getelementptr inbounds %promise_type, %promise_type* %__promise, i64 0, i32 2
     store double 3.000000e+00, double* %k.i, align 8
     call void @consume(%struct.big_structure* %struct.data)
+    call void @consume_vector(<4 x i32> *%unresolved_data)
+    call void @consume_vectori5(<5 x i1> *%unresolved_data2)
+    call void @consume_vectori9(<9 x i1> *%unresolved_data3)
     call void @pi32(i32* %a.alloc)
     call void @pi32(i32* %b.alloc)
     call void @pi64(i64* %c.alloc)
     call void @pdouble(double* %d.alloc)
+    call void @pi64p(i64** %e.alloc)
     call void @return_void()
     br label %coro.final
 
 coro.final:                                       ; preds = %await.ready
     call void @final_suspend()
     %coro.final.await_ready = call i1 @await_ready()
     br i1 %coro.final.await_ready, label %final.ready, label %final.suspend
 
coro.ret:                                         ; preds = %cleanup.cont, %after.coro.free, %final.suspend, %await.suspend, %init.suspend
     %end = call i1 @llvm.coro.end(i8* null, i1 false)
     ret void
 
 unreachable:                                      ; preds = %after.coro.free
     unreachable
 
 }
 
-define void @bar(i32 %a, i64 %c, double %d) presplitcoroutine !dbg !19 {
+; bar is used to check that we wouldn't create duplicate DIType
+define void @bar(i32 %a, i64 %c, double %d, i64* %e) presplitcoroutine !dbg !19 {
 entry:
     %__promise = alloca %promise_type, align 8
     %0 = bitcast %promise_type* %__promise to i8*
     %a.alloc = alloca i32, align 4
     %c.alloc = alloca i64, align 4
     %d.alloc = alloca double, align 4
+    %e.alloc = alloca i64*, align 4
     store i32 %a, i32* %a.alloc
     store i64 %c, i64* %c.alloc
     store double %d, double* %d.alloc
+    store i64* %e, i64** %e.alloc
     %struct.data = alloca %struct.big_structure, align 1
     call void @produce(%struct.big_structure* %struct.data)
+    ; We treat vector type as unresolved type now for test coverage.
+    %unresolved_data = alloca <4 x i32>
+    call void @produce_vector(<4 x i32> *%unresolved_data)
     %id = call token @llvm.coro.id(i32 16, i8* %0, i8* null, i8* null)
     %alloc = call i1 @llvm.coro.alloc(token %id)
     br i1 %alloc, label %coro.alloc, label %coro.init
 
 coro.alloc:                                       ; preds = %entry
     %size = call i64 @llvm.coro.size.i64()
     %memory = call i8* @new(i64 %size)
     br label %coro.init
switch i8 %suspend.again, label %coro.ret [
         i8 1, label %await.cleanup
     ]
 
 await.cleanup:                                    ; preds = %await.suspend
     br label %cleanup
 
 await.ready:                                      ; preds = %await.suspend, %init.ready
     call void @await_resume()
-     %i.i = getelementptr inbounds %promise_type, %promise_type* %__promise, i64 0, i32 0
     store i32 1, i32* %i.i, align 8
     %j.i = getelementptr inbounds %promise_type, %promise_type* %__promise, i64 0, i32 1
     store i32 2, i32* %j.i, align 4
     %k.i = getelementptr inbounds %promise_type, %promise_type* %__promise, i64 0, i32 2
     store double 3.000000e+00, double* %k.i, align 8
     call void @consume(%struct.big_structure* %struct.data)
+    call void @consume_vector(<4 x i32> *%unresolved_data)
     call void @pi32(i32* %a.alloc)
     call void @pi64(i64* %c.alloc)
     call void @pdouble(double* %d.alloc)
+    call void @pi64p(i64** %e.alloc)
     call void @return_void()
     br label %coro.final
 
 coro.final:                                       ; preds = %await.ready
     call void @final_suspend()
     %coro.final.await_ready = call i1 @await_ready()
     br i1 %coro.final.await_ready, label %final.ready, label %final.suspend
 

 !15 = !DIDerivedType(tag: DW_TAG_member, name: "k", scope: !8, file: !1, line: 10, baseType: !17, size: 64, offset: 64)
 !16 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
 !17 = !DIBasicType(name: "double", size: 64, encoding: DW_ATE_float)
 !18 = !DILocation(line: 8, scope: !7)
 !19 = distinct !DISubprogram(name: "bar", linkageName: "_Z3barv", scope: !19, file: !1, line: 54, type: !9, scopeLine: 54, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: !0, retainedNodes: !2)
 !20 = distinct !DILexicalBlock(scope: !19, file: !1, line: 23, column: 12)
 !21 = !DILocalVariable(name: "__promise", scope: !20, file: !1, line: 55, type: !10)
 !22 = !DILocation(line: 10, scope: !20)
-
-
-
-
-
-