This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [ELF] Add parentheses to silence a GCC warning. NFC.
ClosedPublic

Authored by mstorsjo on Jun 9 2022, 4:41 AM.

Details

Summary

This silences the following warning:

../tools/lld/ELF/SyntheticSections.cpp:1596:48: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
1596 | assert((index != 0 || type != target->gotRel && type != target->pltRel ||

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 9 2022, 4:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2022, 4:41 AM
mstorsjo requested review of this revision.Jun 9 2022, 4:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2022, 4:42 AM
MaskRay accepted this revision.Jun 9 2022, 12:25 PM
This revision is now accepted and ready to land.Jun 9 2022, 12:25 PM
This revision was landed with ongoing or failed builds.Jun 9 2022, 12:32 PM
This revision was automatically updated to reflect the committed changes.