This is an archive of the discontinued LLVM Phabricator instance.

[llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits
ClosedPublic

Authored by steakhal on Jun 1 2022, 11:55 AM.

Diff Detail

Event Timeline

steakhal created this revision.Jun 1 2022, 11:55 AM
Herald added a project: Restricted Project. · View Herald Transcript
steakhal requested review of this revision.Jun 1 2022, 11:55 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 1 2022, 11:55 AM
martong accepted this revision.Jun 2 2022, 3:01 AM

LGTM!

This revision is now accepted and ready to land.Jun 2 2022, 3:01 AM
bzcheeseman added inline comments.Jun 2 2022, 7:56 AM
llvm/include/llvm/ADT/FoldingSet.h
260

supernit: I generally prefer named template parameters - can call it something like Enable?

834

supernit - the default type of std::enable_if_t is void so you don't need to specify it :)

steakhal updated this revision to Diff 433791.Jun 2 2022, 10:33 AM
steakhal marked 2 inline comments as done.
  • Named SFINAE type parameter.
  • Using default return value of enable_if_t
llvm/include/llvm/ADT/FoldingSet.h
260

Thanks!

834

Awesome!

This revision was landed with ongoing or failed builds.Jun 2 2022, 10:54 AM
This revision was automatically updated to reflect the committed changes.