This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Change GPRPF64's hwmode and spill alignment
AcceptedPublic

Authored by StephenFan on May 30 2022, 7:30 AM.

Details

Summary

GPRPF64 is only available when zdinx enabled on RV32.
GPRPF64 is composed of two GPR register, therefore the
spill alignment value should be consistent with GPR,
which is 32 bits in RV32.

Diff Detail

Event Timeline

StephenFan created this revision.May 30 2022, 7:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2022, 7:30 AM
StephenFan requested review of this revision.May 30 2022, 7:30 AM
This revision is now accepted and ready to land.May 30 2022, 8:20 PM
asb added a comment.Jun 20 2022, 3:09 AM

I'm a little nervous something may subtly break here (e.g. due to an assumption that any spilled f64 value will always be stored properly aligned). I note AFGR64 on Mips and IntPair on Sparc for instance both have 64-bit alignment. That's just a gut feeling though - I don't have a particular broken test case in mind. Have you explored this kind of potential problem?