[BOLT][DWARF] Convert dwarf5-df-* tests to assembly tests

[ayermolo]

bolt/test/X86/dwarf5-df-dualcu.test

4–7

Can you change so that input is assembly directly?

[zr33]

start from assembly input

[zr33]

start from assembly input.

[ayermolo]

Please update the title with [BOLT][DWARF] <title>

[zr33]

convert dwarf5-df-* tests to be assembly test

[zr33]

add one test

[zr33]

format.

[zr33]

format

[zr33]

update commit range

[ayermolo]

bolt/test/X86/Inputs/dwarf4-df-dualcu-main.ll

1 ↗

(On Diff #431111)

Please add the these comments on how file was generated to .s equivalent.

[zr33]

add comments indicate how to generate .s files

[zr33]

add comments

[zr33]

add comments

[zr33]

add comments

[zr33]

add comments

[ayermolo]

bolt/test/X86/dwarf5-locaddrx.test

86 ↗

(On Diff #431169)

This part is missing in the assembly file.

[zr33]

• add a missing comment

[zr33]

• add a missing comment

bolt/test/X86/Inputs/dwarf4-df-dualcu-helper.s

+# clang++ -g -gdwarf-4 -emit-llvm -S helper.cpp
+# llc -O0 -mtriple=x86_64-unknown-linux-gnu helper.ll
+# int z = 0;
+# int d = 0;
+#
+# int helper(int z_, int d_) {
+#  z += z_;
+#  d += d_;
+#  return z * d;
+# }
+
   .text
   .file "helper.cpp"
   .file 1 "." "helper.cpp"
   .globl  _Z6helperii                     # -- Begin function _Z6helperii
   .p2align  4, 0x90
   .type _Z6helperii,@function
 _Z6helperii:                            # @_Z6helperii
 .Lfunc_begin0:

bolt/test/X86/Inputs/dwarf4-df-dualcu-loclist-helper.s

+# clang++ -g -gdwarf-4 -emit-llvm -S helper.cpp
+# llc -O2 -mtriple=x86_64-unknown-linux-gnu helper.ll
+# int z = 0;
+# int d = 0;
+#
+# int helper(int z_, int d_) {
+#  z += z_;
+#  d += d_;
+#  return z * d;
+# }
+
   .text
   .file "helper.cpp"
   .file 1 "." "helper.cpp"
   .globl  _Z6helperii                     # -- Begin function _Z6helperii
   .p2align  4, 0x90
   .type _Z6helperii,@function
 _Z6helperii:                            # @_Z6helperii
 .Lfunc_begin0:

bolt/test/X86/Inputs/dwarf4-df-dualcu-loclist-main.s

+# clang++ -g -gdwarf-4 -emit-llvm -S main.cpp
+# llc -O2 -mtriple=x86_64-unknown-linux-gnu main.ll
+# void use(int * x, int * y) {
+# *x += 4;
+# *y -= 2;
+# }
+#
+# int helper(int z_, int d_);
+# int x = 0;
+# int y = 1;
+# int  main(int argc, char *argv[]) {
+#    x = argc;
+#    y = argc + 3;
+#    use(&x, &y);
+#    return helper(x, y);
+# }
+
   .text
   .file "main.cpp"
   .file 1 "." "main.cpp"
   .globl  _Z3usePiS_                      # -- Begin function _Z3usePiS_
   .p2align  4, 0x90
   .type _Z3usePiS_,@function
 _Z3usePiS_:                             # @_Z3usePiS_
 .Lfunc_begin0:

bolt/test/X86/Inputs/dwarf4-df-dualcu-main.s

+# clang++ -g -gdwarf-4 -emit-llvm -S main.cpp
+# llc -O0 -mtriple=x86_64-unknown-linux-gnu main.ll
+# void use(int * x, int * y) {
+# *x += 4;
+# *y -= 2;
+# }
+#
+# int helper(int z_, int d_);
+# int x = 0;
+# int y = 1;
+# int  main(int argc, char *argv[]) {
+#    x = argc;
+#    y = argc + 3;
+#    use(&x, &y);
+#    return helper(x, y);
+# }
+
   .text
   .file "main.cpp"
   .file 1 "." "main.cpp"
   .globl  _Z3usePiS_                      # -- Begin function _Z3usePiS_
   .p2align  4, 0x90
   .type _Z3usePiS_,@function
 _Z3usePiS_:                             # @_Z3usePiS_
 .Lfunc_begin0:

bolt/test/X86/Inputs/dwarf5-df-dualcu-helper.s

+# clang++ -g -gdwarf-5 -emit-llvm -S helper.cpp
+# llc -O0 -mtriple=x86_64-unknown-linux-gnu helper.ll
+# int z = 0;
+# int d = 0;
+#
+# int helper(int z_, int d_) {
+#  z += z_;
+#  d += d_;
+#  return z * d;
+# }
+
   .text
   .file "helper.cpp"
   .file 0 "." "helper.cpp" md5 0xe635924a35b65444173d0c76a54b866f
   .globl  _Z6helperii                     # -- Begin function _Z6helperii
   .p2align  4, 0x90
   .type _Z6helperii,@function
 _Z6helperii:                            # @_Z6helperii
 .Lfunc_begin0:

bolt/test/X86/Inputs/dwarf5-df-dualcu-loclist-helper.s

+# clang++ -g -gdwarf-5 -emit-llvm -S helper.cpp
+# llc -O2 -mtriple=x86_64-unknown-linux-gnu helper.ll
+# int z = 0;
+# int d = 0;
+#
+# int helper(int z_, int d_) {
+#  z += z_;
+#  d += d_;
+#  return z * d;
+# }
+
   .text
   .file "helper.cpp"
   .file 0 "." "helper.cpp" md5 0xe635924a35b65444173d0c76a54b866f
   .globl  _Z6helperii                     # -- Begin function _Z6helperii
   .p2align  4, 0x90
   .type _Z6helperii,@function
 _Z6helperii:                            # @_Z6helperii
 .Lfunc_begin0:

bolt/test/X86/Inputs/dwarf5-df-dualcu-loclist-main.s

+# clang++ -g -gdwarf-5 -emit-llvm -S main.cpp
+# llc -O2 -mtriple=x86_64-unknown-linux-gnu main.ll
+# void use(int * x, int * y) {
+# *x += 4;
+# *y -= 2;
+# }
+#
+# int helper(int z_, int d_);
+# int x = 0;
+# int y = 1;
+# int  main(int argc, char *argv[]) {
+#    x = argc;
+#    y = argc + 3;
+#    use(&x, &y);
+#    return helper(x, y);
+# }
+
   .text
   .file "main.cpp"
   .file 0 "." "main.cpp" md5 0x1f627913a0daee879e00a3a51726f0ef
   .globl  _Z3usePiS_                      # -- Begin function _Z3usePiS_
   .p2align  4, 0x90
   .type _Z3usePiS_,@function
 _Z3usePiS_:                             # @_Z3usePiS_
 .Lfunc_begin0:

bolt/test/X86/Inputs/dwarf5-df-dualcu-main.s

+# clang++ -g -gdwarf-5 -emit-llvm -S main.cpp
+# llc -O0 -mtriple=x86_64-unknown-linux-gnu main.ll
+# void use(int * x, int * y) {
+# *x += 4;
+# *y -= 2;
+# }
+#
+# int helper(int z_, int d_);
+# int x = 0;
+# int y = 1;
+# int  main(int argc, char *argv[]) {
+#    x = argc;
+#    y = argc + 3;
+#    use(&x, &y);
+#    return helper(x, y);
+# }
+
   .text
   .file "main.cpp"
   .file 0 "." "main.cpp" md5 0x1f627913a0daee879e00a3a51726f0ef
   .globl  _Z3usePiS_                      # -- Begin function _Z3usePiS_
   .p2align  4, 0x90
   .type _Z3usePiS_,@function
 _Z3usePiS_:                             # @_Z3usePiS_
 .Lfunc_begin0:

bolt/test/X86/Inputs/dwarf5-df-mono-helper.s

+# clang++ -g -gdwarf-5 -emit-llvm -S helper.cpp
+# llc -O0 -mtriple=x86_64-unknown-linux-gnu helper.ll
+# int z = 0;
+# int d = 0;
+#
+# int helper(int z_, int d_) {
+#  z += z_;
+#  d += d_;
+#  return z * d;
+# }
+
   .text
   .file "helper.cpp"
   .file 0 "." "helper.cpp" md5 0xe635924a35b65444173d0c76a54b866f
   .globl  _Z6helperii                     # -- Begin function _Z6helperii
   .p2align  4, 0x90
   .type _Z6helperii,@function
 _Z6helperii:                            # @_Z6helperii
 .Lfunc_begin0:

bolt/test/X86/Inputs/dwarf5-df-mono-main.s

+# clang++ -g -gdwarf-5 -gsplit-dwarf=split -emit-llvm -S  main.cpp
+# llc -O0 -mtriple=x86_64-unknown-linux-gnu main.ll
+# void use(int * x, int * y) {
+# *x += 4;
+# *y -= 2;
+# }
+#
+# int helper(int z_, int d_);
+# int x = 0;
+# int y = 1;
+# int  main(int argc, char *argv[]) {
+#    x = argc;
+#    y = argc + 3;
+#    use(&x, &y);
+#    return helper(x, y);
+# }
+
   .text
   .file "main.cpp"
   .file 0 "." "main.cpp" md5 0x1f627913a0daee879e00a3a51726f0ef
   .globl  _Z3usePiS_                      # -- Begin function _Z3usePiS_
   .p2align  4, 0x90
   .type _Z3usePiS_,@function
 _Z3usePiS_:                             # @_Z3usePiS_
 .Lfunc_begin0:

bolt/test/X86/dwarf5-df-dualcu.test

 ; RUN: rm -rf %t
 ; RUN: mkdir %t
 ; RUN: cd %t
 ; RUN: llvm-mc -dwarf-version=5 -filetype=obj -triple x86_64-unknown-linux %p/Inputs/dwarf5-df-dualcu-main.s \
 ; RUN: -split-dwarf-file=main.dwo -o main.o
 ; RUN: llvm-mc -dwarf-version=5 -filetype=obj -triple x86_64-unknown-linux %p/Inputs/dwarf5-df-dualcu-helper.s \
 ; RUN: -split-dwarf-file=helper.dwo -o helper.o
 ; RUN: %clang %cflags -gdwarf-5 -gsplit-dwarf=split main.o helper.o -o main.exe
 ; RUN: llvm-bolt main.exe -o main.exe.bolt --update-debug-sections
 ; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.exe | FileCheck -check-prefix=PRE-BOLT %s
 ; RUN: llvm-dwarfdump --show-form --verbose --debug-addr main.exe.bolt &> %t/foo.txt
 ; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.exe.bolt >> %t/foo.txt
 ; RUN: cat %t/foo.txt | FileCheck -check-prefix=BOLT %s
 ; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.dwo | FileCheck -check-prefix=PRE-BOLT-DWO-MAIN %s
 ; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.dwo.dwo | FileCheck -check-prefix=BOLT-DWO-MAIN %s

 ; BOLT-DWO-MAIN-NEXT: DW_AT_name [DW_FORM_strx1]  (indexed (00000004) string = "use")
 ; BOLT-DWO-MAIN: DW_TAG_subprogram [6]
 ; BOLT-DWO-MAIN-NEXT: DW_AT_low_pc [DW_FORM_addrx]  (indexed (00000003)
 ; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_rnglistx] (indexed (0x1) rangelist = 0x00000018
 ; BOLT-DWO-MAIN-NEXT: [0x0000000000000000, 0x0000000000000059))
 ; BOLT-DWO-MAIN-NEXT: DW_AT_frame_base [DW_FORM_exprloc]  (DW_OP_reg6 RBP)
 ; BOLT-DWO-MAIN-NEXT: DW_AT_name [DW_FORM_strx1]  (indexed (00000005) string = "main")
 
-
 ; PRE-BOLT-DWO-HELPER: version = 0x0005
 ; PRE-BOLT-DWO-HELPER: DW_TAG_variable [2]
 ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_name [DW_FORM_strx1]  (indexed (00000000) string = "z")
 ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_type
 ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_external
 ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_decl_file
 ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_decl_line
 ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_location [DW_FORM_exprloc]  (DW_OP_addrx 0x0)