This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF] Convert dwarf5-df-* tests to assembly tests
ClosedPublic

Authored by zr33 on May 20 2022, 12:38 PM.

Diff Detail

Event Timeline

zr33 created this revision.May 20 2022, 12:38 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
zr33 requested review of this revision.May 20 2022, 12:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 12:38 PM
ayermolo added inline comments.May 20 2022, 12:57 PM
bolt/test/X86/dwarf5-df-dualcu.test
3–7

Can you change so that input is assembly directly?

zr33 updated this revision to Diff 431072.May 20 2022, 3:26 PM

start from assembly input

zr33 updated this revision to Diff 431080.May 20 2022, 3:44 PM

start from assembly input.

Please update the title with [BOLT][DWARF] <title>

zr33 retitled this revision from make it a assembly test to [BOLT][DWARF] make tests a assembly test.May 20 2022, 4:12 PM
zr33 updated this revision to Diff 431098.May 20 2022, 5:00 PM
zr33 marked an inline comment as done.

convert dwarf5-df-* tests to be assembly test

zr33 retitled this revision from [BOLT][DWARF] make tests a assembly test to [BOLT][DWARF] Convert dwarf5-df-* tests to assembly tests.May 20 2022, 5:01 PM
zr33 updated this revision to Diff 431108.May 20 2022, 6:14 PM

add one test

zr33 updated this revision to Diff 431109.May 20 2022, 6:17 PM

format.

zr33 updated this revision to Diff 431111.May 20 2022, 6:30 PM

update commit range

ayermolo added inline comments.May 21 2022, 7:13 AM
bolt/test/X86/Inputs/dwarf4-df-dualcu-main.ll
1 ↗(On Diff #431111)

Please add the these comments on how file was generated to .s equivalent.

zr33 updated this revision to Diff 431160.May 21 2022, 12:10 PM

add comments indicate how to generate .s files

zr33 updated this revision to Diff 431165.May 21 2022, 12:16 PM

add comments

zr33 updated this revision to Diff 431166.May 21 2022, 12:19 PM

add comments

zr33 updated this revision to Diff 431167.May 21 2022, 12:20 PM

add comments

zr33 updated this revision to Diff 431169.May 21 2022, 12:22 PM

add comments

yota9 removed a subscriber: yota9.May 21 2022, 12:23 PM
ayermolo added inline comments.May 23 2022, 8:35 AM
bolt/test/X86/dwarf5-locaddrx.test
86 ↗(On Diff #431169)

This part is missing in the assembly file.

zr33 updated this revision to Diff 431407.May 23 2022, 9:47 AM
  • add a missing comment
zr33 updated this revision to Diff 431409.May 23 2022, 9:50 AM
  • add a missing comment
ayermolo accepted this revision.May 23 2022, 11:17 AM
This revision is now accepted and ready to land.May 23 2022, 11:17 AM
This revision was automatically updated to reflect the committed changes.