This is an archive of the discontinued LLVM Phabricator instance.

Differential D126086

[BOLT][DWARF] Convert dwarf5-df-* tests to assembly tests
ClosedPublic

Authored by zr33 on May 20 2022, 12:38 PM.

Details

Reviewers
rafauler
Amir
maksfb
ayermolo
jdoerfert
Commits
rGe51a6b7374ca: [BOLT][DWARF] Convert dwarf5-df-* tests to assembly tests

Diff Detail

Event Timeline

zr33 created this revision.May 20 2022, 12:38 PM
Herald added a reviewer: rafauler. · View Herald TranscriptMay 20 2022, 12:38 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
zr33 requested review of this revision.May 20 2022, 12:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 12:38 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
zr33 added a reviewer: ayermolo.May 20 2022, 12:39 PM
Harbormaster completed remote builds in B165565: Diff 431027.May 20 2022, 12:44 PM
ayermolo added inline comments.May 20 2022, 12:57 PM
bolt/test/X86/dwarf5-df-dualcu.test
4–7

Can you change so that input is assembly directly?

zr33 updated this revision to Diff 431072.May 20 2022, 3:26 PM

start from assembly input

Herald added a reviewer: jdoerfert. · View Herald TranscriptMay 20 2022, 3:26 PM
Herald added a subscriber: sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B165599: Diff 431072.May 20 2022, 3:27 PM
zr33 updated this revision to Diff 431080.May 20 2022, 3:44 PM

start from assembly input.

Harbormaster completed remote builds in B165603: Diff 431080.May 20 2022, 3:49 PM
ayermolo added a comment.May 20 2022, 4:03 PM

Please update the title with [BOLT][DWARF] <title>

zr33 retitled this revision from make it a assembly test to [BOLT][DWARF] make tests a assembly test.May 20 2022, 4:12 PM
zr33 updated this revision to Diff 431098.May 20 2022, 5:00 PM
zr33 marked an inline comment as done.

convert dwarf5-df-* tests to be assembly test

zr33 retitled this revision from [BOLT][DWARF] make tests a assembly test to [BOLT][DWARF] Convert dwarf5-df-* tests to assembly tests.May 20 2022, 5:01 PM
Harbormaster completed remote builds in B165620: Diff 431098.May 20 2022, 5:05 PM
zr33 updated this revision to Diff 431108.May 20 2022, 6:14 PM

add one test

zr33 updated this revision to Diff 431109.May 20 2022, 6:17 PM

format.

zr33 updated this revision to Diff 431110.May 20 2022, 6:19 PM

format

Harbormaster completed remote builds in B165630: Diff 431110.May 20 2022, 6:24 PM
zr33 updated this revision to Diff 431111.May 20 2022, 6:30 PM

update commit range

Harbormaster completed remote builds in B165631: Diff 431111.May 20 2022, 6:35 PM
ayermolo added inline comments.May 21 2022, 7:13 AM
bolt/test/X86/Inputs/dwarf4-df-dualcu-main.ll
1 ↗(On Diff #431111)

Please add the these comments on how file was generated to .s equivalent.

zr33 updated this revision to Diff 431160.May 21 2022, 12:10 PM

add comments indicate how to generate .s files

Harbormaster completed remote builds in B165670: Diff 431160.May 21 2022, 12:10 PM
zr33 updated this revision to Diff 431165.May 21 2022, 12:16 PM

add comments

Harbormaster completed remote builds in B165676: Diff 431165.May 21 2022, 12:16 PM
zr33 updated this revision to Diff 431166.May 21 2022, 12:19 PM

add comments

Harbormaster completed remote builds in B165677: Diff 431166.May 21 2022, 12:19 PM
zr33 updated this revision to Diff 431167.May 21 2022, 12:20 PM

add comments

Harbormaster completed remote builds in B165678: Diff 431167.May 21 2022, 12:21 PM
zr33 updated this revision to Diff 431169.May 21 2022, 12:22 PM

add comments

yota9 removed a subscriber: yota9.May 21 2022, 12:23 PM
Harbormaster completed remote builds in B165680: Diff 431169.May 21 2022, 12:34 PM
ayermolo added inline comments.May 23 2022, 8:35 AM
bolt/test/X86/dwarf5-locaddrx.test
86 ↗(On Diff #431169)

This part is missing in the assembly file.

zr33 updated this revision to Diff 431407.May 23 2022, 9:47 AM
  • add a missing comment
zr33 updated this revision to Diff 431409.May 23 2022, 9:50 AM
  • add a missing comment
Harbormaster completed remote builds in B165868: Diff 431409.May 23 2022, 9:55 AM
ayermolo accepted this revision.May 23 2022, 11:17 AM
This revision is now accepted and ready to land.May 23 2022, 11:17 AM
Closed by commit rGe51a6b7374ca: [BOLT][DWARF] Convert dwarf5-df-* tests to assembly tests (authored by zr33, committed by ayermolo). · Explain WhyMay 25 2022, 1:41 PM
This revision was automatically updated to reflect the committed changes.
ayermolo added a commit: rGe51a6b7374ca: [BOLT][DWARF] Convert dwarf5-df-* tests to assembly tests.

Revision Contents

PathSize
bolt/
test/
X86/
1 line

Diff 431110

bolt/test/X86/dwarf5-df-dualcu.test

; RUN: rm -rf %t ; RUN: rm -rf %t
; RUN: mkdir %t ; RUN: mkdir %t
; RUN: cd %t ; RUN: cd %t
; RUN: llvm-mc -dwarf-version=5 -filetype=obj -triple x86_64-unknown-linux %p/Inputs/dwarf5-df-dualcu-main.s \ ; RUN: llvm-mc -dwarf-version=5 -filetype=obj -triple x86_64-unknown-linux %p/Inputs/dwarf5-df-dualcu-main.s \
; RUN: -split-dwarf-file=main.dwo -o main.o ; RUN: -split-dwarf-file=main.dwo -o main.o
; RUN: llvm-mc -dwarf-version=5 -filetype=obj -triple x86_64-unknown-linux %p/Inputs/dwarf5-df-dualcu-helper.s \ ; RUN: llvm-mc -dwarf-version=5 -filetype=obj -triple x86_64-unknown-linux %p/Inputs/dwarf5-df-dualcu-helper.s \
; RUN: -split-dwarf-file=helper.dwo -o helper.o ; RUN: -split-dwarf-file=helper.dwo -o helper.o
ayermoloUnsubmitted
Done
ReplyInline Actions

Can you change so that input is assembly directly?

ayermolo: Can you change so that input is assembly directly?
; RUN: %clang %cflags -gdwarf-5 -gsplit-dwarf=split main.o helper.o -o main.exe ; RUN: %clang %cflags -gdwarf-5 -gsplit-dwarf=split main.o helper.o -o main.exe
; RUN: llvm-bolt main.exe -o main.exe.bolt --update-debug-sections ; RUN: llvm-bolt main.exe -o main.exe.bolt --update-debug-sections
; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.exe | FileCheck -check-prefix=PRE-BOLT %s ; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.exe | FileCheck -check-prefix=PRE-BOLT %s
; RUN: llvm-dwarfdump --show-form --verbose --debug-addr main.exe.bolt &> %t/foo.txt ; RUN: llvm-dwarfdump --show-form --verbose --debug-addr main.exe.bolt &> %t/foo.txt
; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.exe.bolt >> %t/foo.txt ; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.exe.bolt >> %t/foo.txt
; RUN: cat %t/foo.txt | FileCheck -check-prefix=BOLT %s ; RUN: cat %t/foo.txt | FileCheck -check-prefix=BOLT %s
; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.dwo | FileCheck -check-prefix=PRE-BOLT-DWO-MAIN %s ; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.dwo | FileCheck -check-prefix=PRE-BOLT-DWO-MAIN %s
; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.dwo.dwo | FileCheck -check-prefix=BOLT-DWO-MAIN %s ; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.dwo.dwo | FileCheck -check-prefix=BOLT-DWO-MAIN %s
▲ Show 20 Lines • Show All 90 Lines • ▼ Show 20 Lines
; BOLT-DWO-MAIN-NEXT: DW_AT_name [DW_FORM_strx1] (indexed (00000004) string = "use") ; BOLT-DWO-MAIN-NEXT: DW_AT_name [DW_FORM_strx1] (indexed (00000004) string = "use")
; BOLT-DWO-MAIN: DW_TAG_subprogram [6] ; BOLT-DWO-MAIN: DW_TAG_subprogram [6]
; BOLT-DWO-MAIN-NEXT: DW_AT_low_pc [DW_FORM_addrx] (indexed (00000003) ; BOLT-DWO-MAIN-NEXT: DW_AT_low_pc [DW_FORM_addrx] (indexed (00000003)
; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_rnglistx] (indexed (0x1) rangelist = 0x00000018 ; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_rnglistx] (indexed (0x1) rangelist = 0x00000018
; BOLT-DWO-MAIN-NEXT: [0x0000000000000000, 0x0000000000000059)) ; BOLT-DWO-MAIN-NEXT: [0x0000000000000000, 0x0000000000000059))
; BOLT-DWO-MAIN-NEXT: DW_AT_frame_base [DW_FORM_exprloc] (DW_OP_reg6 RBP) ; BOLT-DWO-MAIN-NEXT: DW_AT_frame_base [DW_FORM_exprloc] (DW_OP_reg6 RBP)
; BOLT-DWO-MAIN-NEXT: DW_AT_name [DW_FORM_strx1] (indexed (00000005) string = "main") ; BOLT-DWO-MAIN-NEXT: DW_AT_name [DW_FORM_strx1] (indexed (00000005) string = "main")
; PRE-BOLT-DWO-HELPER: version = 0x0005 ; PRE-BOLT-DWO-HELPER: version = 0x0005
; PRE-BOLT-DWO-HELPER: DW_TAG_variable [2] ; PRE-BOLT-DWO-HELPER: DW_TAG_variable [2]
; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_name [DW_FORM_strx1] (indexed (00000000) string = "z") ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_name [DW_FORM_strx1] (indexed (00000000) string = "z")
; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_type ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_type
; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_external ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_external
; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_decl_file ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_decl_file
; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_decl_line ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_decl_line
; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_location [DW_FORM_exprloc] (DW_OP_addrx 0x0) ; PRE-BOLT-DWO-HELPER-NEXT: DW_AT_location [DW_FORM_exprloc] (DW_OP_addrx 0x0)
Show All 30 Lines