This is an archive of the discontinued LLVM Phabricator instance.

Differential D125893

[RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr
ClosedPublic

Authored by kito-cheng on May 18 2022, 8:21 AM.

Details

Reviewers
khchen
reames
Commits
rGb166aa833e44: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr
Summary

This NFC patch is splited from D111617.

Using llvm::ArrayRef rather than llvm::SmallVector, ArrayRef is more generic
interface that could accept both llvm::ArrayRef and llvm::SmallVector.

Diff Detail

Unit TestsFailed

TimeTest
1,360 msx64 debian > libFuzzer.libFuzzer::merge_two_step.test

Event Timeline

kito-cheng created this revision.May 18 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 8:21 AM
Herald added subscribers: sunshaoce, VincentWu, luke957 and 27 others. · View Herald Transcript
kito-cheng requested review of this revision.May 18 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 8:21 AM
Herald added subscribers: cfe-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
kito-cheng updated this revision to Diff 430390.May 18 2022, 8:25 AM

Changes:

  • Fix dumb typo...
kito-cheng updated this revision to Diff 430391.May 18 2022, 8:30 AM

Changes:

  • clang-format has applied on unexpected part, remove that.
Harbormaster completed remote builds in B165135: Diff 430391.May 18 2022, 9:02 AM
craig.topper added a subscriber: craig.topper.May 18 2022, 3:06 PM
craig.topper added inline comments.
clang/include/clang/Support/RISCVVIntrinsicUtils.h
345

Drop the const and the reference

kito-cheng updated this revision to Diff 430911.May 20 2022, 1:53 AM

Changes:

Harbormaster completed remote builds in B165488: Diff 430911.May 20 2022, 2:29 AM
reames accepted this revision.May 20 2022, 7:02 AM
reames added a subscriber: reames.

LGTM

This revision is now accepted and ready to land.May 20 2022, 7:02 AM
This revision was landed with ongoing or failed builds.May 24 2022, 2:24 AM
Closed by commit rGb166aa833e44: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr (authored by kito-cheng). · Explain Why
This revision was automatically updated to reflect the committed changes.
kito-cheng added a commit: rGb166aa833e44: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr.

Revision Contents

PathSize
clang/
include/
clang/
Support/
6 lines
lib/
Support/
2 lines

Diff 430911

clang/include/clang/Support/RISCVVIntrinsicUtils.h

Show First 20 Lines • Show All 334 Lines • ▼ Show 20 Linespublic:
unsigned getNF() const { return NF; } unsigned getNF() const { return NF; }
const std::vector<int64_t> &getIntrinsicTypes() const { const std::vector<int64_t> &getIntrinsicTypes() const {
return IntrinsicTypes; return IntrinsicTypes;
} }
// Return the type string for a BUILTIN() macro in Builtins.def. // Return the type string for a BUILTIN() macro in Builtins.def.
std::string getBuiltinTypeStr() const; std::string getBuiltinTypeStr() const;
static std::string getSuffixStr( static std::string
BasicType Type, int Log2LMUL, getSuffixStr(BasicType Type, int Log2LMUL,
const llvm::SmallVector<PrototypeDescriptor> &PrototypeDescriptors); llvm::ArrayRef<PrototypeDescriptor> PrototypeDescriptors);
craig.topperUnsubmitted
Not Done
ReplyInline Actions

Drop the const and the reference

craig.topper: Drop the `const` and the reference
}; };
} // end namespace RISCV } // end namespace RISCV
} // end namespace clang } // end namespace clang
#endif // CLANG_SUPPORT_RISCVVINTRINSICUTILS_H #endif // CLANG_SUPPORT_RISCVVINTRINSICUTILS_H

clang/lib/Support/RISCVVIntrinsicUtils.cpp

Show First 20 Lines • Show All 916 Lines • ▼ Show 20 Linesstd::string RVVIntrinsic::getBuiltinTypeStr() const {
for (const auto &T : InputTypes) { for (const auto &T : InputTypes) {
S += T->getBuiltinStr(); S += T->getBuiltinStr();
} }
return S; return S;
} }
std::string RVVIntrinsic::getSuffixStr( std::string RVVIntrinsic::getSuffixStr(
BasicType Type, int Log2LMUL, BasicType Type, int Log2LMUL,
const llvm::SmallVector<PrototypeDescriptor> &PrototypeDescriptors) { llvm::ArrayRef<PrototypeDescriptor> PrototypeDescriptors) {
SmallVector<std::string> SuffixStrs; SmallVector<std::string> SuffixStrs;
for (auto PD : PrototypeDescriptors) { for (auto PD : PrototypeDescriptors) {
auto T = RVVType::computeType(Type, Log2LMUL, PD); auto T = RVVType::computeType(Type, Log2LMUL, PD);
SuffixStrs.push_back(T.getValue()->getShortStr()); SuffixStrs.push_back(T.getValue()->getShortStr());
} }
return join(SuffixStrs, "_"); return join(SuffixStrs, "_");
} }
Show All 23 Lines