This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr
ClosedPublic

Authored by kito-cheng on May 18 2022, 8:21 AM.

Details

Summary

This NFC patch is splited from D111617.

Using llvm::ArrayRef rather than llvm::SmallVector, ArrayRef is more generic
interface that could accept both llvm::ArrayRef and llvm::SmallVector.

Diff Detail

Event Timeline

kito-cheng created this revision.May 18 2022, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 8:21 AM
kito-cheng requested review of this revision.May 18 2022, 8:21 AM

Changes:

  • Fix dumb typo...

Changes:

  • clang-format has applied on unexpected part, remove that.
craig.topper added inline comments.
clang/include/clang/Support/RISCVVIntrinsicUtils.h
345

Drop the const and the reference

Changes:

reames accepted this revision.May 20 2022, 7:02 AM
reames added a subscriber: reames.

LGTM

This revision is now accepted and ready to land.May 20 2022, 7:02 AM
This revision was landed with ongoing or failed builds.May 24 2022, 2:24 AM
This revision was automatically updated to reflect the committed changes.