This is an archive of the discontinued LLVM Phabricator instance.

Differential D125873

[asan] Add the FreeBSD AArch64 shadow offset to llvm
ClosedPublic

Authored by andrew on May 18 2022, 4:00 AM.

Details

Reviewers
vitalybuka
Group Reviewers
Restricted Project
Commits
rGe13bd2644edf: Add the FreeBSD AArch64 shadow offset to llvm
Summary

AArch64 has a larger address space than 64 but x86. Use the larger
shadow offset on FreeBSD AArch64.

Diff Detail

Event Timeline

andrew created this revision.May 18 2022, 4:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 4:00 AM
Herald added subscribers: pengfei, hiraditya, kristof.beyls and 3 others. · View Herald Transcript
andrew requested review of this revision.May 18 2022, 4:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 4:00 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
andrew added a parent revision: D125757: [asan] Add the FreeBSD AArch64 shadow offset.May 18 2022, 4:01 AM
andrew updated this revision to Diff 430323.May 18 2022, 4:23 AM

Enable the FreeBSD llvm asan test on AArch64

Harbormaster completed remote builds in B165085: Diff 430323.May 18 2022, 4:57 AM
andrew added a reviewer: Restricted Project.Jun 1 2022, 4:38 AM
Herald added subscribers: jsji, Enna1. · View Herald TranscriptJun 1 2022, 4:38 AM
andrew added a reviewer: vitalybuka.Jun 9 2022, 4:28 AM
vitalybuka accepted this revision.Jul 11 2022, 11:41 AM
This revision is now accepted and ready to land.Jul 11 2022, 11:41 AM
andrew mentioned this in D130063: [Driver] Enable sanitizers on FreeBSD AArch64.Jul 19 2022, 2:14 AM
This revision was landed with ongoing or failed builds.Jul 19 2022, 6:59 AM
Closed by commit rGe13bd2644edf: Add the FreeBSD AArch64 shadow offset to llvm (authored by andrew, committed by emaste). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGe13bd2644edf: Add the FreeBSD AArch64 shadow offset to llvm.
MaskRay mentioned this in rG92df59c83d0d: [Driver] Enable some sanitizers on FreeBSD AArch64.Jul 24 2022, 10:41 AM

Revision Contents

PathSize
llvm/
lib/
Transforms/
Instrumentation/
3 lines

Diff 430317

llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp

//===- AddressSanitizer.cpp - memory error detector -----------------------===// //===- AddressSanitizer.cpp - memory error detector -----------------------===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
static const uint64_t kPPC64_ShadowOffset64 = 1ULL << 44; static const uint64_t kPPC64_ShadowOffset64 = 1ULL << 44;
static const uint64_t kSystemZ_ShadowOffset64 = 1ULL << 52; static const uint64_t kSystemZ_ShadowOffset64 = 1ULL << 52;
static const uint64_t kMIPS32_ShadowOffset32 = 0x0aaa0000; static const uint64_t kMIPS32_ShadowOffset32 = 0x0aaa0000;
static const uint64_t kMIPS64_ShadowOffset64 = 1ULL << 37; static const uint64_t kMIPS64_ShadowOffset64 = 1ULL << 37;
static const uint64_t kAArch64_ShadowOffset64 = 1ULL << 36; static const uint64_t kAArch64_ShadowOffset64 = 1ULL << 36;
static const uint64_t kRISCV64_ShadowOffset64 = 0xd55550000; static const uint64_t kRISCV64_ShadowOffset64 = 0xd55550000;
static const uint64_t kFreeBSD_ShadowOffset32 = 1ULL << 30; static const uint64_t kFreeBSD_ShadowOffset32 = 1ULL << 30;
static const uint64_t kFreeBSD_ShadowOffset64 = 1ULL << 46; static const uint64_t kFreeBSD_ShadowOffset64 = 1ULL << 46;
static const uint64_t kFreeBSDAArch64_ShadowOffset64 = 1ULL << 47;
static const uint64_t kFreeBSDKasan_ShadowOffset64 = 0xdffff7c000000000; static const uint64_t kFreeBSDKasan_ShadowOffset64 = 0xdffff7c000000000;
static const uint64_t kNetBSD_ShadowOffset32 = 1ULL << 30; static const uint64_t kNetBSD_ShadowOffset32 = 1ULL << 30;
static const uint64_t kNetBSD_ShadowOffset64 = 1ULL << 46; static const uint64_t kNetBSD_ShadowOffset64 = 1ULL << 46;
static const uint64_t kNetBSDKasan_ShadowOffset64 = 0xdfff900000000000; static const uint64_t kNetBSDKasan_ShadowOffset64 = 0xdfff900000000000;
static const uint64_t kPS4_ShadowOffset64 = 1ULL << 40; static const uint64_t kPS4_ShadowOffset64 = 1ULL << 40;
static const uint64_t kWindowsShadowOffset32 = 3ULL << 28; static const uint64_t kWindowsShadowOffset32 = 3ULL << 28;
static const uint64_t kEmscriptenShadowOffset = 0; static const uint64_t kEmscriptenShadowOffset = 0;
▲ Show 20 Lines • Show All 396 Lines • ▼ Show 20 Lines if (LongSize == 32) {
// Fuchsia is always PIE, which means that the beginning of the address // Fuchsia is always PIE, which means that the beginning of the address
// space is always available. // space is always available.
if (IsFuchsia) if (IsFuchsia)
Mapping.Offset = 0; Mapping.Offset = 0;
else if (IsPPC64) else if (IsPPC64)
Mapping.Offset = kPPC64_ShadowOffset64; Mapping.Offset = kPPC64_ShadowOffset64;
else if (IsSystemZ) else if (IsSystemZ)
Mapping.Offset = kSystemZ_ShadowOffset64; Mapping.Offset = kSystemZ_ShadowOffset64;
else if (IsFreeBSD && IsAArch64)
Mapping.Offset = kFreeBSDAArch64_ShadowOffset64;
else if (IsFreeBSD && !IsMIPS64) { else if (IsFreeBSD && !IsMIPS64) {
if (IsKasan) if (IsKasan)
Mapping.Offset = kFreeBSDKasan_ShadowOffset64; Mapping.Offset = kFreeBSDKasan_ShadowOffset64;
else else
Mapping.Offset = kFreeBSD_ShadowOffset64; Mapping.Offset = kFreeBSD_ShadowOffset64;
} else if (IsNetBSD) { } else if (IsNetBSD) {
if (IsKasan) if (IsKasan)
Mapping.Offset = kNetBSDKasan_ShadowOffset64; Mapping.Offset = kNetBSDKasan_ShadowOffset64;
▲ Show 20 Lines • Show All 2,979 Lines • Show Last 20 Lines