This is an archive of the discontinued LLVM Phabricator instance.

[asan] Add the FreeBSD AArch64 shadow offset
ClosedPublic

Authored by andrew on May 17 2022, 3:30 AM.

Details

Reviewers
MaskRay
Group Reviewers
Restricted Project
Commits
rGb3c1442c6c0b: [compiler-rt] Add the FreeBSD AArch64 shadow offset
Summary

As with 64 bit x86 use an offset in middle of the address space scaled up to work with the full 48 bit space.

Diff Detail

Event Timeline

andrew created this revision.May 17 2022, 3:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 3:30 AM
andrew requested review of this revision.May 17 2022, 3:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 3:30 AM

Please add some description about what tests previously failed now work.

There is no change in any tests passing as no asan tests are run on FreeBSD AArch64. This is compiler-rt part of the change that is needed to support asan there. There is also D125756 for the common sanitizer parts, and an as yet unsubmitted changes to add the offset to llvm and enable the sanitizers in clang.

With these the only failing asan test is SanitizerCommon-asan-aarch64-FreeBSD :: print-stack-trace.cpp. This seems to be a broken test as it inlines a function but assumes the caller and inlined callee will have different addresses.

andrew edited the summary of this revision. (Show Details)May 18 2022, 3:29 AM
MaskRay accepted this revision.May 18 2022, 12:30 PM
This revision is now accepted and ready to land.May 18 2022, 12:30 PM
This revision was automatically updated to reflect the committed changes.