This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Addd FreeBSD arm64 sanitizer support

Authored by andrew on Feb 18 2020, 6:18 AM.


Group Reviewers
Restricted Project

Add support for asan, msan, and tsan on FreeBSD on aarch64.

Event Timeline

andrew created this revision.Feb 18 2020, 6:18 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptFeb 18 2020, 6:19 AM
andrew updated this revision to Diff 245152.Feb 18 2020, 6:50 AM
andrew marked an inline comment as done.

Remove unintended changes

andrew marked an inline comment as done.Feb 18 2020, 6:51 AM
andrew added inline comments.

This is from D49942

Looks like several independent patches, could you spit them, with descriptions explaining why existing values are not good enough?
Could you also add into description test names which switch from FAIL to PASS with your changes. I assume code as-is fails some tests on the platform. If not we need new tests.

vitalybuka requested changes to this revision.Apr 8 2020, 6:10 PM
This revision now requires changes to proceed.Apr 8 2020, 6:10 PM

With TBI enabled in the system, HWASAN should also work, I've had it running some time ago


Sooo do we just leave this UNKNOWN?..

Shouldn't the system expose it?

I wonder which sanitizers actually require it…

Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 3:32 AM