Page MenuHomePhabricator
Differential D125706

[analyzer][NFC] Use idiomatic classof instead of isKind
ClosedPublic
Actions

Authored by steakhal on May 16 2022, 10:35 AM.

Details

Reviewers
NoQ
martong
Szelethus
balazske
ASDenysPetrov
bzcheeseman
xazax.hun
Commits
rGe37b287998a7: [analyzer][NFC] Use idiomatic classof instead of isKind
Summary
  • Rename isKind() to classof() to follow the llvm style RTTI.
  • Take SVal by-value instead of reference.
  • Mark classof public.

Diff Detail

Event Timeline

steakhal created this revision.May 16 2022, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 10:35 AM
Herald added subscribers: manas, dkrupp, donat.nagy and 6 others. · View Herald Transcript
steakhal requested review of this revision.May 16 2022, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 10:35 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
steakhal added a child revision: D125707: [analyzer][NFC] Remove unused friend SVal declarations.May 16 2022, 10:35 AM
steakhal added a reviewer: xazax.hun.
Harbormaster completed remote builds in B164685: Diff 429767.May 16 2022, 11:34 AM
martong accepted this revision.May 17 2022, 1:53 AM

LGTM

This revision is now accepted and ready to land.May 17 2022, 1:53 AM
xazax.hun accepted this revision.May 17 2022, 10:19 AM
Closed by commit rGe37b287998a7: [analyzer][NFC] Use idiomatic classof instead of isKind (authored by steakhal). · Explain WhyMay 27 2022, 1:57 AM
This revision was automatically updated to reflect the committed changes.
steakhal added a commit: rGe37b287998a7: [analyzer][NFC] Use idiomatic classof instead of isKind.

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
StaticAnalyzer/
Core/
PathSensitive/
194 lines

Diff 432493

View Options

clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h

Loading...