This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF] Fix assert for split dwarf.
ClosedPublic

Authored by ayermolo on May 7 2022, 5:59 PM.

Details

Summary

Fixing a small bug where it would assert if CU does not modify .debug_addr section.

Diff Detail

Event Timeline

ayermolo created this revision.May 7 2022, 5:59 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.May 7 2022, 5:59 PM
Herald added a project: Restricted Project. · View Herald Transcript
rafauler added inline comments.May 7 2022, 6:04 PM
bolt/lib/Rewrite/DWARFRewriter.cpp
1021–1028

Won't this code be unreachable after the change in 1003?

ayermolo marked an inline comment as done.May 7 2022, 7:35 PM
ayermolo added inline comments.
bolt/lib/Rewrite/DWARFRewriter.cpp
1021–1028

ah yes,

ayermolo updated this revision to Diff 427905.May 7 2022, 7:41 PM
ayermolo marked an inline comment as done.

fixing wrong check

rafauler accepted this revision.May 8 2022, 6:05 PM

LGTM

This revision is now accepted and ready to land.May 8 2022, 6:05 PM
This revision was automatically updated to reflect the committed changes.