This is an archive of the discontinued LLVM Phabricator instance.

Differential D125181

[BOLT][DWARF] Fix assert for split dwarf.
ClosedPublic

Authored by ayermolo on May 7 2022, 5:59 PM.

Details

Reviewers
rafauler
Amir
maksfb
jdoerfert
Commits
rG3abb68a62616: [BOLT][DWARF] Fix assert for split dwarf.
Summary

Fixing a small bug where it would assert if CU does not modify .debug_addr section.

Diff Detail

Event Timeline

ayermolo created this revision.May 7 2022, 5:59 PM
Herald added a reviewer: rafauler. · View Herald TranscriptMay 7 2022, 5:59 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.May 7 2022, 5:59 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMay 7 2022, 5:59 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, yota9, sstefan1. · View Herald Transcript
rafauler added inline comments.May 7 2022, 6:04 PM
bolt/lib/Rewrite/DWARFRewriter.cpp
1023–1030

Won't this code be unreachable after the change in 1003?

Harbormaster completed remote builds in B163353: Diff 427904.May 7 2022, 6:05 PM
ayermolo marked an inline comment as done.May 7 2022, 7:35 PM
ayermolo added inline comments.
bolt/lib/Rewrite/DWARFRewriter.cpp
1023–1030

ah yes,

ayermolo updated this revision to Diff 427905.May 7 2022, 7:41 PM
ayermolo marked an inline comment as done.

fixing wrong check

Harbormaster completed remote builds in B163354: Diff 427905.May 7 2022, 7:46 PM
rafauler accepted this revision.May 8 2022, 6:05 PM

LGTM

This revision is now accepted and ready to land.May 8 2022, 6:05 PM
Closed by commit rG3abb68a62616: [BOLT][DWARF] Fix assert for split dwarf. (authored by ayermolo). · Explain WhyMay 8 2022, 7:19 PM
This revision was automatically updated to reflect the committed changes.
ayermolo added a commit: rG3abb68a62616: [BOLT][DWARF] Fix assert for split dwarf..

Revision Contents

Diff 427965

bolt/lib/Core/DebugData.cpp

Show First 20 Lines • Show All 352 Lines • ▼ Show 20 LinesAddressSectionBuffer DebugAddrWriter::finalize() {
raw_svector_ostream AddressStream(Buffer); raw_svector_ostream AddressStream(Buffer);
for (std::unique_ptr<DWARFUnit> &CU : BC->DwCtx->compile_units()) { for (std::unique_ptr<DWARFUnit> &CU : BC->DwCtx->compile_units()) {
// Handling the case wehre debug information is a mix of Debug fission and // Handling the case wehre debug information is a mix of Debug fission and
// monolitic. // monolitic.
if (!CU->getDWOId()) if (!CU->getDWOId())
continue; continue;
const uint64_t CUID = getCUID(*CU.get()); const uint64_t CUID = getCUID(*CU.get());
auto AM = AddressMaps.find(CUID); auto AM = AddressMaps.find(CUID);
assert(AM != AddressMaps.end() && "Address Map not found.");
// Adding to map even if it did not contribute to .debug_addr. // Adding to map even if it did not contribute to .debug_addr.
// The Skeleton CU will still have DW_AT_GNU_addr_base. // The Skeleton CU might still have DW_AT_GNU_addr_base.
DWOIdToOffsetMap[CUID] = Buffer.size(); DWOIdToOffsetMap[CUID] = Buffer.size();
// If does not exist this CUs DWO section didn't contribute to .debug_addr. // If does not exist this CUs DWO section didn't contribute to .debug_addr.
if (AM == AddressMaps.end()) if (AM == AddressMaps.end())
continue; continue;
std::vector<IndexAddressPair> SortedMap(AM->second.indexToAddressBegin(), std::vector<IndexAddressPair> SortedMap(AM->second.indexToAddressBegin(),
AM->second.indexToAdddessEnd()); AM->second.indexToAdddessEnd());
// Sorting address in increasing order of indices. // Sorting address in increasing order of indices.
std::sort(SortedMap.begin(), SortedMap.end(), std::sort(SortedMap.begin(), SortedMap.end(),
▲ Show 20 Lines • Show All 116 Lines • ▼ Show 20 Linesuint64_t DebugAddrWriter::getOffset(DWARFUnit &Unit) {
assert(Iter != DWOIdToOffsetMap.end() && assert(Iter != DWOIdToOffsetMap.end() &&
"Offset in to.debug_addr was not found for DWO ID."); "Offset in to.debug_addr was not found for DWO ID.");
return Iter->second; return Iter->second;
} }
uint64_t DebugAddrWriterDwarf5::getOffset(DWARFUnit &Unit) { uint64_t DebugAddrWriterDwarf5::getOffset(DWARFUnit &Unit) {
auto Iter = DWOIdToOffsetMap.find(getCUID(Unit)); auto Iter = DWOIdToOffsetMap.find(getCUID(Unit));
assert(Iter != DWOIdToOffsetMap.end() && assert(Iter != DWOIdToOffsetMap.end() &&
"Offset in to.debug_addr was not found for DWO ID."); "Offset in to.debug_addr was not found for CU ID.");
return Iter->second; return Iter->second;
} }
DebugLocWriter::DebugLocWriter(BinaryContext *BC) { DebugLocWriter::DebugLocWriter(BinaryContext *BC) {
LocBuffer = std::make_unique<DebugBufferVector>(); LocBuffer = std::make_unique<DebugBufferVector>();
LocStream = std::make_unique<raw_svector_ostream>(*LocBuffer); LocStream = std::make_unique<raw_svector_ostream>(*LocBuffer);
} }
▲ Show 20 Lines • Show All 1,113 Lines • Show Last 20 Lines

bolt/lib/Rewrite/DWARFRewriter.cpp

Show First 20 Lines • Show All 994 Lines • ▼ Show 20 Lines for (auto &CU : BC.DwCtx->compile_units()) {
DWARFDie DIE = CU->getUnitDIE(); DWARFDie DIE = CU->getUnitDIE();
uint64_t Offset = 0; uint64_t Offset = 0;
uint64_t AttrOffset = 0; uint64_t AttrOffset = 0;
uint32_t Size = 0; uint32_t Size = 0;
Optional<AttrInfo> AttrValGnu = Optional<AttrInfo> AttrValGnu =
findAttributeInfo(DIE, dwarf::DW_AT_GNU_addr_base); findAttributeInfo(DIE, dwarf::DW_AT_GNU_addr_base);
Optional<AttrInfo> AttrVal = Optional<AttrInfo> AttrVal =
findAttributeInfo(DIE, dwarf::DW_AT_addr_base); findAttributeInfo(DIE, dwarf::DW_AT_addr_base);
// For cases where Skeleton CU does not have DW_AT_GNU_addr_base
if (!AttrValGnu && CU->getVersion() < 5)
continue;
Offset = AddrWriter->getOffset(*CU); Offset = AddrWriter->getOffset(*CU);
if (AttrValGnu) { if (AttrValGnu) {
AttrOffset = AttrValGnu->Offset; AttrOffset = AttrValGnu->Offset;
Size = AttrValGnu->Size; Size = AttrValGnu->Size;
} }
if (AttrVal) { if (AttrVal) {
AttrOffset = AttrVal->Offset; AttrOffset = AttrVal->Offset;
Size = AttrVal->Size; Size = AttrVal->Size;
} }
if (AttrValGnu || AttrVal) { if (AttrValGnu || AttrVal) {
DebugInfoPatcher.addLE32Patch(AttrOffset, static_cast<int32_t>(Offset), DebugInfoPatcher.addLE32Patch(AttrOffset, static_cast<int32_t>(Offset),
Size); Size);
} else if (CU->getVersion() >= 5) { } else if (CU->getVersion() >= 5) {
// A case where we were not using .debug_addr section, but after update // A case where we were not using .debug_addr section, but after update
// now using it. // now using it.
const DWARFAbbreviationDeclaration *Abbrev = const DWARFAbbreviationDeclaration *Abbrev =
DIE.getAbbreviationDeclarationPtr(); DIE.getAbbreviationDeclarationPtr();
AbbrevWriter->addAttribute(*CU, Abbrev, dwarf::DW_AT_addr_base, AbbrevWriter->addAttribute(*CU, Abbrev, dwarf::DW_AT_addr_base,
dwarf::DW_FORM_sec_offset); dwarf::DW_FORM_sec_offset);
DebugInfoPatcher.insertNewEntry(DIE, static_cast<int32_t>(Offset)); DebugInfoPatcher.insertNewEntry(DIE, static_cast<int32_t>(Offset));
rafaulerUnsubmitted
Done
ReplyInline Actions

Won't this code be unreachable after the change in 1003?

rafauler: Won't this code be unreachable after the change in 1003?
ayermoloAuthorUnsubmitted
Done
ReplyInline Actions

ah yes,

ayermolo: ah yes,
} else }
llvm_unreachable(
"DWO CU uses .debug_address, but DW_AT_GNU_addr_base is missing.");
} }
} }
std::unique_ptr<DebugBufferVector> AbbrevSectionContents = std::unique_ptr<DebugBufferVector> AbbrevSectionContents =
AbbrevWriter->finalize(); AbbrevWriter->finalize();
BC.registerOrUpdateNoteSection(".debug_abbrev", BC.registerOrUpdateNoteSection(".debug_abbrev",
copyByteArray(*AbbrevSectionContents), copyByteArray(*AbbrevSectionContents),
AbbrevSectionContents->size()); AbbrevSectionContents->size());
▲ Show 20 Lines • Show All 710 Lines • Show Last 20 Lines

bolt/test/X86/Inputs/dwarf4-split-dwarf-no-address-helper.s

  • This file was added.
# Manually modified to remove low_pc/high_pc and base_address
# int helper(int i) {
# return ++i;
# }
.text
.file "helper.cpp"
.globl _Z6helperi # -- Begin function _Z6helperi
.p2align 4, 0x90
.type _Z6helperi,@function
_Z6helperi: # @_Z6helperi
.Lfunc_begin0:
.file 1 "." "helper.cpp"
.loc 1 1 0 # helper.cpp:1:0
.cfi_startproc
# %bb.0: # %entry
pushq %rbp
.cfi_def_cfa_offset 16
.cfi_offset %rbp, -16
movq %rsp, %rbp
.cfi_def_cfa_register %rbp
movl %edi, -4(%rbp)
.Ltmp0:
.loc 1 2 10 prologue_end # helper.cpp:2:10
movl -4(%rbp), %eax
addl $1, %eax
movl %eax, -4(%rbp)
.loc 1 2 3 is_stmt 0 # helper.cpp:2:3
popq %rbp
.cfi_def_cfa %rsp, 8
retq
.Ltmp1:
.Lfunc_end0:
.size _Z6helperi, .Lfunc_end0-_Z6helperi
.cfi_endproc
# -- End function
.section .debug_abbrev,"",@progbits
.byte 1 # Abbreviation Code
.byte 17 # DW_TAG_compile_unit
.byte 0 # DW_CHILDREN_no
.byte 16 # DW_AT_stmt_list
.byte 23 # DW_FORM_sec_offset
.byte 27 # DW_AT_comp_dir
.byte 14 # DW_FORM_strp
.ascii "\264B" # DW_AT_GNU_pubnames
.byte 25 # DW_FORM_flag_present
.ascii "\260B" # DW_AT_GNU_dwo_name
.byte 14 # DW_FORM_strp
.ascii "\261B" # DW_AT_GNU_dwo_id
.byte 7 # DW_FORM_data8
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 0 # EOM(3)
.section .debug_info,"",@progbits
.Lcu_begin0:
.long .Ldebug_info_end0-.Ldebug_info_start0 # Length of Unit
.Ldebug_info_start0:
.short 4 # DWARF version number
.long .debug_abbrev # Offset Into Abbrev. Section
.byte 8 # Address Size (in bytes)
.byte 1 # Abbrev [1] 0xb:0x25 DW_TAG_compile_unit
.long .Lline_table_start0 # DW_AT_stmt_list
.long .Lskel_string0 # DW_AT_comp_dir
# DW_AT_GNU_pubnames
.long .Lskel_string1 # DW_AT_GNU_dwo_name
.quad 2738718332032343034 # DW_AT_GNU_dwo_id
.Ldebug_info_end0:
.section .debug_str,"MS",@progbits,1
.Lskel_string0:
.asciz "." # string offset=0
.Lskel_string1:
.asciz "helper.dwo" # string offset=38
.section .debug_str.dwo,"eMS",@progbits,1
.Linfo_string0:
.asciz "_Z6helperi" # string offset=0
.Linfo_string1:
.asciz "helper" # string offset=11
.Linfo_string2:
.asciz "int" # string offset=18
.Linfo_string3:
.asciz "i" # string offset=22
.Linfo_string4:
.asciz "clang version 15.0.0" # string offset=24
.Linfo_string5:
.asciz "helper.cpp" # string offset=158
.Linfo_string6:
.asciz "helper.dwo" # string offset=169
.section .debug_str_offsets.dwo,"e",@progbits
.long 0
.long 11
.long 18
.long 22
.long 24
.long 158
.long 169
.section .debug_info.dwo,"e",@progbits
.long .Ldebug_info_dwo_end0-.Ldebug_info_dwo_start0 # Length of Unit
.Ldebug_info_dwo_start0:
.short 4 # DWARF version number
.long 0 # Offset Into Abbrev. Section
.byte 8 # Address Size (in bytes)
.byte 1 # Abbrev [1] 0xb:0x2f DW_TAG_compile_unit
.byte 4 # DW_AT_producer
.short 33 # DW_AT_language
.byte 5 # DW_AT_name
.byte 6 # DW_AT_GNU_dwo_name
.quad 2738718332032343034 # DW_AT_GNU_dwo_id
.byte 2 # Abbrev [2] 0x19:0x1c DW_TAG_subprogram
.byte 1 # DW_AT_frame_base
.byte 86
.byte 0 # DW_AT_linkage_name
.byte 1 # DW_AT_name
.byte 1 # DW_AT_decl_file
.byte 1 # DW_AT_decl_line
.long 53 # DW_AT_type
# DW_AT_external
.byte 3 # Abbrev [3] 0x29:0xb DW_TAG_formal_parameter
.byte 2 # DW_AT_location
.byte 145
.byte 124
.byte 3 # DW_AT_name
.byte 1 # DW_AT_decl_file
.byte 1 # DW_AT_decl_line
.long 53 # DW_AT_type
.byte 0 # End Of Children Mark
.byte 4 # Abbrev [4] 0x35:0x4 DW_TAG_base_type
.byte 2 # DW_AT_name
.byte 5 # DW_AT_encoding
.byte 4 # DW_AT_byte_size
.byte 0 # End Of Children Mark
.Ldebug_info_dwo_end0:
.section .debug_abbrev.dwo,"e",@progbits
.byte 1 # Abbreviation Code
.byte 17 # DW_TAG_compile_unit
.byte 1 # DW_CHILDREN_yes
.byte 37 # DW_AT_producer
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 19 # DW_AT_language
.byte 5 # DW_FORM_data2
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.ascii "\260B" # DW_AT_GNU_dwo_name
.ascii "\202>" # DW_FORM_GNU_str_index
.ascii "\261B" # DW_AT_GNU_dwo_id
.byte 7 # DW_FORM_data8
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 2 # Abbreviation Code
.byte 46 # DW_TAG_subprogram
.byte 1 # DW_CHILDREN_yes
.byte 64 # DW_AT_frame_base
.byte 24 # DW_FORM_exprloc
.byte 110 # DW_AT_linkage_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 58 # DW_AT_decl_file
.byte 11 # DW_FORM_data1
.byte 59 # DW_AT_decl_line
.byte 11 # DW_FORM_data1
.byte 73 # DW_AT_type
.byte 19 # DW_FORM_ref4
.byte 63 # DW_AT_external
.byte 25 # DW_FORM_flag_present
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 3 # Abbreviation Code
.byte 5 # DW_TAG_formal_parameter
.byte 0 # DW_CHILDREN_no
.byte 2 # DW_AT_location
.byte 24 # DW_FORM_exprloc
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 58 # DW_AT_decl_file
.byte 11 # DW_FORM_data1
.byte 59 # DW_AT_decl_line
.byte 11 # DW_FORM_data1
.byte 73 # DW_AT_type
.byte 19 # DW_FORM_ref4
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 4 # Abbreviation Code
.byte 36 # DW_TAG_base_type
.byte 0 # DW_CHILDREN_no
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 62 # DW_AT_encoding
.byte 11 # DW_FORM_data1
.byte 11 # DW_AT_byte_size
.byte 11 # DW_FORM_data1
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 0 # EOM(3)
.section .debug_addr,"",@progbits
.Laddr_table_base0:
.quad .Lfunc_begin0
.section .debug_gnu_pubnames,"",@progbits
.long .LpubNames_end0-.LpubNames_start0 # Length of Public Names Info
.LpubNames_start0:
.short 2 # DWARF Version
.long .Lcu_begin0 # Offset of Compilation Unit Info
.long 48 # Compilation Unit Length
.long 25 # DIE offset
.byte 48 # Attributes: FUNCTION, EXTERNAL
.asciz "helper" # External Name
.long 0 # End Mark
.LpubNames_end0:
.section .debug_gnu_pubtypes,"",@progbits
.long .LpubTypes_end0-.LpubTypes_start0 # Length of Public Types Info
.LpubTypes_start0:
.short 2 # DWARF Version
.long .Lcu_begin0 # Offset of Compilation Unit Info
.long 48 # Compilation Unit Length
.long 53 # DIE offset
.byte 144 # Attributes: TYPE, STATIC
.asciz "int" # External Name
.long 0 # End Mark
.LpubTypes_end0:
.ident "clang version 15.0.0"
.section ".note.GNU-stack","",@progbits
.addrsig
.section .debug_line,"",@progbits
.Lline_table_start0:

bolt/test/X86/Inputs/dwarf4-split-dwarf-no-address-main.s

  • This file was added.
# extern int helper(int i);
# void use(int * x, int * y) {
# *x += 4;
# *y -= 2;
# }
#
# int x = 0;
# int y = 1;
# int main(int argc, char *argv[]) {
# x = argc;
# y = argc + 3;
# use(&x, &y);
# return x + helper(y);
# }
.text
.file "main.cpp"
.file 1 "." "main.cpp"
.globl _Z3usePiS_ # -- Begin function _Z3usePiS_
.p2align 4, 0x90
.type _Z3usePiS_,@function
_Z3usePiS_: # @_Z3usePiS_
.Lfunc_begin0:
.loc 1 2 0 # main.cpp:2:0
.cfi_startproc
# %bb.0: # %entry
pushq %rbp
.cfi_def_cfa_offset 16
.cfi_offset %rbp, -16
movq %rsp, %rbp
.cfi_def_cfa_register %rbp
movq %rdi, -8(%rbp)
movq %rsi, -16(%rbp)
.Ltmp0:
.loc 1 3 3 prologue_end # main.cpp:3:3
movq -8(%rbp), %rax
.loc 1 3 5 is_stmt 0 # main.cpp:3:5
movl (%rax), %ecx
addl $4, %ecx
movl %ecx, (%rax)
.loc 1 4 3 is_stmt 1 # main.cpp:4:3
movq -16(%rbp), %rax
.loc 1 4 5 is_stmt 0 # main.cpp:4:5
movl (%rax), %ecx
subl $2, %ecx
movl %ecx, (%rax)
.loc 1 5 1 is_stmt 1 # main.cpp:5:1
popq %rbp
.cfi_def_cfa %rsp, 8
retq
.Ltmp1:
.Lfunc_end0:
.size _Z3usePiS_, .Lfunc_end0-_Z3usePiS_
.cfi_endproc
# -- End function
.globl main # -- Begin function main
.p2align 4, 0x90
.type main,@function
main: # @main
.Lfunc_begin1:
.loc 1 9 0 # main.cpp:9:0
.cfi_startproc
# %bb.0: # %entry
pushq %rbp
.cfi_def_cfa_offset 16
.cfi_offset %rbp, -16
movq %rsp, %rbp
.cfi_def_cfa_register %rbp
subq $32, %rsp
movl $0, -4(%rbp)
movl %edi, -8(%rbp)
movq %rsi, -16(%rbp)
.Ltmp2:
.loc 1 10 7 prologue_end # main.cpp:10:7
movl -8(%rbp), %eax
.loc 1 10 5 is_stmt 0 # main.cpp:10:5
movl %eax, x
.loc 1 11 7 is_stmt 1 # main.cpp:11:7
movl -8(%rbp), %eax
.loc 1 11 12 is_stmt 0 # main.cpp:11:12
addl $3, %eax
.loc 1 11 5 # main.cpp:11:5
movl %eax, y
.loc 1 12 3 is_stmt 1 # main.cpp:12:3
movabsq $x, %rdi
movabsq $y, %rsi
callq _Z3usePiS_
.loc 1 13 10 # main.cpp:13:10
movl x, %eax
movl %eax, -20(%rbp) # 4-byte Spill
.loc 1 13 21 is_stmt 0 # main.cpp:13:21
movl y, %edi
.loc 1 13 14 # main.cpp:13:14
callq _Z6helperi
movl %eax, %ecx
movl -20(%rbp), %eax # 4-byte Reload
.loc 1 13 12 # main.cpp:13:12
addl %ecx, %eax
.loc 1 13 3 # main.cpp:13:3
addq $32, %rsp
popq %rbp
.cfi_def_cfa %rsp, 8
retq
.Ltmp3:
.Lfunc_end1:
.size main, .Lfunc_end1-main
.cfi_endproc
# -- End function
.type x,@object # @x
.bss
.globl x
.p2align 2
x:
.long 0 # 0x0
.size x, 4
.type y,@object # @y
.data
.globl y
.p2align 2
y:
.long 1 # 0x1
.size y, 4
.section .debug_abbrev,"",@progbits
.byte 1 # Abbreviation Code
.byte 17 # DW_TAG_compile_unit
.byte 0 # DW_CHILDREN_no
.byte 16 # DW_AT_stmt_list
.byte 23 # DW_FORM_sec_offset
.byte 27 # DW_AT_comp_dir
.byte 14 # DW_FORM_strp
.ascii "\264B" # DW_AT_GNU_pubnames
.byte 25 # DW_FORM_flag_present
.ascii "\260B" # DW_AT_GNU_dwo_name
.byte 14 # DW_FORM_strp
.ascii "\261B" # DW_AT_GNU_dwo_id
.byte 7 # DW_FORM_data8
.byte 17 # DW_AT_low_pc
.byte 1 # DW_FORM_addr
.byte 18 # DW_AT_high_pc
.byte 6 # DW_FORM_data4
.ascii "\263B" # DW_AT_GNU_addr_base
.byte 23 # DW_FORM_sec_offset
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 0 # EOM(3)
.section .debug_info,"",@progbits
.Lcu_begin0:
.long .Ldebug_info_end0-.Ldebug_info_start0 # Length of Unit
.Ldebug_info_start0:
.short 4 # DWARF version number
.long .debug_abbrev # Offset Into Abbrev. Section
.byte 8 # Address Size (in bytes)
.byte 1 # Abbrev [1] 0xb:0x25 DW_TAG_compile_unit
.long .Lline_table_start0 # DW_AT_stmt_list
.long .Lskel_string0 # DW_AT_comp_dir
# DW_AT_GNU_pubnames
.long .Lskel_string1 # DW_AT_GNU_dwo_name
.quad 4587139501222431648 # DW_AT_GNU_dwo_id
.quad .Lfunc_begin0 # DW_AT_low_pc
.long .Lfunc_end1-.Lfunc_begin0 # DW_AT_high_pc
.long .Laddr_table_base0 # DW_AT_GNU_addr_base
.Ldebug_info_end0:
.section .debug_str,"MS",@progbits,1
.Lskel_string0:
.asciz "." # string offset=0
.Lskel_string1:
.asciz "main.dwo" # string offset=38
.section .debug_str.dwo,"eMS",@progbits,1
.Linfo_string0:
.asciz "x" # string offset=0
.Linfo_string1:
.asciz "int" # string offset=2
.Linfo_string2:
.asciz "y" # string offset=6
.Linfo_string3:
.asciz "_Z3usePiS_" # string offset=8
.Linfo_string4:
.asciz "use" # string offset=19
.Linfo_string5:
.asciz "main" # string offset=23
.Linfo_string6:
.asciz "argc" # string offset=28
.Linfo_string7:
.asciz "argv" # string offset=33
.Linfo_string8:
.asciz "char" # string offset=38
.Linfo_string9:
.asciz "clang version 15.0.0" # string offset=43
.Linfo_string10:
.asciz "main.cpp" # string offset=177
.Linfo_string11:
.asciz "main.dwo" # string offset=186
.section .debug_str_offsets.dwo,"e",@progbits
.long 0
.long 2
.long 6
.long 8
.long 19
.long 23
.long 28
.long 33
.long 38
.long 43
.long 177
.long 186
.section .debug_info.dwo,"e",@progbits
.long .Ldebug_info_dwo_end0-.Ldebug_info_dwo_start0 # Length of Unit
.Ldebug_info_dwo_start0:
.short 4 # DWARF version number
.long 0 # Offset Into Abbrev. Section
.byte 8 # Address Size (in bytes)
.byte 1 # Abbrev [1] 0xb:0x85 DW_TAG_compile_unit
.byte 9 # DW_AT_producer
.short 33 # DW_AT_language
.byte 10 # DW_AT_name
.byte 11 # DW_AT_GNU_dwo_name
.quad 4587139501222431648 # DW_AT_GNU_dwo_id
.byte 2 # Abbrev [2] 0x19:0xb DW_TAG_variable
.byte 0 # DW_AT_name
.long 36 # DW_AT_type
# DW_AT_external
.byte 1 # DW_AT_decl_file
.byte 7 # DW_AT_decl_line
.byte 2 # DW_AT_location
.byte 251
.byte 0
.byte 3 # Abbrev [3] 0x24:0x4 DW_TAG_base_type
.byte 1 # DW_AT_name
.byte 5 # DW_AT_encoding
.byte 4 # DW_AT_byte_size
.byte 2 # Abbrev [2] 0x28:0xb DW_TAG_variable
.byte 2 # DW_AT_name
.long 36 # DW_AT_type
# DW_AT_external
.byte 1 # DW_AT_decl_file
.byte 8 # DW_AT_decl_line
.byte 2 # DW_AT_location
.byte 251
.byte 1
.byte 4 # Abbrev [4] 0x33:0x23 DW_TAG_subprogram
.byte 2 # DW_AT_low_pc
.long .Lfunc_end0-.Lfunc_begin0 # DW_AT_high_pc
.byte 1 # DW_AT_frame_base
.byte 86
.byte 3 # DW_AT_linkage_name
.byte 4 # DW_AT_name
.byte 1 # DW_AT_decl_file
.byte 2 # DW_AT_decl_line
# DW_AT_external
.byte 5 # Abbrev [5] 0x3f:0xb DW_TAG_formal_parameter
.byte 2 # DW_AT_location
.byte 145
.byte 120
.byte 0 # DW_AT_name
.byte 1 # DW_AT_decl_file
.byte 2 # DW_AT_decl_line
.long 124 # DW_AT_type
.byte 5 # Abbrev [5] 0x4a:0xb DW_TAG_formal_parameter
.byte 2 # DW_AT_location
.byte 145
.byte 112
.byte 2 # DW_AT_name
.byte 1 # DW_AT_decl_file
.byte 2 # DW_AT_decl_line
.long 124 # DW_AT_type
.byte 0 # End Of Children Mark
.byte 6 # Abbrev [6] 0x56:0x26 DW_TAG_subprogram
.byte 3 # DW_AT_low_pc
.long .Lfunc_end1-.Lfunc_begin1 # DW_AT_high_pc
.byte 1 # DW_AT_frame_base
.byte 86
.byte 5 # DW_AT_name
.byte 1 # DW_AT_decl_file
.byte 9 # DW_AT_decl_line
.long 36 # DW_AT_type
# DW_AT_external
.byte 5 # Abbrev [5] 0x65:0xb DW_TAG_formal_parameter
.byte 2 # DW_AT_location
.byte 145
.byte 120
.byte 6 # DW_AT_name
.byte 1 # DW_AT_decl_file
.byte 9 # DW_AT_decl_line
.long 36 # DW_AT_type
.byte 5 # Abbrev [5] 0x70:0xb DW_TAG_formal_parameter
.byte 2 # DW_AT_location
.byte 145
.byte 112
.byte 7 # DW_AT_name
.byte 1 # DW_AT_decl_file
.byte 9 # DW_AT_decl_line
.long 129 # DW_AT_type
.byte 0 # End Of Children Mark
.byte 7 # Abbrev [7] 0x7c:0x5 DW_TAG_pointer_type
.long 36 # DW_AT_type
.byte 7 # Abbrev [7] 0x81:0x5 DW_TAG_pointer_type
.long 134 # DW_AT_type
.byte 7 # Abbrev [7] 0x86:0x5 DW_TAG_pointer_type
.long 139 # DW_AT_type
.byte 3 # Abbrev [3] 0x8b:0x4 DW_TAG_base_type
.byte 8 # DW_AT_name
.byte 6 # DW_AT_encoding
.byte 1 # DW_AT_byte_size
.byte 0 # End Of Children Mark
.Ldebug_info_dwo_end0:
.section .debug_abbrev.dwo,"e",@progbits
.byte 1 # Abbreviation Code
.byte 17 # DW_TAG_compile_unit
.byte 1 # DW_CHILDREN_yes
.byte 37 # DW_AT_producer
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 19 # DW_AT_language
.byte 5 # DW_FORM_data2
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.ascii "\260B" # DW_AT_GNU_dwo_name
.ascii "\202>" # DW_FORM_GNU_str_index
.ascii "\261B" # DW_AT_GNU_dwo_id
.byte 7 # DW_FORM_data8
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 2 # Abbreviation Code
.byte 52 # DW_TAG_variable
.byte 0 # DW_CHILDREN_no
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 73 # DW_AT_type
.byte 19 # DW_FORM_ref4
.byte 63 # DW_AT_external
.byte 25 # DW_FORM_flag_present
.byte 58 # DW_AT_decl_file
.byte 11 # DW_FORM_data1
.byte 59 # DW_AT_decl_line
.byte 11 # DW_FORM_data1
.byte 2 # DW_AT_location
.byte 24 # DW_FORM_exprloc
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 3 # Abbreviation Code
.byte 36 # DW_TAG_base_type
.byte 0 # DW_CHILDREN_no
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 62 # DW_AT_encoding
.byte 11 # DW_FORM_data1
.byte 11 # DW_AT_byte_size
.byte 11 # DW_FORM_data1
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 4 # Abbreviation Code
.byte 46 # DW_TAG_subprogram
.byte 1 # DW_CHILDREN_yes
.byte 17 # DW_AT_low_pc
.ascii "\201>" # DW_FORM_GNU_addr_index
.byte 18 # DW_AT_high_pc
.byte 6 # DW_FORM_data4
.byte 64 # DW_AT_frame_base
.byte 24 # DW_FORM_exprloc
.byte 110 # DW_AT_linkage_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 58 # DW_AT_decl_file
.byte 11 # DW_FORM_data1
.byte 59 # DW_AT_decl_line
.byte 11 # DW_FORM_data1
.byte 63 # DW_AT_external
.byte 25 # DW_FORM_flag_present
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 5 # Abbreviation Code
.byte 5 # DW_TAG_formal_parameter
.byte 0 # DW_CHILDREN_no
.byte 2 # DW_AT_location
.byte 24 # DW_FORM_exprloc
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 58 # DW_AT_decl_file
.byte 11 # DW_FORM_data1
.byte 59 # DW_AT_decl_line
.byte 11 # DW_FORM_data1
.byte 73 # DW_AT_type
.byte 19 # DW_FORM_ref4
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 6 # Abbreviation Code
.byte 46 # DW_TAG_subprogram
.byte 1 # DW_CHILDREN_yes
.byte 17 # DW_AT_low_pc
.ascii "\201>" # DW_FORM_GNU_addr_index
.byte 18 # DW_AT_high_pc
.byte 6 # DW_FORM_data4
.byte 64 # DW_AT_frame_base
.byte 24 # DW_FORM_exprloc
.byte 3 # DW_AT_name
.ascii "\202>" # DW_FORM_GNU_str_index
.byte 58 # DW_AT_decl_file
.byte 11 # DW_FORM_data1
.byte 59 # DW_AT_decl_line
.byte 11 # DW_FORM_data1
.byte 73 # DW_AT_type
.byte 19 # DW_FORM_ref4
.byte 63 # DW_AT_external
.byte 25 # DW_FORM_flag_present
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 7 # Abbreviation Code
.byte 15 # DW_TAG_pointer_type
.byte 0 # DW_CHILDREN_no
.byte 73 # DW_AT_type
.byte 19 # DW_FORM_ref4
.byte 0 # EOM(1)
.byte 0 # EOM(2)
.byte 0 # EOM(3)
.section .debug_addr,"",@progbits
.Laddr_table_base0:
.quad x
.quad y
.quad .Lfunc_begin0
.quad .Lfunc_begin1
.section .debug_gnu_pubnames,"",@progbits
.long .LpubNames_end0-.LpubNames_start0 # Length of Public Names Info
.LpubNames_start0:
.short 2 # DWARF Version
.long .Lcu_begin0 # Offset of Compilation Unit Info
.long 48 # Compilation Unit Length
.long 86 # DIE offset
.byte 48 # Attributes: FUNCTION, EXTERNAL
.asciz "main" # External Name
.long 25 # DIE offset
.byte 32 # Attributes: VARIABLE, EXTERNAL
.asciz "x" # External Name
.long 40 # DIE offset
.byte 32 # Attributes: VARIABLE, EXTERNAL
.asciz "y" # External Name
.long 51 # DIE offset
.byte 48 # Attributes: FUNCTION, EXTERNAL
.asciz "use" # External Name
.long 0 # End Mark
.LpubNames_end0:
.section .debug_gnu_pubtypes,"",@progbits
.long .LpubTypes_end0-.LpubTypes_start0 # Length of Public Types Info
.LpubTypes_start0:
.short 2 # DWARF Version
.long .Lcu_begin0 # Offset of Compilation Unit Info
.long 48 # Compilation Unit Length
.long 36 # DIE offset
.byte 144 # Attributes: TYPE, STATIC
.asciz "int" # External Name
.long 139 # DIE offset
.byte 144 # Attributes: TYPE, STATIC
.asciz "char" # External Name
.long 0 # End Mark
.LpubTypes_end0:
.ident "clang version 15.0.0"
.section ".note.GNU-stack","",@progbits
.addrsig
.addrsig_sym _Z3usePiS_
.addrsig_sym _Z6helperi
.addrsig_sym x
.addrsig_sym y
.section .debug_line,"",@progbits
.Lline_table_start0:

bolt/test/X86/dwarf4-split-dwarf-no-address.test

  • This file was added.
; RUN: rm -rf %t
; RUN: mkdir %t
; RUN: cd %t
; RUN: llvm-mc --split-dwarf-file=main.dwo --triple=x86_64-unknown-linux-gnu \
; RUN: --filetype=obj %p/Inputs/dwarf4-split-dwarf-no-address-main.s -o=main.o
; RUN: llvm-mc --split-dwarf-file=helper.dwo --triple=x86_64-unknown-linux-gnu \
; RUN: --filetype=obj %p/Inputs/dwarf4-split-dwarf-no-address-helper.s -o=helper.o
; RUN: %clang %cflags -gdwarf-4 -gsplit-dwarf=split main.o helper.o -o main.exe
; RUN: llvm-bolt main.exe -o main.exe.bolt --update-debug-sections
; RUN: llvm-dwarfdump --show-form --verbose --debug-info main.exe.bolt | FileCheck -check-prefix=BOLT %s
; Testing that there are no asserts/crashes when one of the DWARF4 CUs does not modify .debug_addr
; BOLT: DW_TAG_compile_unit
; BOLT: DW_TAG_compile_unit