This is an archive of the discontinued LLVM Phabricator instance.

[MIPS] Remove an incorrect microMIPS instruction alias
ClosedPublic

Authored by sdardis on Apr 30 2022, 10:58 AM.

Details

Summary

The microMIPS instruction set is compatible with the MIPS instruction
set at the assembly level but not in terms of encodings. nop in
microMIPS is a special case as it has the same encoding as nop for
MIPS.

Fix this error by reducing the usage of NOP in the MIPS backend such
that only that ISA correct variants are produced.

Diff Detail

Event Timeline

sdardis created this revision.Apr 30 2022, 10:58 AM
sdardis requested review of this revision.Apr 30 2022, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2022, 10:58 AM
atanasyan accepted this revision.May 7 2022, 10:07 AM

LGTM. Thanks.

This revision is now accepted and ready to land.May 7 2022, 10:07 AM

Thanks for the review, I'll try to get this committed in the next few days.

This revision was landed with ongoing or failed builds.May 11 2022, 3:46 PM
This revision was automatically updated to reflect the committed changes.