This is an archive of the discontinued LLVM Phabricator instance.

Fix "the the" typo in documentation and user facing strings
ClosedPublic

Authored by briantracy on Apr 29 2022, 6:42 PM.

Details

Summary

There are many more instances of this pattern, but I chose to limit this change to .rst files (docs), anything in libcxx/include, and string literals. These have the highest chance of being seen by end users.

Diff Detail

Event Timeline

briantracy created this revision.Apr 29 2022, 6:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2022, 6:42 PM
briantracy requested review of this revision.Apr 29 2022, 6:42 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptApr 29 2022, 6:42 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Thanks for these fixes. SGTM, but I want to see the CI pass.

clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp
135

I'm not familiar with the static analyzers, so I don't know whether this breaks a test.
I see the pre-commit CI couldn't apply your patch. Can you rebase this patch on main so the CI runs?

Updated sanitizer tests to include newly fixed error message strings.

Mordante accepted this revision.May 2 2022, 9:21 AM

I see some test time-outs, but they seem to happen quite often.
LGTM, but please wait a few days before landing this patch to give other reviewers time to have a look.

This revision is now accepted and ready to land.May 2 2022, 9:21 AM
martong accepted this revision.May 4 2022, 8:55 AM

LGTM

briantracy marked an inline comment as done.May 4 2022, 7:38 PM

Thank you Mark and Gabor. At your discretion, could you commit this on my behalf? My email is "brian.tracy33@gmail.com" and full name is "Brian Tracy". Thanks again.

ldionne accepted this revision.May 5 2022, 8:28 AM
ldionne added a subscriber: ldionne.

Thanks!

This revision was landed with ongoing or failed builds.May 5 2022, 8:52 AM
This revision was automatically updated to reflect the committed changes.