There are many more instances of this pattern, but I chose to limit this change to .rst files (docs), anything in libcxx/include, and string literals. These have the highest chance of being seen by end users.
Details
Details
- Reviewers
echristo Mordante martong ldionne - Group Reviewers
Restricted Project - Commits
- rG87a55137e2a2: Fix "the the" typo in documentation and user facing strings
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Thanks for these fixes. SGTM, but I want to see the CI pass.
clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp | ||
---|---|---|
135 | I'm not familiar with the static analyzers, so I don't know whether this breaks a test. |
Comment Actions
I see some test time-outs, but they seem to happen quite often.
LGTM, but please wait a few days before landing this patch to give other reviewers time to have a look.
Comment Actions
Thank you Mark and Gabor. At your discretion, could you commit this on my behalf? My email is "brian.tracy33@gmail.com" and full name is "Brian Tracy". Thanks again.
I'm not familiar with the static analyzers, so I don't know whether this breaks a test.
I see the pre-commit CI couldn't apply your patch. Can you rebase this patch on main so the CI runs?