This is an archive of the discontinued LLVM Phabricator instance.

Differential D123969

[LTO] Use names from more GlobalValue types to generate the ModuleID
Needs ReviewPublic

Authored by ormris on Apr 18 2022, 5:39 PM.

Details

Reviewers
tejohnson
pcc
mehdi_amini
Xiangling_L
Summary

In many situations the current version of getUniqueModuleId returns no hash. This causes problems for ThinLTOBitcodeWriter pass, and it will fall back to generating a regular LTO module in these cases. Since it's preferable to generate a ThinLTO module for performance reasons, this patch allows getUniqueModuleId to use more types of GlobalValues when generating the ModuleId hash. This mix has been fairly reliable for us.

This change is part of the Unified LTO RFC: https://discourse.llvm.org/t/rfc-a-unified-lto-bitcode-frontend/61774

Diff Detail

Event Timeline

ormris created this revision.Apr 18 2022, 5:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 5:39 PM
Herald added subscribers: steven_wu, hiraditya, inglorion. · View Herald Transcript
ormris requested review of this revision.Apr 18 2022, 5:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 5:39 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B160136: Diff 423496.Apr 18 2022, 6:39 PM
ormris updated this revision to Diff 423695.Apr 19 2022, 11:56 AM

Update patch with fixes for some PowerPC tests.

Herald added a subscriber: nemanjai. · View Herald TranscriptApr 19 2022, 11:56 AM
ormris added a reviewer: Xiangling_L.Apr 19 2022, 11:58 AM
Harbormaster completed remote builds in B160294: Diff 423695.Apr 19 2022, 12:25 PM
pcc requested changes to this revision.Apr 19 2022, 12:51 PM

I think this will introduce a correctness issue as it will become possible for two modules that can be linked together to have the same unique module ID.

This revision now requires changes to proceed.Apr 19 2022, 12:51 PM
ormris planned changes to this revision.Apr 19 2022, 1:31 PM

This patch causes several test failures. Currently working on resolving those.

ormris added a comment.Apr 19 2022, 4:25 PM

I think this will introduce a correctness issue as it will become possible for two modules that can be linked together to have the same unique module ID.

Our goal with this change was to reduce the hash collisions we were finding in internal testing of the unified LTO pipeline. The previous method wasn't quite broad enough for our internal tests. While we've certainly constructed test cases that cause a collision when using the changes in this patch, we've never seen a collision when working with real code.

ormris updated this revision to Diff 523203.May 17 2023, 3:55 PM

Changelog:

  • Changes are now implemented as a fallback, reducing necessary test changes.
  • Add option to allow testing cases using empty module IDs.
  • Reduce complexity of symbol filter
Herald added a subscriber: hoy. · View Herald TranscriptMay 17 2023, 3:55 PM
Harbormaster completed remote builds in B232727: Diff 523203.May 17 2023, 4:54 PM
ormris updated this revision to Diff 523474.May 18 2023, 11:37 AM

Update to remove unnecessary -unified-lto flag from tests.

Harbormaster completed remote builds in B232948: Diff 523474.May 18 2023, 1:41 PM
ormris updated this revision to Diff 526108.May 26 2023, 10:14 AM

clang-format

Harbormaster completed remote builds in B234895: Diff 526108.May 26 2023, 11:05 AM
ormris added a comment.Jul 5 2023, 10:27 AM

gentle ping

ormris added a comment.Jul 11 2023, 4:39 PM

ping

Revision Contents

PathSize
llvm/
lib/
Transforms/
Utils/
36 lines
test/
CodeGen/
PowerPC/
34 lines
82 lines
LTO/
Resolution/
X86/
19 lines
19 lines
X86/
27 lines
Transforms/
Util/
17 lines

Diff 423695

llvm/lib/Transforms/Utils/ModuleUtils.cpp

Show First 20 Lines • Show All 203 Lines • ▼ Show 20 Linesvoid llvm::filterDeadComdatFunctions(
}); });
} }
std::string llvm::getUniqueModuleId(Module *M) { std::string llvm::getUniqueModuleId(Module *M) {
MD5 Md5; MD5 Md5;
bool ExportsSymbols = false; bool ExportsSymbols = false;
auto AddGlobal = [&](GlobalValue &GV) { auto AddGlobal = [&](GlobalValue &GV) {
if (GV.isDeclaration() || GV.getName().startswith("llvm.") || if (GV.isDeclaration() || GV.getName().startswith("llvm.") ||
!GV.hasExternalLinkage() || GV.hasComdat()) (!GV.hasExternalLinkage() &&
!(GV.hasWeakLinkage() || GV.hasWeakAnyLinkage() ||
GV.hasWeakODRLinkage() || GV.hasLinkOnceLinkage() ||
GV.hasLinkOnceODRLinkage() || GV.hasCommonLinkage() ||
GV.hasComdat())) ||
GV.hasComdat())
return; return;
ExportsSymbols = true; ExportsSymbols = true;
Md5.update(GV.getName()); Md5.update(GV.getName());
Md5.update(ArrayRef<uint8_t>{0}); Md5.update(ArrayRef<uint8_t>{0});
}; };
if (auto *Used = M->getNamedGlobal("llvm.used")) {
if (const auto *A = dyn_cast<ConstantArray>(Used->getInitializer())) {
for (const Value *Op : A->operands()) {
if (const auto *GV = dyn_cast<GlobalValue>(Op->stripPointerCasts())) {
Md5.update(GV->getName());
Md5.update(ArrayRef<uint8_t>{0});
}
}
}
}
if (auto *Used = M->getNamedGlobal("llvm.global_ctors")) {
if (const auto *A = dyn_cast<ConstantArray>(Used->getInitializer())) {
for (const Value *Op : A->operands()) {
if (const auto *GV = dyn_cast<ConstantStruct>(Op)) {
auto *Elt = GV->getAggregateElement(1);
Md5.update(Elt->getName());
Md5.update(ArrayRef<uint8_t>{0});
}
}
}
}
Md5.update(M->getModuleIdentifier());
Md5.update(ArrayRef<uint8_t>{0});
ExportsSymbols = true;
for (auto &F : *M) for (auto &F : *M)
AddGlobal(F); AddGlobal(F);
for (auto &GV : M->globals()) for (auto &GV : M->globals())
AddGlobal(GV); AddGlobal(GV);
for (auto &GA : M->aliases()) for (auto &GA : M->aliases())
AddGlobal(GA); AddGlobal(GA);
for (auto &IF : M->ifuncs()) for (auto &IF : M->ifuncs())
AddGlobal(IF); AddGlobal(IF);
if (!ExportsSymbols) if (!ExportsSymbols)
return ""; return "";
MD5::MD5Result R; MD5::MD5Result R;
Md5.final(R); Md5.final(R);
SmallString<32> Str; SmallString<32> Str;
MD5::stringifyResult(R, Str); MD5::stringifyResult(R, Str);
LLVM_DEBUG(dbgs() << "Generated ModuleID: " << Str.str() << "\n");
return ("." + Str).str(); return ("." + Str).str();
} }
void VFABI::setVectorVariantNames(CallInst *CI, void VFABI::setVectorVariantNames(CallInst *CI,
ArrayRef<std::string> VariantMappings) { ArrayRef<std::string> VariantMappings) {
if (VariantMappings.empty()) if (VariantMappings.empty())
return; return;
Show All 36 Lines

llvm/test/CodeGen/PowerPC/aix-static-init-default-priority.ll

Show All 22 Lines
define internal void @destruct2() { define internal void @destruct2() {
ret void ret void
} }
; CHECK: .lglobl init1[DS] ; CHECK: .lglobl init1[DS]
; CHECK: .lglobl .init1 ; CHECK: .lglobl .init1
; CHECK: .csect init1[DS] ; CHECK: .csect init1[DS]
; CHECK: __sinit80000000_clang_ac404299654d2af7eae71e75c17f7c9b_0: # @init1 ; CHECK: __sinit80000000_clang_a1bb1778cc94c1a0a7637d6054790664_0: # @init1
; CHECK: .init1: ; CHECK: .init1:
; CHECK: .__sinit80000000_clang_ac404299654d2af7eae71e75c17f7c9b_0: ; CHECK: .__sinit80000000_clang_a1bb1778cc94c1a0a7637d6054790664_0:
; CHECK: .lglobl destruct1[DS] ; CHECK: .lglobl destruct1[DS]
; CHECK: .lglobl .destruct1 ; CHECK: .lglobl .destruct1
; CHECK: .csect destruct1[DS] ; CHECK: .csect destruct1[DS]
; CHECK: __sterm80000000_clang_ac404299654d2af7eae71e75c17f7c9b_0: # @destruct1 ; CHECK: __sterm80000000_clang_a1bb1778cc94c1a0a7637d6054790664_0: # @destruct1
; CHECK: .destruct1: ; CHECK: .destruct1:
; CHECK: .__sterm80000000_clang_ac404299654d2af7eae71e75c17f7c9b_0: ; CHECK: .__sterm80000000_clang_a1bb1778cc94c1a0a7637d6054790664_0:
; CHECK: .lglobl init2[DS] ; CHECK: .lglobl init2[DS]
; CHECK: .lglobl .init2 ; CHECK: .lglobl .init2
; CHECK: .csect init2[DS] ; CHECK: .csect init2[DS]
; CHECK: __sinit80000000_clang_ac404299654d2af7eae71e75c17f7c9b_1: # @init2 ; CHECK: __sinit80000000_clang_a1bb1778cc94c1a0a7637d6054790664_1: # @init2
; CHECK: .init2: ; CHECK: .init2:
; CHECK: .__sinit80000000_clang_ac404299654d2af7eae71e75c17f7c9b_1: ; CHECK: .__sinit80000000_clang_a1bb1778cc94c1a0a7637d6054790664_1:
; CHECK: .lglobl destruct2[DS] ; CHECK: .lglobl destruct2[DS]
; CHECK: .lglobl .destruct2 ; CHECK: .lglobl .destruct2
; CHECK: .csect destruct2[DS] ; CHECK: .csect destruct2[DS]
; CHECK: __sterm80000000_clang_ac404299654d2af7eae71e75c17f7c9b_1: # @destruct2 ; CHECK: __sterm80000000_clang_a1bb1778cc94c1a0a7637d6054790664_1: # @destruct2
; CHECK: .destruct2: ; CHECK: .destruct2:
; CHECK: .__sterm80000000_clang_ac404299654d2af7eae71e75c17f7c9b_1: ; CHECK: .__sterm80000000_clang_a1bb1778cc94c1a0a7637d6054790664_1:
; CHECK: .globl __sinit80000000_clang_ac404299654d2af7eae71e75c17f7c9b_0 ; CHECK: .globl __sinit80000000_clang_a1bb1778cc94c1a0a7637d6054790664_0
; CHECK: .globl .__sinit80000000_clang_ac404299654d2af7eae71e75c17f7c9b_0 ; CHECK: .globl .__sinit80000000_clang_a1bb1778cc94c1a0a7637d6054790664_0
; CHECK: .globl __sinit80000000_clang_ac404299654d2af7eae71e75c17f7c9b_1 ; CHECK: .globl __sinit80000000_clang_a1bb1778cc94c1a0a7637d6054790664_1
; CHECK: .globl .__sinit80000000_clang_ac404299654d2af7eae71e75c17f7c9b_1 ; CHECK: .globl .__sinit80000000_clang_a1bb1778cc94c1a0a7637d6054790664_1
; CHECK: .globl __sterm80000000_clang_ac404299654d2af7eae71e75c17f7c9b_0 ; CHECK: .globl __sterm80000000_clang_a1bb1778cc94c1a0a7637d6054790664_0
; CHECK: .globl .__sterm80000000_clang_ac404299654d2af7eae71e75c17f7c9b_0 ; CHECK: .globl .__sterm80000000_clang_a1bb1778cc94c1a0a7637d6054790664_0
; CHECK: .globl __sterm80000000_clang_ac404299654d2af7eae71e75c17f7c9b_1 ; CHECK: .globl __sterm80000000_clang_a1bb1778cc94c1a0a7637d6054790664_1
; CHECK: .globl .__sterm80000000_clang_ac404299654d2af7eae71e75c17f7c9b_1 ; CHECK: .globl .__sterm80000000_clang_a1bb1778cc94c1a0a7637d6054790664_1

llvm/test/CodeGen/PowerPC/aix-static-init-non-default-priority.ll

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
define void @df5() { define void @df5() {
ret void ret void
} }
; CHECK: .globl cf1[DS] ; CHECK: .globl cf1[DS]
; CHECK: .globl .cf1 ; CHECK: .globl .cf1
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect cf1[DS] ; CHECK: .csect cf1[DS]
; CHECK: __sinit00000000_clang_f6a1bc9396775a64c6249effda300afe_0: # @cf1 ; CHECK: __sinit00000000_clang_68423256c9923e2ef42dd17bbb732f44_0: # @cf1
; CHECK: .cf1: ; CHECK: .cf1:
; CHECK: .__sinit00000000_clang_f6a1bc9396775a64c6249effda300afe_0: ; CHECK: .__sinit00000000_clang_68423256c9923e2ef42dd17bbb732f44_0:
; CHECK: .globl cf2[DS] ; CHECK: .globl cf2[DS]
; CHECK: .globl .cf2 ; CHECK: .globl .cf2
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect cf2[DS] ; CHECK: .csect cf2[DS]
; CHECK: __sinit00000024_clang_f6a1bc9396775a64c6249effda300afe_1: # @cf2 ; CHECK: __sinit00000024_clang_68423256c9923e2ef42dd17bbb732f44_1: # @cf2
; CHECK: .cf2: ; CHECK: .cf2:
; CHECK: .__sinit00000024_clang_f6a1bc9396775a64c6249effda300afe_1: ; CHECK: .__sinit00000024_clang_68423256c9923e2ef42dd17bbb732f44_1:
; CHECK: .globl cf3[DS] ; CHECK: .globl cf3[DS]
; CHECK: .globl .cf3 ; CHECK: .globl .cf3
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect cf3[DS] ; CHECK: .csect cf3[DS]
; CHECK: __sinit000003ec_clang_f6a1bc9396775a64c6249effda300afe_2: # @cf3 ; CHECK: __sinit000003ec_clang_68423256c9923e2ef42dd17bbb732f44_2: # @cf3
; CHECK: .cf3: ; CHECK: .cf3:
; CHECK: .__sinit000003ec_clang_f6a1bc9396775a64c6249effda300afe_2: ; CHECK: .__sinit000003ec_clang_68423256c9923e2ef42dd17bbb732f44_2:
; CHECK: .globl cf4[DS] ; CHECK: .globl cf4[DS]
; CHECK: .globl .cf4 ; CHECK: .globl .cf4
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect cf4[DS] ; CHECK: .csect cf4[DS]
; CHECK: __sinit00008c55_clang_f6a1bc9396775a64c6249effda300afe_3: # @cf4 ; CHECK: __sinit00008c55_clang_68423256c9923e2ef42dd17bbb732f44_3: # @cf4
; CHECK: .cf4: ; CHECK: .cf4:
; CHECK: .__sinit00008c55_clang_f6a1bc9396775a64c6249effda300afe_3: ; CHECK: .__sinit00008c55_clang_68423256c9923e2ef42dd17bbb732f44_3:
; CHECK: .globl cf5[DS] ; CHECK: .globl cf5[DS]
; CHECK: .globl .cf5 ; CHECK: .globl .cf5
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect cf5[DS] ; CHECK: .csect cf5[DS]
; CHECK: __sinit7ffffc01_clang_f6a1bc9396775a64c6249effda300afe_4: # @cf5 ; CHECK: __sinit7ffffc01_clang_68423256c9923e2ef42dd17bbb732f44_4: # @cf5
; CHECK: .cf5: ; CHECK: .cf5:
; CHECK: .__sinit7ffffc01_clang_f6a1bc9396775a64c6249effda300afe_4: ; CHECK: .__sinit7ffffc01_clang_68423256c9923e2ef42dd17bbb732f44_4:
; CHECK: .globl df1[DS] ; CHECK: .globl df1[DS]
; CHECK: .globl .df1 ; CHECK: .globl .df1
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect df1[DS] ; CHECK: .csect df1[DS]
; CHECK: __sterm00000014_clang_f6a1bc9396775a64c6249effda300afe_0: # @df1 ; CHECK: __sterm00000014_clang_68423256c9923e2ef42dd17bbb732f44_0: # @df1
; CHECK: .df1: ; CHECK: .df1:
; CHECK: .__sterm00000014_clang_f6a1bc9396775a64c6249effda300afe_0: ; CHECK: .__sterm00000014_clang_68423256c9923e2ef42dd17bbb732f44_0:
; CHECK: .globl df2[DS] ; CHECK: .globl df2[DS]
; CHECK: .globl .df2 ; CHECK: .globl .df2
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect df2[DS] ; CHECK: .csect df2[DS]
; CHECK: __sterm000003d4_clang_f6a1bc9396775a64c6249effda300afe_1: # @df2 ; CHECK: __sterm000003d4_clang_68423256c9923e2ef42dd17bbb732f44_1: # @df2
; CHECK: .df2: ; CHECK: .df2:
; CHECK: .__sterm000003d4_clang_f6a1bc9396775a64c6249effda300afe_1: ; CHECK: .__sterm000003d4_clang_68423256c9923e2ef42dd17bbb732f44_1:
; CHECK: .globl df3[DS] ; CHECK: .globl df3[DS]
; CHECK: .globl .df3 ; CHECK: .globl .df3
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect df3[DS] ; CHECK: .csect df3[DS]
; CHECK: __sterm000007ff_clang_f6a1bc9396775a64c6249effda300afe_2: # @df3 ; CHECK: __sterm000007ff_clang_68423256c9923e2ef42dd17bbb732f44_2: # @df3
; CHECK: .df3: ; CHECK: .df3:
; CHECK: .__sterm000007ff_clang_f6a1bc9396775a64c6249effda300afe_2: ; CHECK: .__sterm000007ff_clang_68423256c9923e2ef42dd17bbb732f44_2:
; CHECK: .globl df4[DS] ; CHECK: .globl df4[DS]
; CHECK: .globl .df4 ; CHECK: .globl .df4
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect df4[DS] ; CHECK: .csect df4[DS]
; CHECK: __sterm7fff2211_clang_f6a1bc9396775a64c6249effda300afe_3: # @df4 ; CHECK: __sterm7fff2211_clang_68423256c9923e2ef42dd17bbb732f44_3: # @df4
; CHECK: .df4: ; CHECK: .df4:
; CHECK: .__sterm7fff2211_clang_f6a1bc9396775a64c6249effda300afe_3: ; CHECK: .__sterm7fff2211_clang_68423256c9923e2ef42dd17bbb732f44_3:
; CHECK: .globl df5[DS] ; CHECK: .globl df5[DS]
; CHECK: .globl .df5 ; CHECK: .globl .df5
; CHECK: .align 2 ; CHECK: .align 2
; CHECK: .csect df5[DS] ; CHECK: .csect df5[DS]
; CHECK: __sterm80000000_clang_f6a1bc9396775a64c6249effda300afe_4: # @df5 ; CHECK: __sterm80000000_clang_68423256c9923e2ef42dd17bbb732f44_4: # @df5
; CHECK: .df5: ; CHECK: .df5:
; CHECK: .__sterm80000000_clang_f6a1bc9396775a64c6249effda300afe_4: ; CHECK: .__sterm80000000_clang_68423256c9923e2ef42dd17bbb732f44_4:
; CHECK: .globl __sinit00000000_clang_f6a1bc9396775a64c6249effda300afe_0 ; CHECK: .globl __sinit00000000_clang_68423256c9923e2ef42dd17bbb732f44_0
; CHECK: .globl .__sinit00000000_clang_f6a1bc9396775a64c6249effda300afe_0 ; CHECK: .globl .__sinit00000000_clang_68423256c9923e2ef42dd17bbb732f44_0
; CHECK: .globl __sinit00000024_clang_f6a1bc9396775a64c6249effda300afe_1 ; CHECK: .globl __sinit00000024_clang_68423256c9923e2ef42dd17bbb732f44_1
; CHECK: .globl .__sinit00000024_clang_f6a1bc9396775a64c6249effda300afe_1 ; CHECK: .globl .__sinit00000024_clang_68423256c9923e2ef42dd17bbb732f44_1
; CHECK: .globl __sinit000003ec_clang_f6a1bc9396775a64c6249effda300afe_2 ; CHECK: .globl __sinit000003ec_clang_68423256c9923e2ef42dd17bbb732f44_2
; CHECK: .globl .__sinit000003ec_clang_f6a1bc9396775a64c6249effda300afe_2 ; CHECK: .globl .__sinit000003ec_clang_68423256c9923e2ef42dd17bbb732f44_2
; CHECK: .globl __sinit00008c55_clang_f6a1bc9396775a64c6249effda300afe_3 ; CHECK: .globl __sinit00008c55_clang_68423256c9923e2ef42dd17bbb732f44_3
; CHECK: .globl .__sinit00008c55_clang_f6a1bc9396775a64c6249effda300afe_3 ; CHECK: .globl .__sinit00008c55_clang_68423256c9923e2ef42dd17bbb732f44_3
; CHECK: .globl __sinit7ffffc01_clang_f6a1bc9396775a64c6249effda300afe_4 ; CHECK: .globl __sinit7ffffc01_clang_68423256c9923e2ef42dd17bbb732f44_4
; CHECK: .globl .__sinit7ffffc01_clang_f6a1bc9396775a64c6249effda300afe_4 ; CHECK: .globl .__sinit7ffffc01_clang_68423256c9923e2ef42dd17bbb732f44_4
; CHECK: .globl __sterm00000014_clang_f6a1bc9396775a64c6249effda300afe_0 ; CHECK: .globl __sterm00000014_clang_68423256c9923e2ef42dd17bbb732f44_0
; CHECK: .globl .__sterm00000014_clang_f6a1bc9396775a64c6249effda300afe_0 ; CHECK: .globl .__sterm00000014_clang_68423256c9923e2ef42dd17bbb732f44_0
; CHECK: .globl __sterm000003d4_clang_f6a1bc9396775a64c6249effda300afe_1 ; CHECK: .globl __sterm000003d4_clang_68423256c9923e2ef42dd17bbb732f44_1
; CHECK: .globl .__sterm000003d4_clang_f6a1bc9396775a64c6249effda300afe_1 ; CHECK: .globl .__sterm000003d4_clang_68423256c9923e2ef42dd17bbb732f44_1
; CHECK: .globl __sterm000007ff_clang_f6a1bc9396775a64c6249effda300afe_2 ; CHECK: .globl __sterm000007ff_clang_68423256c9923e2ef42dd17bbb732f44_2
; CHECK: .globl .__sterm000007ff_clang_f6a1bc9396775a64c6249effda300afe_2 ; CHECK: .globl .__sterm000007ff_clang_68423256c9923e2ef42dd17bbb732f44_2
; CHECK: .globl __sterm7fff2211_clang_f6a1bc9396775a64c6249effda300afe_3 ; CHECK: .globl __sterm7fff2211_clang_68423256c9923e2ef42dd17bbb732f44_3
; CHECK: .globl .__sterm7fff2211_clang_f6a1bc9396775a64c6249effda300afe_3 ; CHECK: .globl .__sterm7fff2211_clang_68423256c9923e2ef42dd17bbb732f44_3
; CHECK: .globl __sterm80000000_clang_f6a1bc9396775a64c6249effda300afe_4 ; CHECK: .globl __sterm80000000_clang_68423256c9923e2ef42dd17bbb732f44_4
; CHECK: .globl .__sterm80000000_clang_f6a1bc9396775a64c6249effda300afe_4 ; CHECK: .globl .__sterm80000000_clang_68423256c9923e2ef42dd17bbb732f44_4

llvm/test/LTO/Resolution/X86/llvm-used-moduleid.ll

  • This file was added.
; RUN: opt <%s -thinlto-bc -thinlto-split-lto-unit -o %t0
; RUN: llvm-bcanalyzer %t0 | FileCheck %s
target triple="x86_64-pc-linux-gnu"
@llvm.used = appending global [1 x i8*] [i8* bitcast (void ()* @a to i8*)], !type !0
declare i1 @llvm.type.test(i8*, metadata)
declare void @llvm.assume(i1)
; CHECK: GLOBALVAL_SUMMARY_BLOCK
; CHECK: FULL_LTO_GLOBALVAL_SUMMARY_BLOCK
define internal void @a() {
%1 = call i1 @llvm.type.test(i8* undef, metadata !"a")
call void @llvm.assume(i1 %1)
ret void
}
!0 = !{i64 16, !"a"}

llvm/test/LTO/Resolution/X86/weak-linkage-moduleid.ll

  • This file was added.
; RUN: opt <%s -thinlto-bc -thinlto-split-lto-unit -o %t0
; RUN: llvm-bcanalyzer %t0 | FileCheck %s
target triple="x86_64-pc-linux-gnu"
@p = weak global void ()* @a, !type !0
declare i1 @llvm.type.test(i8*, metadata)
declare void @llvm.assume(i1)
; CHECK: GLOBALVAL_SUMMARY_BLOCK
; CHECK: FULL_LTO_GLOBALVAL_SUMMARY_BLOCK
define internal void @a() {
%1 = call i1 @llvm.type.test(i8* undef, metadata !"a")
call void @llvm.assume(i1 %1)
ret void
}
!0 = !{i64 16, !"a"}

llvm/test/LTO/X86/path-moduleid.ll

  • This file was added.
; REQUIRES: asserts
; Test that chaning the path to the module doesn't effect the ModuleID. This
; file and Inputs/path-moduleid.ll have the same content, and thus should have
; the same ModuleID.
; RUN: opt -o /dev/null -thinlto-bc -thinlto-split-lto-unit=1 --debug-only=moduleutils %s 2>%t0
; RUN: mkdir -p %t; cp %s %t/path-moduleid.ll
; RUN: opt -o /dev/null -thinlto-bc -thinlto-split-lto-unit=1 --debug-only=moduleutils %t/path-moduleid.ll 2>%t1
; RUN: FileCheck %s <%t0
; RUN: FileCheck %s <%t1
; RUN: not diff %t0 %t1
; CHECK: Generated ModuleID:
target triple="x86_64-pc-linux-gnu"
@llvm.used = appending global [1 x i8*] [i8* bitcast (void ()* @a to i8*)], !type !0
declare i1 @llvm.type.test(i8*, metadata)
declare void @llvm.assume(i1)
define internal void @a() {
%1 = call i1 @llvm.type.test(i8* undef, metadata !"a")
call void @llvm.assume(i1 %1)
ret void
}
!0 = !{i64 16, !"a"}

llvm/test/Transforms/Util/generate-moduleid.ll

  • This file was added.
; REQUIRES: asserts
; RUN: opt --thinlto-split-lto-unit=1 --thinlto-bc -o %t0 -debug-only=moduleutils <%s 2>&1 | FileCheck %s
; CHECK: Generated ModuleID
target triple="x86_64-pc-linux-gnu"
declare i1 @llvm.type.test(i8*, metadata)
define internal void @foo() !type !1{
entry:
%0 = tail call i1 @llvm.type.test(i8* null, metadata !"")
ret void
}
@llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 103, void ()* @foo, i8* null }]
!1 = !{i64 0, !"foo"}